Re: Release Lucene 9.4.2

I have now started the release process and created a draft of release notes at https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+9.4.2. Feel free to edit directly if you have improvements in mind. On Wed, Nov 16, 2022 at 4:57 PM Robert Muir wrote: > +1, thanks for the patience. I

Re: Release Lucene 9.4.2

+1, thanks for the patience. I feel we at least made the effort to root out any more of these and hopefully prevent a 9.4.3 with another overflow bug. On Wed, Nov 16, 2022 at 10:55 AM Adrien Grand wrote: > > It looks like we're good with the changes we wanted to get in for 9.4.2. > > I plan on

Re: Release Lucene 9.4.2

It looks like we're good with the changes we wanted to get in for 9.4.2. I plan on starting the release process tomorrow if there are no objections. On Fri, Nov 11, 2022 at 4:22 PM Robert Muir wrote: > These are the 9.4.2 completed issues: > > https://github.com/apache/lucene/pull/11905 <--

Re: Release Lucene 9.4.2

These are the 9.4.2 completed issues: https://github.com/apache/lucene/pull/11905 <-- bug and associated monster test https://github.com/apache/lucene/pull/11916 <-- checkindex improvement https://github.com/apache/lucene/pull/11919 <-- checkindex improvement These are the remaining issues:

Re: Release Lucene 9.4.2

+1 makes sense. I do think given this is the second similar-flavored bug we've found that we should be thorough and try to get them all rather than having a 9.4.3 ... On Wed, Nov 9, 2022 at 10:25 AM Julie Tibshirani wrote: > > +1 from me for a bugfix release once we've solidified testing. Thanks

Re: Release Lucene 9.4.2

+1 from me for a bugfix release once we've solidified testing. Thanks to everyone working on improving tests and static analysis -- this now is our second time encountering a bad arithmetic bug and it's important to get ahead of these issues! Julie On Wed, Nov 9, 2022 at 8:26 AM Robert Muir

Re: Release Lucene 9.4.2

Thank you Adrien! I created an issue for the static analysis piece, but I'm not currently working on it yet. This could be a fun one, if anyone is interested, to flush a bunch of these bugs out at once: https://github.com/apache/lucene/issues/11910 On Wed, Nov 9, 2022 at 10:48 AM Adrien Grand

Re: Release Lucene 9.4.2

Totally Robert, I was not trying to add any time pressure, next week is totally fine. I mostly wanted to get the discussion started because folks sometimes have one or two bug fixes they'd like to fold into a bugfix release so I wanted to give them time to plan. Friday is also a public holiday

Re: Release Lucene 9.4.2

Can we please have a few days to improve the test situation? I think we need to beef up checkindex to exercise seek() on the vectors, also we need to look at static analysis to try to find other similar bugs. This would help prevent "whack-a-mole" and improve correctness going forwards. I want to

Re: Release Lucene 9.4.2

Thank you! +1 :-) Am 09.11.22 um 16:38 schrieb Adrien Grand: Hello all, A bad integer overflow has been discovered in the KNN vectors format, which affects segments that have more than ~16M vectors. I'd like to do a bugfix release when the bug