Re: The need for a Lucene 9.9.2 release

2024-01-24 Thread Marios Trivyzas
It's the exact same thing as in Elasticsearch, as we inherit some code for ES in CrateDB: https://github.com/crate/crate/pull/15408 so don't know if it worths adding it, but your call. Just for the full context, for CrateDB we have also an issue with the toolchain maven plugin since it downloaded

Re: The need for a Lucene 9.9.2 release

2024-01-24 Thread Chris Hegarty
Hi Marios, If you have a link to the CrateDB issue, I’ll add it to JDK-8323659. -Chris. > On 24 Jan 2024, at 14:26, Chris Hegarty > wrote: > > Hi Marios, > > Thanks for raising awareness of this JDK bug. > > Just to be clear, and for other readers of this list, the JDK bug is >

Re: The need for a Lucene 9.9.2 release

2024-01-24 Thread Chris Hegarty
Hi Marios, Thanks for raising awareness of this JDK bug. Just to be clear, and for other readers of this list, the JDK bug is orthogonal to whether or not we include support for Java 22 in a future Lucene release. > On 24 Jan 2024, at 14:15, Marios Trivyzas wrote: > > Hi, > > Just an FYI

Re: The need for a Lucene 9.9.2 release

2024-01-24 Thread Marios Trivyzas
Hi, Just an FYI regarding Java22. In CrateDB we experienced issues with a bug: https://bugs.openjdk.org/browse/JDK-8323659 >From a quick search, haven't seen usage of `LinkedTransferQueue` in Lucene, so just wanted to share the issue. Cheers -- Marios On Wed, Jan 24, 2024 at 4:08 PM Chris

Re: The need for a Lucene 9.9.2 release

2024-01-24 Thread Chris Hegarty
Hi Uwe, > On 24 Jan 2024, at 13:29, Uwe Schindler wrote: > > Hi, > > Now I understand why you asked yesterday in the Java 22 PR. :-) I was just gathering my thoughts and considering what options we have relating to releases (bugfix or minor). > Do you think we should add Java 22 support for

Re: The need for a Lucene 9.9.2 release

2024-01-24 Thread Uwe Schindler
Hi, Now I understand why you asked yesterday in the Java 22 PR. Do you think we should add Java 22 support for MMAP and Vectors? It is a bit risky, because API may still change, but the worst that could happen is that people need to pass a sysprop in Java 22 to disable broken MMAP (if

Re: The need for a Lucene 9.9.2 release

2024-01-23 Thread Michael Wechner
thanks for discovering and fixing! Michael Am 23.01.24 um 18:36 schrieb Chris Hegarty: Hi, We’ve encounter a serious issue with the recent Lucene 9.9.1 release, which warrants a 9.9.2. The issue is a NPE when sampling for quantization in Lucene99HnswScalarQuantizedVectorsFormat [1].

Re: The need for a Lucene 9.9.2 release

2024-01-23 Thread Chris Hegarty
Hi Christine, Including 13014 seems reasonable, and the issue appears quite severe. Let’s see if we can get 13014 reviewed and merged in the next day or two. If so, then it seems reasonable to include. -Chris. > On 23 Jan 2024, at 18:30, Christine Poerschke (BLOOMBERG/ LONDON) > wrote: > >