I'll fix the message to make it clear you are not running on WINDOWS
but rather our WindowsFS.
I agree we should strive to have our tests be portable across OS's ...
But unfortunately this test case is for a nasty corruption bug
(LUCENE-5574) that can't happen on Windows...
Mike McCandless
: I'll fix the message to make it clear you are not running on WINDOWS
: but rather our WindowsFS.
thanks.
: I agree we should strive to have our tests be portable across OS's ...
:
: But unfortunately this test case is for a nasty corruption bug
: (LUCENE-5574) that can't happen on Windows...
On Tue, Dec 2, 2014 at 12:01 PM, Chris Hostetter
hossman_luc...@fucit.org wrote:
my question: rather then assumeFalse() ~1/10 of the time (even when the
underlying OS/FS is *NOT* windows) why not unwrap that (mock) windowsfs
and still run the test using the real file system?
Wouldn't that be
: assumeFalse(this test can't run on Windows, Constants.WINDOWS);
:
: MockDirectoryWrapper dir = newMockDirectory();
: +if (TestUtil.isWindowsFS(dir)) {
: + dir.close();
: + assumeFalse(this test can't run on Windows, true);
: +}
this specific assume msg seems like
-1.
our test framework doesnt need to support this. the problem here is
the test, its no good and doesnt work on windows. An assume is the
correct answer for a shitty test.
On Mon, Dec 1, 2014 at 5:46 PM, Chris Hostetter
hossman_luc...@fucit.org wrote:
: assumeFalse(this test can't run on
