Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread David Smiley
Thanks Michael for sharing your code snippet on how to circumvent the limit. My reaction to this is the same as Alessandro. I just created a PR to make the limit configurable: https://github.com/apache/lucene/pull/12306 If there is to be a veto presented to the PR, it should include technical

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Michael Wechner
IIUC KnnVectorField is deprecated and one is supposed to use KnnFloatVectorField when using float as vector values, right? Am 17.05.23 um 16:41 schrieb Michael Sokolov: see https://markmail.org/message/kf4nzoqyhwacb7ri On Wed, May 17, 2023 at 10:09 AM David Smiley wrote: > easily be

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Michael Wechner
I try to better understand the code, so IIUC vector MAX_DIMENSIONS is currently used inside lucene/core/src/java/org/apache/lucene/document/FieldType.java lucene/core/src/java/org/apache/lucene/document/KnnFloatVectorField.java

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Mayya Sharipova
Alessandro, Thanks for raising the code of conduct; it is very discouraging and intimidating to participate in discussions where such language is used especially by senior members. Michael S., thanks for your suggestion and that's what we used in Elasticsearch to raise dims limit, and Alessandro,

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Alessandro Benedetti
Robert, A gentle reminder of the https://www.apache.org/foundation/policies/conduct.html. I've read many e-mails about this topic that ended up in a tone that is not up to the standard of a healthy community. To be specific and pragmatic how you addressed Gus here, how you addressed the rest of

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Robert Muir
As a reminder this isn't the Disney Plus channel and I'll use strong language if I fucking want to. On Wed, May 17, 2023, 4:45 AM Alessandro Benedetti wrote: > Robert, > A gentle reminder of the > https://www.apache.org/foundation/policies/conduct.html. > I've read many e-mails about this

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Michael Sokolov
I think I've said before on this list we don't actually enforce the limit in any way that can't easily be circumvented by a user. The codec already supports any size vector - it doesn't impose any limit. The way the API is written you can *already today* create an index with max-int sized vectors

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Alessandro Benedetti
Thanks, Michael, that example backs even more strongly the need of cleaning it up and making the limit configurable without the need for custom field types I guess (I was taking a look at the code again, and it seems the limit is also checked twice: in

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread Michael Sokolov
see https://markmail.org/message/kf4nzoqyhwacb7ri On Wed, May 17, 2023 at 10:09 AM David Smiley wrote: > > easily be circumvented by a user > > This is a revelation to me and others, if true. Michael, please then > point to a test or code snippet that shows the Lucene user community what >

Re: [VOTE] Dimension Limit for KNN Vectors

2023-05-17 Thread David Smiley
> easily be circumvented by a user This is a revelation to me and others, if true. Michael, please then point to a test or code snippet that shows the Lucene user community what they want to see so they are unblocked from their explorations of vector search. ~ David Smiley Apache Lucene/Solr