Re: Is it Time to Deprecate the Legacy Facets API

2021-10-27 Thread Ishan Chattopadhyaya
> Personally I'd love to see us stop maintaining the duplicated code of > the underlying implementations. I wouldn't mind losing the legacy > syntax as well - I'll take a clear, verbose API over a less-clear, > concise one any day. But I'm probably a minority there. +1, agree with Jason here,

Re: Is it Time to Deprecate the Legacy Facets API

2021-10-27 Thread Ishan Chattopadhyaya
Should we deprecate classic faceting in 9x now? > It's worth investigating deprecating the stats component also. I believe JSON facets covers that functionality as well. It will be painful for users though to switch over unfortunately. +1, lets deprecate stats component too. On Thu, Jan 28,

Re: Is it Time to Deprecate the Legacy Facets API

2021-01-27 Thread Joel Bernstein
It's worth investigating deprecating the stats component also. I believe JSON facets covers that functionality as well. It will be painful for users though to switch over unfortunately. Joel Bernstein http://joelsolr.blogspot.com/ On Fri, Jan 22, 2021 at 1:14 PM Jason Gerlowski wrote: >

Re: Is it Time to Deprecate the Legacy Facets API

2021-01-22 Thread Jason Gerlowski
Personally I'd love to see us stop maintaining the duplicated code of the underlying implementations. I wouldn't mind losing the legacy syntax as well - I'll take a clear, verbose API over a less-clear, concise one any day. But I'm probably a minority there. Either way I agree with Michael when

Re: Is it Time to Deprecate the Legacy Facets API

2021-01-22 Thread Michael Gibney
I agree it would make long-term sense to consolidate the backend implementation. I think leaving the "classic" user-facing facet API (with JSON Facet module as a backend) would be a good idea. Either way, I think a first step would be checking for parity between existing backend implementations --

Re: Is it Time to Deprecate the Legacy Facets API

2021-01-21 Thread Robert Muir
Do these two options conflate concerns of input format vs. actual algorithm? That was always my disappointment. I feel like the java apis are off here at the lower level, and it hurts the user. I don't talk about the input format from the user, instead I mean the execution of the faceting query.

Re: Is it Time to Deprecate the Legacy Facets API

2021-01-21 Thread David Smiley
There's a JIRA issue about this from 5 years ago: https://issues.apache.org/jira/browse/SOLR-7296 I don't recall seeing any resistance to the idea of having the JSON Faceting module act as a back-end to the front-end (API surface) of Solr's common/classic/original/whatever faceting API. I don't

Is it Time to Deprecate the Legacy Facets API

2021-01-21 Thread Marcus Eagan
Hi all, Sorry to spam the list. I am querying the list in such quick succession because of a realization I came to while on Twitter. Is it time to deprecate the Legacy Facet API? I understood in the past that they behaved slightly differently. Now, I'm wondering if it makes sense to keep the