Re: New branch and feature freeze for Lucene/Solr 8.10.0

That test rarely fails - hence warrants an investigation IMO On Wed, 22 Sep 2021, 03:01 Timothy Potter, wrote: > Just an update here ... I'm still trying to get an RC built but the > test suite continues to fail with flaky tests, this past run it was: >

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Just an update here ... I'm still trying to get an RC built but the test suite continues to fail with flaky tests, this past run it was: org.apache.solr.util.TestCircuitBreaker.testResponseWithCBTiming, which doesn't look like it fails all that much, see:

Re: New branch and feature freeze for Lucene/Solr 8.10.0

That was a bad backport from main, and I was mainly paying attention to the main jenkins tests. Apologies about that oversight. Please see PR https://github.com/apache/lucene-solr/pull/2578 On Mon, Sep 20, 2021 at 2:21 PM Uwe Schindler wrote: > Hi, > > This test also fails on Jenkins all the

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Hi, This test also fails on Jenkins all the time. In all branches and on all platforms. All the time, it's definitely a regression. Uwe Am 20. September 2021 19:13:56 UTC schrieb Timothy Potter : >Started building the RC1 again today and the smoke tester failed. The >culprit was:

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Started building the RC1 again today and the smoke tester failed. The culprit was: org.apache.solr.search.TestFiltering.testRandomFiltering Re-ran that test from the RC checkout and it failed again: [junit4] 2> 5490 ERROR (TEST-TestFiltering.testRandomFiltering-seed#[9A85A1D74D8AACF9]) [ ]

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Can we move discussion about the implementation to the JIRA issue or the PR? I'm not a lawyer, so not playing with the GPL fire is the easiest way for me to avoid getting burned. The regex I have is pretty straightforward, I do not feel like it is a great cause for alarm. On Fri, Sep 17, 2021 at

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Given that we don't ship the code or binaries that involve that python library, do we need to care about the license? I'm skeptical of hand rolled regex and would rather favour either of the libraries Jan mentioned. Just my two cents. On Sat, 18 Sep, 2021, 12:02 am Mike Drob, wrote: > The

Re: New branch and feature freeze for Lucene/Solr 8.10.0

The second library you linked, Jan, is AGPL. Thank you for continuing to look for alternatives. I have some regular expressions cooked up locally that I think will let us read the split lines going forward, and will put up the patch shortly. On Fri, Sep 17, 2021 at 7:45 AM Yuval Paz wrote: >

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Not sure if this is something can be changed easily, but if the problem is caused by some parsers don't know how to parse line wrapping in the middle of the Hash why not moving the hash completely to the new line (the specification allow new line at any point in the value)? The commit hash + date

Re: New branch and feature freeze for Lucene/Solr 8.10.0

That was not my point, there are several choices - this from 2020 which also work ootb: https://pypi.org/project/java-manifest/ It has TWO stars :), conforms to the specs and solves our needs in pure python... If other tools cannot follow a spec then IMO that's their problem, not ours. Jan >

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Sure, but that package is archived/read-only, GPLv3. with 3 watchers and 1 star. On Fri, Sep 17, 2021 at 4:27 AM Jan Høydahl wrote: > > Let's just follow the spec and move on. > > Just tested this python package, which has no problem parsing the problematic > manifest

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Let's just follow the spec and move on. Just tested this python package, which has no problem parsing the problematic manifest https://pypi.org/project/jarmanifest/ >>> manifest.getAttributes("/tmp/lucene-manifest.mf") [{'implementationversion': '9.0.0-SNAPSHOT

Re: New branch and feature freeze for Lucene/Solr 8.10.0

We could do a few things to keep everyone happy - 1) keep abbreviated hash in the Implementat-Version and use a separate manifest entry to store a full hash. 2) use a longer version for git show (abbrev=num) so that the chance of collisions in the future is minimized. It's still not a full hash

Re: New branch and feature freeze for Lucene/Solr 8.10.0

: I was referring to doing this with languages other than java. : : I'm also assuming that exceeding this limit is going to cause indirect : hassles for users of lucene, e.g. breaking various security / supply : chain tools. We know a lot of these are total crap but people in the : corporate

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Ok, fine. D. On Thu, Sep 16, 2021 at 12:00 PM Robert Muir wrote: > > The shit that mike's python tool is doing, i'd expect bugs like that. > If you honestly disagree with me, go fix his python code to obey "the > rules". Be sure you have "the rules" correct as well (count bytes, not >

Re: New branch and feature freeze for Lucene/Solr 8.10.0

The shit that mike's python tool is doing, i'd expect bugs like that. If you honestly disagree with me, go fix his python code to obey "the rules". Be sure you have "the rules" correct as well (count bytes, not characters, count EOL, etc). Try to imagine how much software is going to get this

Re: New branch and feature freeze for Lucene/Solr 8.10.0

I was referring to doing this with languages other than java. I'm also assuming that exceeding this limit is going to cause indirect hassles for users of lucene, e.g. breaking various security / supply chain tools. We know a lot of these are total crap but people in the corporate world have to

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Jar command doesn't have it, true. But it's fairly trivial to do, even with an inline snippet like this one? public class PrintManifest { public static void main(String[] jars) throws IOException { for (var jar : jars) { var manifest = new

Re: New branch and feature freeze for Lucene/Solr 8.10.0

But its irrelevant that is "valid" when virtually no tools match it. In other words, I'd agree with you if the "jar" command had some ability to read these manifests and print stuff to stdout, e.g. if there was ANY interop at all here. But there isn't. So IMO it makes no sense to cause confusion

Re: New branch and feature freeze for Lucene/Solr 8.10.0

>Can we read the manifest properly on the smoke tester side somehow This would be my option #3? These are apparently going to need different solutions for ant and gradle, so we'll handle them separately. Created https://issues.apache.org/jira/browse/LUCENE-10107 for 8.x and

Re: New branch and feature freeze for Lucene/Solr 8.10.0

This is valid manifest line-breaking though... Can we read the manifest properly on the smoke tester side somehow (for example, run a Java process that reads and extracts the required attribute)? This way we wouldn't care about the implementation details of how manifest wraps the lines (or escapes

Re: New branch and feature freeze for Lucene/Solr 8.10.0

+1 for option #1 Let's control the hash to a reasonable size, so that the version number will "fit" We would hit this same problem with 10.0.0 and then we'd have to revisit it again with 10.10.0, so let's not try to solve it onesy-twosey at this time On Wed, Sep 15, 2021 at 2:46 PM Mike Drob

Re: New branch and feature freeze for Lucene/Solr 8.10.0

The benchmark jar has the info we need… sort of. When I built it, it has: Implementation-Version: 8.10.0 75a5061d3715cc5d93c4cbe4f1fa62bf035eea1 1 - mdrob - 2021-09-15 11:40:36 and it’s looking for Implementation-Version: 8.10.0 75a5061d3715cc5d93c4cbe4f1fa62bf035eea11 on one line. Because

Re: New branch and feature freeze for Lucene/Solr 8.10.0

can someone also please look into that benchmark jar issue? Sent from my iPhone > On Sep 15, 2021, at 9:44 AM, Nhat Nguyen > wrote: > >  > Thanks Mayya and Mike! I will backport it to the 8.10 branch. > >> On Wed, Sep 15, 2021 at 10:12 AM Mike Drob wrote: >> I think since Tim is out on

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Thanks Mayya and Mike! I will backport it to the 8.10 branch. On Wed, Sep 15, 2021 at 10:12 AM Mike Drob wrote: > I think since Tim is out on vacation, it's probably not too late. That > looks like a good fix to have, do we know how long the bug has been present? > > On Wed, Sep 15, 2021 at

Re: New branch and feature freeze for Lucene/Solr 8.10.0

I think since Tim is out on vacation, it's probably not too late. That looks like a good fix to have, do we know how long the bug has been present? On Wed, Sep 15, 2021 at 7:56 AM Mayya Sharipova wrote: > Hello everyone, > We have discovered a bug and fixed a bug in Lucene sort optimization >

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Hello everyone, We have discovered a bug and fixed a bug in Lucene sort optimization (LUCENE-10106) and would like to merge it to Lucene 8.10 if it is not too late. I apologize for the inconvenience, the bug was discovered just yesterday. On Tue, Sep

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Ahem ... unfortunately there will not be an 8.10 RC this week. I'm headed out on vacation tomorrow, back at keys on Monday, Sept 20 unless someone else wants to pick up the RM duties before then? After failing the test suite at various places and other weirdness like .asc files not getting

Re: New branch and feature freeze for Lucene/Solr 8.10.0

All the best, this is the worst step. On Tue, 14 Sep, 2021, 10:47 pm Timothy Potter, wrote: > Building RC1 now ... stay tuned. > > On Thu, Sep 9, 2021 at 2:30 PM Timothy Potter > wrote: > > > > Thanks for the update Mike! > > > > I'm backporting SOLR-15620 right now and am cooking up a quick

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Building RC1 now ... stay tuned. On Thu, Sep 9, 2021 at 2:30 PM Timothy Potter wrote: > > Thanks for the update Mike! > > I'm backporting SOLR-15620 right now and am cooking up a quick PR for > SOLR-15621, which looks like an easy win for the issue Cassandra > reported on Slack earlier today. >

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Thanks for the update Mike! I'm backporting SOLR-15620 right now and am cooking up a quick PR for SOLR-15621, which looks like an easy win for the issue Cassandra reported on Slack earlier today. Cheers, Tim On Thu, Sep 9, 2021 at 11:32 AM Mike Drob wrote: > > Hi Tim, I'm still working on

Re: New branch and feature freeze for Lucene/Solr 8.10.0

Hi Tim, I'm still working on SOLR-1, the code and benchmarking both look pretty good, but I've got a few last unit tests that I need to chase down. Hopefully taken care of by today or tomorrow, I'll be sure to keep you updated though. On Thu, Sep 9, 2021 at 11:39 AM Timothy Potter wrote: >

Re: New branch and feature freeze for Lucene/Solr 8.10.0

I found https://issues.apache.org/jira/browse/SOLR-15620 while testing the schema designer. I haven't built the RC yet, so going to see if I can get this in today. On Tue, Sep 7, 2021 at 12:36 PM Timothy Potter wrote: > > NOTICE: > > Branch branch_8_10 has been cut and versions updated to 8.11

New branch and feature freeze for Lucene/Solr 8.10.0

NOTICE: Branch branch_8_10 has been cut and versions updated to 8.11 on stable branch. Please observe the normal rules: * No new features may be committed to the branch. * Documentation patches, build patches and serious bug fixes may be committed to the branch. However, you should submit