NightOwl888 commented on PR #866:
URL: https://github.com/apache/lucenenet/pull/866#issuecomment-3245961855
>I think that will be fine since our dependencies do not change very
frequently.
"Frequently" is a relative term. We review them every time we release and
often bump versions a
paulirwin merged PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.
paulirwin commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3245261063
Congrats @NehanPathan on this PR and thanks for the feedback cycles!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2313937552
##
src/Lucene.Net.Replicator/Support/Http/Abstractions/IReplicationResponse.cs:
##
@@ -42,5 +44,12 @@ public interface IReplicationResponse
/// Flushes the
paulirwin commented on PR #866:
URL: https://github.com/apache/lucenenet/pull/866#issuecomment-3245707856
@NightOwl888 @nikcio I'm looking into this again, and I found that at least
on the GitHub Actions side, the `setup-dotnet` task [now supports NuGet
caching](https://github.com/actions/s
paulirwin commented on PR #866:
URL: https://github.com/apache/lucenenet/pull/866#issuecomment-3246038823
> "Frequently" is a relative term. We review them every time we release and
often bump versions and add or remove packages several times between releases.
Let's reserve the term "
NehanPathan commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3245339797
@paulirwin @NightOwl888
Thank you so much, for your guidance, trust, and feedback throughout this! I
really appreciate it.😊
--
This is an automated message from the Apach
paulirwin closed issue #1169: Add asynchronous PerformAsync and FlushAsync
methods to IReplicationService and IReplicationResponse
URL: https://github.com/apache/lucenenet/issues/1169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2314734310
##
src/Lucene.Net.Replicator/Support/Http/Abstractions/IReplicationService.cs:
##
@@ -1,4 +1,7 @@
using System;
+using System.Threading;
Review Comment:
here
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2314748496
##
src/Lucene.Net.Replicator/Http/ReplicationService.cs:
##
@@ -118,75 +121,151 @@ private static string
ExtractRequestParam(IReplicationRequest request, string
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2314734310
##
src/Lucene.Net.Replicator/Support/Http/Abstractions/IReplicationService.cs:
##
@@ -1,4 +1,7 @@
using System;
+using System.Threading;
Review Comment:
We n
paulirwin commented on PR #1066:
URL: https://github.com/apache/lucenenet/pull/1066#issuecomment-3243188025
This old PR has been rebased against latest main. I intend to merge this
this coming weekend if there is no further feedback.
--
This is an automated message from the Apache Git Ser
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2314476075
##
src/Lucene.Net.Replicator/Http/ReplicationService.cs:
##
@@ -118,75 +121,151 @@ private static string
ExtractRequestParam(IReplicationRequest request, string
NehanPathan commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3242617488
just a quick note — I accidentally pulled in apache:master while trying to
update my branch (git pull --rebase origin async-replication). That created an
unintended merge commit (54
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2312334781
##
src/Lucene.Net.Replicator/Support/Http/Abstractions/IReplicationResponse.cs:
##
@@ -42,5 +44,12 @@ public interface IReplicationResponse
/// Flushes t
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2312316721
##
src/Lucene.Net.Tests.Replicator/Http/ReplicationServlet.cs:
##
@@ -52,14 +52,16 @@ public void Configure(IApplicationBuilder app,
IReplicationService service,
NehanPathan commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3239469777
> Minor feedback added about some comments in the code. @NehanPathan I'm
open to approving this without the J2N-ported unit tests if you want to do that
in a follow-up PR, or let me
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2312058977
##
src/Lucene.Net.Tests.Replicator/Http/ReplicationServlet.cs:
##
@@ -84,14 +86,15 @@ public async Task InvokeAsync(HttpContext context)
{
//
NightOwl888 commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3239372253
> > so I am attempting to unify the configuration a bit more between older
and newer versions of ASP.NET Core.
>
> Versions older than ASP.NET Core 8 are [out of
support](htt
paulirwin commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3239310603
> so I am attempting to unify the configuration a bit more between older and
newer versions of ASP.NET Core.
Versions older than ASP.NET Core 8 are [out of
support](https://dot
NightOwl888 commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3239283073
> @NightOwl888
>
> Thanks — that makes sense.
>
> Your approach sounds clean and avoids too much duplication. I’m happy to
try setting that up now, unless you’d prefer
NehanPathan commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3239239323
> Thanks. Removing `Perform()` wasn't intentional. And thanks for adding the
tests.
>
> Although, I realized that by switching our tests to using async only, we
are no longer
NightOwl888 commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3238093592
> @NightOwl888
>
> just a quick update — I had to **force push** this branch.
>
> Reason: in last commit I guess you removed the `Perform()` method from
`ReplicationSer
NehanPathan commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3237925206
@NightOwl888
just a quick update — I had to **force push** this branch.
Reason: in last commit I guess you removed the `Perform()` method from
`ReplicationServlet` en
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2310692667
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +214,177 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2310687513
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2310665133
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2310072090
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2310072090
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2310072090
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2310072090
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2309095676
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2309098326
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2309068561
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2308954835
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2308904983
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2308867982
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307958344
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307916129
##
src/Lucene.Net.Replicator/Http/ReplicationService.cs:
##
@@ -118,75 +121,128 @@ private static string
ExtractRequestParam(IReplicationRequest request, string
NightOwl888 commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233676532
> This is currently mostly blocking our GSoC work from wrapping up, so I'd
prefer to accept the allocations for now and do a fast-follow item for the
pipelines. Assuming that it won
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307958344
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307955229
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307920361
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307891036
##
src/Lucene.Net.Replicator/Http/ReplicationService.cs:
##
@@ -118,75 +121,128 @@ private static string
ExtractRequestParam(IReplicationRequest request, string
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307874849
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
NightOwl888 commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233823824
> Alternatively, we could make the serialize methods internal and go ahead
and accept a breaking change that they're not supposed to be part of our public
API? It seems to me like t
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2307572673
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
paulirwin commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233700545
Alternatively, we could make the serialize methods internal and go ahead and
accept a breaking change that they're not supposed to be part of our public
API? It seems to me like this
paulirwin commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233690226
> It changes the API contract on `SessionToken`
Thanks, good to know. Once we get there, we could decide whether just adding
an overload is warranted, leaving the Stream version
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2306092350
##
src/Lucene.Net/Support/IO/StreamExtensions.cs:
##
@@ -210,5 +213,154 @@ public static long ReadInt64(this Stream stream)
buff[6]
paulirwin commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233651724
> @paulirwin - Thoughts on using `System.IO.Pipelines` if we can get the
bugs worked out? For the time being we can add the package reference to
`Lucene.Net.Replicator`, but if this e
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2305135956
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2305135956
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2304919146
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2303279153
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2303279153
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2303279153
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin opened a new pull request, #1171:
URL: https://github.com/apache/lucenenet/pull/1171
- [X] You've read the [Contributor
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [X] Yo
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301531579
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301766766
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301659869
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301614067
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301609675
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301608692
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301579242
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301552944
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301542439
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301531579
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301527127
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301508123
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin commented on PR #1060:
URL: https://github.com/apache/lucenenet/pull/1060#issuecomment-3224320396
Good points and analysis. How about we leave it as-is, and put comments on
the string parameters to indicate that they are not normalized by this code?
Then if we get any feedback abo
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2301157290
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
NightOwl888 commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2300989671
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2300917256
##
src/dotnet/Lucene.Net.Replicator.AspNetCore/AspNetCoreReplicationResponse.cs:
##
@@ -68,5 +70,21 @@ public void Flush()
{
response.Body.Flu
NehanPathan commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2300908188
##
src/dotnet/Lucene.Net.Replicator.AspNetCore/AspNetCoreReplicationResponse.cs:
##
@@ -68,5 +70,21 @@ public void Flush()
{
response.Body.F
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2300883807
##
src/Lucene.Net.Replicator/SessionToken.cs:
##
@@ -112,6 +114,33 @@ public void Serialize(DataOutputStream writer)
}
}
+///
+
paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2300870470
##
src/dotnet/Lucene.Net.Replicator.AspNetCore/AspNetCoreReplicationResponse.cs:
##
@@ -68,5 +70,21 @@ public void Flush()
{
response.Body.Flu
paulirwin closed issue #1157: MultiFieldQueryParser set boosts parameter does
not works
URL: https://github.com/apache/lucenenet/issues/1157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
paulirwin merged PR #1167:
URL: https://github.com/apache/lucenenet/pull/1167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.
NightOwl888 commented on issue #1168:
URL: https://github.com/apache/lucenenet/issues/1168#issuecomment-3223628830
Note that since will be an ongoing cleanup task when porting from Java and
because it is difficult to find these instances using text search alone, it
would be ideal to make th
NehanPathan opened a new pull request, #1170:
URL: https://github.com/apache/lucenenet/pull/1170
---
* @paulirwin for review.
**Linked Issue:**
Fixes #1169
**Description:**
This PR implements asynchronous support for the replication framework in
Lucene.NET, based o
NehanPathan opened a new issue, #1169:
URL: https://github.com/apache/lucenenet/issues/1169
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Is your feature request related to a problem? Please describe the
problem.
Currently, IRepli
NightOwl888 opened a new issue, #1168:
URL: https://github.com/apache/lucenenet/issues/1168
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Task description
We need to ensure that most of our `Dictionary` usages
retrieve values usin
paulirwin commented on code in PR #1167:
URL: https://github.com/apache/lucenenet/pull/1167#discussion_r2299682264
##
src/Lucene.Net.Tests.QueryParser/Classic/TestMultiFieldQueryParser.cs:
##
@@ -385,5 +386,164 @@ public virtual void TestSimpleRegex()
bq.Add(new Reg
paulirwin commented on code in PR #1167:
URL: https://github.com/apache/lucenenet/pull/1167#discussion_r2299681551
##
src/Lucene.Net.Tests.QueryParser/Classic/TestMultiFieldQueryParser.cs:
##
@@ -385,5 +386,164 @@ public virtual void TestSimpleRegex()
bq.Add(new Reg
paulirwin commented on code in PR #1167:
URL: https://github.com/apache/lucenenet/pull/1167#discussion_r2299679553
##
src/Lucene.Net.Tests.QueryParser/Classic/TestMultiFieldQueryParser.cs:
##
@@ -385,5 +386,164 @@ public virtual void TestSimpleRegex()
bq.Add(new Reg
Copilot commented on code in PR #1167:
URL: https://github.com/apache/lucenenet/pull/1167#discussion_r2299677893
##
src/Lucene.Net.Tests.QueryParser/Classic/TestMultiFieldQueryParser.cs:
##
@@ -385,5 +386,164 @@ public virtual void TestSimpleRegex()
bq.Add(new Regex
paulirwin opened a new pull request, #1167:
URL: https://github.com/apache/lucenenet/pull/1167
- [X] You've read the [Contributor
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [X] Yo
paulirwin commented on issue #1157:
URL: https://github.com/apache/lucenenet/issues/1157#issuecomment-3222469446
@ldqk After an investigation and testing, the MultiFieldQueryParser boost
functionality seems to be working correctly in both 4.8.0-beta00017 and latest
master.
I created
paulirwin commented on PR #1060:
URL: https://github.com/apache/lucenenet/pull/1060#issuecomment-3222411253
Review from Claude Code:
## Pull Request Review: Issue #832 - Avoid Unnecessary
FileInfo/DirectoryInfo Allocations
### **Summary**
This PR optimizes file system operat
paulirwin closed issue #1024: Convert UTF8toUTF16 to TryUTF8toUTF16
URL: https://github.com/apache/lucenenet/issues/1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
paulirwin merged PR #1057:
URL: https://github.com/apache/lucenenet/pull/1057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.
NightOwl888 merged PR #1166:
URL: https://github.com/apache/lucenenet/pull/1166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenene
Copilot commented on code in PR #1060:
URL: https://github.com/apache/lucenenet/pull/1060#discussion_r228689
##
src/Lucene.Net/Store/SimpleFSLockFactory.cs:
##
@@ -134,16 +134,16 @@ public override bool Obtain()
// LUCENENET: Since WriteAllText doesn't care if t
paulirwin commented on code in PR #1057:
URL: https://github.com/apache/lucenenet/pull/1057#discussion_r2286867042
##
src/Lucene.Net/Support/ObsoleteAPI/UnicodeUtil.cs:
##
@@ -0,0 +1,175 @@
+using Lucene.Net.Support;
+using System;
+
+#nullable enable
+
+namespace Lucene.Net.Uti
paulirwin commented on code in PR #1057:
URL: https://github.com/apache/lucenenet/pull/1057#discussion_r2286871151
##
src/Lucene.Net/Util/UnicodeUtil.cs:
##
@@ -825,86 +801,41 @@ public static void UTF8toUTF32(BytesRef utf8, Int32sRef
utf32)
///
/// Value t
Copilot commented on code in PR #1057:
URL: https://github.com/apache/lucenenet/pull/1057#discussion_r2286865556
##
src/Lucene.Net/Util/UnicodeUtil.cs:
##
@@ -825,86 +801,41 @@ public static void UTF8toUTF32(BytesRef utf8, Int32sRef
utf32)
///
/// Value tha
paulirwin commented on code in PR #1154:
URL: https://github.com/apache/lucenenet/pull/1154#discussion_r2286859700
##
src/Lucene.Net.Analysis.SmartCn/Hhmm/BigramDictionary.cs:
##
@@ -286,37 +303,37 @@ public virtual void LoadFromFile(string dctFilePath)
int j =
paulirwin opened a new pull request, #1166:
URL: https://github.com/apache/lucenenet/pull/1166
- [X] You've read the [Contributor
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [ ] Yo
paulirwin merged PR #1164:
URL: https://github.com/apache/lucenenet/pull/1164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.
1 - 100 of 1809 matches
Mail list logo
