Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-17 20:50:42.776447) Review request for mahout, Ted Dunning, lan

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-17 20:46:39.068863) Review request for mahout, Ted Dunning, lan

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-17 20:38:27.774380) Review request for mahout, Ted Dunning, lan

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-17 20:32:34.158332) Review request for mahout, Ted Dunning, lan

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/#review3916 --- Looks much better from the trivial formatting standpoint. - Ted On

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-13 17:53:35.691333) Review request for mahout, lancenorskog and

Re: Review Request: Row mean job for PCA

> On 2011-12-13 13:08:20, Ted Dunning wrote: > > /trunk/core/src/main/java/org/apache/mahout/math/hadoop/DistributedRowMatrix.java, > > line 199 > > > > > > I would really rather use standard terminology here. > > >

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/#review3874 --- /trunk/core/src/main/java/org/apache/mahout/math/hadoop/DistributedRo

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-13 04:46:47.630950) Review request for mahout, lancenorskog and

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-13 00:58:36.591798) Review request for mahout and Dmitriy Lyubi

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/#review3866 --- /trunk/core/src/main/java/org/apache/mahout/math/hadoop/MatrixRowMean

Re: Review Request: Row mean job for PCA

> On 2011-12-12 02:10:01, Dmitriy Lyubimov wrote: > > Hm. I hope i did not read the code or miss something. > > > > 1 -- i am not sure this will actually work as intended unless # of reducers > > is corced to 1, of which i see no mention in the code. > > 2 -- mappers do nothing, passing on al

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-13 00:10:57.848590) Review request for mahout and Dmitriy Lyubi

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-13 00:09:03.441301) Review request for mahout. Changes --

Re: Review Request: Row mean job for PCA

> On 2011-12-12 02:10:01, Dmitriy Lyubimov wrote: > > Hm. I hope i did not read the code or miss something. > > > > 1 -- i am not sure this will actually work as intended unless # of reducers > > is corced to 1, of which i see no mention in the code. > > 2 -- mappers do nothing, passing on al

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-12 10:41:46.013180) Review request for mahout. Summary --

Re: Review Request: Row mean job for PCA

Thanks Lance. That makes a lot of sense. You're right regarding the need for combiners. What's the best way to create an Int + Vector writable pair? Should I just define one from scratch or is there some framework already in Mahout I should reuse? Thanks again! On Dec 11, 2011, at 11:59 PM, L

Re: Review Request: Row mean job for PCA

There is NullWritable as the key between mapper and reducer, and as the first value in the pairs saved in a SequenceFile. As the mapper->reducer key, it works. In mahout, SequenceFile vectors and matrices are stored as pairs. Even though this job is in the middle of another job, it should follow

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/#review3838 --- Hm. I hope i did not read the code or miss something. 1 -- i am not

Re: Review Request: Row mean job for PCA

> On 2011-12-12 02:10:01, Dmitriy Lyubimov wrote: > > Hm. I hope i did not read the code or miss something. > > > > 1 -- i am not sure this will actually work as intended unless # of reducers > > is corced to 1, of which i see no mention in the code. > > 2 -- mappers do nothing, passing on al

Re: Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- (Updated 2011-12-12 00:30:24.091994) Review request for mahout. Summary --

Review Request: Row mean job for PCA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/ --- Review request for mahout. Summary --- Here's a patch with a simple job to