Re: MR for daemon gRPC code

2020-05-20 Thread Bruno Sette
Hello everyone. LGTM Lucas, +1 Em dom, 17 de mai de 2020 18:39, Zhang Yifei escreveu: > Hello Lucas, > > Lgtm. > > Em sex., 15 de mai. de 2020 às 11:09, Lucas Cardoso Silva < > cardosolucas61@gmail.com> escreveu: > > > Hello everyone. I created this topic to discuss how we will MR the gRPC

Re: MR for daemon gRPC code

2020-05-17 Thread Zhang Yifei
Hello Lucas, Lgtm. Em sex., 15 de mai. de 2020 às 11:09, Lucas Cardoso Silva < cardosolucas61@gmail.com> escreveu: > Hello everyone. I created this topic to discuss how we will MR the gRPC > daemon code and the new architecture approach. I thought about creating an > issue and a new branch f

Re: Daemon gRPC

2020-05-15 Thread Lucas Cardoso Silva
Thanks. I made a topic to discuss how I can proceed with the MR. I agree with the error type too, will include in proto code. Best regards, Em qui., 14 de mai. de 2020 às 15:14, Lucas Bonatto Miguel < lucasb...@apache.org> escreveu: > That's a good initiative. > > I agree that we must make auth

MR for daemon gRPC code

2020-05-15 Thread Lucas Cardoso Silva
Hello everyone. I created this topic to discuss how we will MR the gRPC daemon code and the new architecture approach. I thought about creating an issue and a new branch for this, since there are many changes in the code and we are not sure if they will be put in the standard development repository

Re: Daemon gRPC

2020-05-14 Thread Lucas Bonatto Miguel
That's a good initiative. I agree that we must make auth optional, and IMO it should be something that comes in a later stage. Maybe you just make sure your interface would be able to receive an authentication implementation in the future, but I don't think that is something that needs to be imple

Re: Daemon gRPC

2020-05-08 Thread Lucas Cardoso Silva
I believe that we must keep both options. For develop in a controlled environment, the insecure server option is easier. But gRPC has several authentication methods. The best and easiest to implement, in my opinion, is SSL / TLS. The user can generate his own keys and pass it to the modules to esta

Re: Daemon gRPC

2020-05-07 Thread Wei Chen
One question, should we include authentication information into the proto spec? On Fri, May 8, 2020 at 10:35 AM Lucas Cardoso Silva < cardosolucas61@gmail.com> wrote: > I did a grpc implementation for the daemon, as discussed earlier. I would > like to know your opinion about this code. To co

Daemon gRPC

2020-05-07 Thread Lucas Cardoso Silva
I did a grpc implementation for the daemon, as discussed earlier. I would like to know your opinion about this code. To complete the changes, only a user interface module would be missing, which I can do until the beginning of next week. All unit tests have also been adapted and the daemon has a co