Re: [VOTE] Release Maven JXR version 2.2 (take 2)

2010-06-03 Thread Lukas Theussl
+1 -Lukas Dennis Lundberg wrote: Hi, We solved 12 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11085&version=13392 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11085&status=1 Staging repo: https://

[RESULT] [VOTE] Release Maven Site Plugin version 2.1.1

2010-06-03 Thread Dennis Lundberg
Hi, The vote has passed with the following result : +1 (binding): Lukas Theussl, Hervé Boutemy, Benjamin Bentmann, Olivier Lamy, Arnaud Héritier, Dennis Lundberg +1 (non binding): Nicolas de Loof, Tony Chemit I will promote the artifacts to the central repo. Thanks to everyone who helped with th

Re: [VOTE] Release Maven Site Plugin version 2.1.1

2010-06-03 Thread Dennis Lundberg
+1 from me On 2010-05-31 23:33, Dennis Lundberg wrote: > Hi, > > We solved 7-8 issues (I'm not sure if MSITE-440 is resolved or not): > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11146&version=15923 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/s

[jira] Subscription: Design & Best Practices

2010-06-03 Thread jira
Issue Subscription Filter: Design & Best Practices (23 issues) Subscriber: mavendevlist Key Summary MNG-2184Possible problem with @aggregator and forked lifecycles http://jira.codehaus.org/browse/MNG-2184 MNG-612 implement conflict resolution techniques

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Kristian Rosenvold
Before having looked at the source code in question, I could only recommend plexus-utils 2.0.5 (on a general basis), because all of the executeCommandLine methods are deadlock prone prior to that version. I find it quite hard to evaluate if any of the transitive dependencies included in the plugi

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Daniel Kulp
On Thursday 03 June 2010 12:54:07 pm John Casey wrote: > Ah. The package name has changed, but the APIs are the same. So the > imports for the interpolation stuff just need to be adjusted, once the > plexus-interpolation dep is added. Right. But nothing in checkstyle plugin imports anything from

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread John Casey
Ah. The package name has changed, but the APIs are the same. So the imports for the interpolation stuff just need to be adjusted, once the plexus-interpolation dep is added. On 6/3/10 12:50 PM, Daniel Kulp wrote: On Thursday 03 June 2010 12:38:43 pm John Casey wrote: It needs a dependency add

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Daniel Kulp
On Thursday 03 June 2010 12:38:43 pm John Casey wrote: > It needs a dependency added on plexus-interpolation, since the > interpolation stuff was taken out of plexus-utils and migrated there. Didn't help. The stuff in plexus-interpolation has the ValueSource stuff in a different package. Thus

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread Olivier Lamy
Hi, Try with adding the following dependency : org.codehaus.plexus:plexus-interpolation:1.9. 2010/6/3 Daniel Kulp : > > I've been working on getting the CXF builds to at least build (not run the > tests yet) with the Maven 3 // mode.    With the updates to the checkstyle > plugin, I've now done ab

Re: PMD/Checkstyle and threadSafe....

2010-06-03 Thread John Casey
It needs a dependency added on plexus-interpolation, since the interpolation stuff was taken out of plexus-utils and migrated there. On 6/3/10 12:02 PM, Daniel Kulp wrote: I've been working on getting the CXF builds to at least build (not run the tests yet) with the Maven 3 // mode.With th

PMD/Checkstyle and threadSafe....

2010-06-03 Thread Daniel Kulp
I've been working on getting the CXF builds to at least build (not run the tests yet) with the Maven 3 // mode.With the updates to the checkstyle plugin, I've now done about a dozen or so builds with various -T settings without any failures.I'm not quite ready to declare an @threadSafe

Re: DefaultPluginManager.executeMojo not supported with Maven 3?

2010-06-03 Thread Jason van Zyl
No, there's no guarantee the old API will work in Maven 3.x. The compatibility we are striving to maintain is at the CLI level from the user's perspective. Maven 3.x is a massive change internally so we've tried to remain compatible where can, and in most cases we have, but the plugin manager ha

Re: svn commit: r950989 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java

2010-06-03 Thread nicolas de loof
+1 to remove this "feature". A module is expected to build either with it's parent POM in parent directory or by donwloading it from repo, so relying on such * search-in-parent-folder* feature is a bad practice. Nicolas 2010/6/3 Olivier Lamy > Hi, > We are two who don't like this hack :-) > So

Re: svn commit: r950989 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java

2010-06-03 Thread Benjamin Bentmann
Olivier Lamy wrote: We are two who don't like this hack :-) So what's about don't support this ? +1, sharing of resources between modules should happen via a resource bundle that can be put onto the plugin's class path. Benjamin

Re: svn commit: r950747 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java

2010-06-03 Thread Daniel Kulp
I committed a "fix" for this, but it really is a complete hack. The basic issue is that MCHECKSTYLE-131 really is a BAD BAD idea and in my opinion and should not be supported. The basic issue of MCHECKSTYLE-131 is that it allows the plugin to traverse up the parent modules (actually, with

Re: svn commit: r950989 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java

2010-06-03 Thread Olivier Lamy
Hi, We are two who don't like this hack :-) So what's about don't support this ? Others ? 2010/6/3 : > Author: dkulp > Date: Thu Jun  3 13:28:57 2010 > New Revision: 950989 > > URL: http://svn.apache.org/viewvc?rev=950989&view=rev > Log: > Fix the checkstyle it tests. > This is really a complete

Re: svn commit: r950747 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java

2010-06-03 Thread Benjamin Bentmann
Hi Dan, Author: dkulp Date: Wed Jun 2 20:23:49 2010 New Revision: 950747 URL: http://svn.apache.org/viewvc?rev=950747&view=rev Log: Since the DefaultCheckstyleExecutor contains an object (ResourceManager) that holds onto state and must be per-lookup, the DefaultCheckstyleExecutor must also be

Re: [VOTE] Release Maven Site Plugin version 2.1.1

2010-06-03 Thread nicolas de loof
+1 Le 3 juin 2010 10:52, Arnaud Héritier a écrit : > +1 > > Arnaud Héritier > eXo - Software Factory Manager > > > > On Jun 3, 2010, at 9:59 AM, Olivier Lamy wrote: > > > +1 > > > > 2010/5/31 Dennis Lundberg : > >> Hi, > >> > >> We solved 7-8 issues (I'm not sure if MSITE-440 is resolved or not)

Re: [VOTE] Release Maven Site Plugin version 2.1.1

2010-06-03 Thread Arnaud Héritier
+1 Arnaud Héritier eXo - Software Factory Manager On Jun 3, 2010, at 9:59 AM, Olivier Lamy wrote: > +1 > > 2010/5/31 Dennis Lundberg : >> Hi, >> >> We solved 7-8 issues (I'm not sure if MSITE-440 is resolved or not): >> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11146&version

Re: [VOTE] Release Maven Site Plugin version 2.1.1

2010-06-03 Thread Olivier Lamy
+1 2010/5/31 Dennis Lundberg : > Hi, > > We solved 7-8 issues (I'm not sure if MSITE-440 is resolved or not): > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11146&version=15923 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/secure/IssueNavigator.jspa?

Re: DefaultPluginManager.executeMojo not supported with Maven 3?

2010-06-03 Thread Jamie Townsend
So if we're happy to not use Maven 3 until the 3.0 release, the old API will be working again? -- Jamie > No, you'll have to adjust to the new API. We are striving to be compatible > from > the CLI perspective. We'll have a new method published for the 3.0 release. > > On Jun 2, 2010, at 8:21