Re: [VOTE] Release Maven Invoker Plugin version 1.8

2012-11-24 Thread Maria Odea Ching-Mallete
+1 Thanks, Deng On Sat, Nov 24, 2012 at 2:04 AM, Robert Scholte wrote: > Hi, > > We solved 14 issues: > http://jira.codehaus.org/**secure/ReleaseNote.jspa?** > projectId=11441&styleName=**Html&version=18730

Re: [VOTE] Release Maven Invoker Plugin version 1.8

2012-11-24 Thread Hervé BOUTEMY
+1 Regards, Hervé Le vendredi 23 novembre 2012 19:04:07 Robert Scholte a écrit : > Hi, > > We solved 14 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11441&styleName=H > tml&version=18730 > > There are no more open bugs, but still a couple of issues left in JIRA: > http:

Re: Changing MavenProjectHelper

2012-11-24 Thread Hervé BOUTEMY
Since this is a plexus component implemented in Maven core [1], I don't see any problem with adding a new Method: if the method exists in interface, it exists in implementation. We would have a problem if it was an interface that is expected to be implemented by external code So I don't see any

adding/replacing attached artifacts

2012-11-24 Thread Benson Margulies
Please consider http://jira.codehaus.org/browse/MNG-4013 and then http://jira.codehaus.org/browse/MNG-3119 My plan under https://jira.codehaus.org/browse/MNG-5387 is to close 3119 as invalid; there's a legitimate use case for adding 'duplicates' and shade should use it. However, the fix for 40

Re: getting the core into eclipse or idea

2012-11-24 Thread Benson Margulies
Igor, I had a broken tree. Faux alarm all around. On Sat, Nov 24, 2012 at 5:53 PM, Igor Fedorenko wrote: > What's the problem with Eclipse exactly? I just imported current trunk > in fresh/new m2e workspace without any problems. > > -- > Regards, > Igor > > > On 12-11-24 5:38 PM, Benson Margulie

Re: getting the core into eclipse or idea

2012-11-24 Thread Igor Fedorenko
What's the problem with Eclipse exactly? I just imported current trunk in fresh/new m2e workspace without any problems. -- Regards, Igor On 12-11-24 5:38 PM, Benson Margulies wrote: When i import the trunk into intellij, the plexus annotations are missing. And eclipse is not too clever with the

Re: getting the core into eclipse or idea

2012-11-24 Thread Benson Margulies
Olivier, I added the the core as a module, not telling it about the pom, since my initial attempt to run 'mvn' (with the broken tree) had failed. I'm sure IntelliJ like M2E will work fine with a non-broken tree. On Sat, Nov 24, 2012 at 5:48 PM, Olivier Lamy wrote: > I use intellij and don't hav

Re: getting the core into eclipse or idea

2012-11-24 Thread Olivier Lamy
I use intellij and don't have any issue. More details ? -- Olivier Le 24 nov. 2012 23:38, "Benson Margulies" a écrit : > When i import the trunk into intellij, the plexus annotations are > missing. And eclipse is not too clever with the build.xml. I could > write up a page armed with some hints.

Re: getting the core into eclipse or idea

2012-11-24 Thread Benson Margulies
For some stupid reason I didn't think of that. On Sat, Nov 24, 2012 at 5:44 PM, Anders Hammar wrote: > Not sure I follow. I work on core just fine in Eclipse with m2e. No need > for it to understand build.xml, it uses the pom. > > /Anders > > > On Sat, Nov 24, 2012 at 11:38 PM, Benson Margulies

Re: [VOTE] Release Maven Invoker Plugin version 1.8

2012-11-24 Thread Olivier Lamy
+1 -- Olivier Le 23 nov. 2012 19:04, "Robert Scholte" a écrit : > Hi, > > We solved 14 issues: > http://jira.codehaus.org/**secure/ReleaseNote.jspa?** > projectId=11441&styleName=**Html&version=18730 >

Re: getting the core into eclipse or idea

2012-11-24 Thread Anders Hammar
Not sure I follow. I work on core just fine in Eclipse with m2e. No need for it to understand build.xml, it uses the pom. /Anders On Sat, Nov 24, 2012 at 11:38 PM, Benson Margulies wrote: > When i import the trunk into intellij, the plexus annotations are > missing. And eclipse is not too cleve

getting the core into eclipse or idea

2012-11-24 Thread Benson Margulies
When i import the trunk into intellij, the plexus annotations are missing. And eclipse is not too clever with the build.xml. I could write up a page armed with some hints. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

Re: Maven 3.1.0 update

2012-11-24 Thread Olivier Lamy
2012/11/24 Jason van Zyl : > > On Nov 24, 2012, at 1:47 PM, Olivier Lamy wrote: > >> oups fixed for the profile activation. >> >> "better" with: "Tests run: 714, Failures: 34, Errors: 3, Skipped: 0" >> >> The build is configured to build core to $WORKSPACE/apache-maven-3.0-SNAPSHOT >> then core it

Re: Changing MavenProjectHelper

2012-11-24 Thread Jason van Zyl
Please do not change existing signatures. If it's public, you simply never know who's using it. On Nov 24, 2012, at 2:00 PM, Benson Margulies wrote: > I am inclined to also fix a missing exception from one of the existing > methods; comments indicate that someone avoided adding it due to > comp

Re: Changing MavenProjectHelper

2012-11-24 Thread Benson Margulies
I am inclined to also fix a missing exception from one of the existing methods; comments indicate that someone avoided adding it due to compat issues at the time. On Sat, Nov 24, 2012 at 4:58 PM, Olivier Lamy wrote: > 2012/11/24 Benson Margulies : >> MavenProjectHelper lives in the core, and I'd

Re: Maven 3.1.0 update

2012-11-24 Thread Jason van Zyl
On Nov 24, 2012, at 1:47 PM, Olivier Lamy wrote: > oups fixed for the profile activation. > > "better" with: "Tests run: 714, Failures: 34, Errors: 3, Skipped: 0" > > The build is configured to build core to $WORKSPACE/apache-maven-3.0-SNAPSHOT > then core its run with -Dmaven.home=$WORKSPACE/

Re: Changing MavenProjectHelper

2012-11-24 Thread Olivier Lamy
2012/11/24 Benson Margulies : > MavenProjectHelper lives in the core, and I'd like to add another > method. What's the procedure from a compatibility standpoint? Do I > define a MavenProjectHelper2 that inherits from it so that existing > plugins can continue to have refs to the current interface?

Re: Maven 3.1.0 update

2012-11-24 Thread Jason van Zyl
Running from the command it's probably not the end of the world. But I always run this to make sure long-lived processes work and it generally finds any nasty stuff hiding because using the same Maven instance over and over doesn't last very long with anything leaking badly. Igor and I are getti

Re: Maven 3.1.0 update

2012-11-24 Thread Olivier Lamy
oups fixed for the profile activation. "better" with: "Tests run: 714, Failures: 34, Errors: 3, Skipped: 0" The build is configured to build core to $WORKSPACE/apache-maven-3.0-SNAPSHOT then core its run with -Dmaven.home=$WORKSPACE/apache-maven-3.0-SNAPSHOT 2012/11/24 Jason van Zyl : > > On No

Re: Maven 3.1.0 update

2012-11-24 Thread Jason van Zyl
On Nov 24, 2012, at 1:02 PM, Olivier Lamy wrote: > 2012/11/24 Jason van Zyl : >> Most things are ready release-wise but I found a rather nasty performance >> regression. Seems to be two contributing factors: differing versions of >> Wagon seem to contribute to a large slow down and there appea

Re: [VOTE] Release Maven Invoker Plugin version 1.8

2012-11-24 Thread Anders Hammar
+1 (non-binding) /Anders On Sat, Nov 24, 2012 at 10:13 PM, Mirko Friedenhagen < mfriedenha...@gmail.com> wrote: > +1 (non-binding) tested with two personal projects and the trunk of > the extra-enforcer-rules from codehaus. > > Regards Mirko > > On Fri, Nov 23, 2012 at 7:04 PM, Robert Scholte

Re: Maven 3.1.0 update

2012-11-24 Thread Jason van Zyl
On Nov 24, 2012, at 1:02 PM, Olivier Lamy wrote: > 2012/11/24 Jason van Zyl : >> Most things are ready release-wise but I found a rather nasty performance >> regression. Seems to be two contributing factors: differing versions of >> Wagon seem to contribute to a large slow down and there appea

Re: [VOTE] Release Maven Invoker Plugin version 1.8

2012-11-24 Thread Mirko Friedenhagen
+1 (non-binding) tested with two personal projects and the trunk of the extra-enforcer-rules from codehaus. Regards Mirko On Fri, Nov 23, 2012 at 7:04 PM, Robert Scholte wrote: > Hi, > > We solved 14 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11441&styleName=Html&versio

Re: Maven 3.1.0 update

2012-11-24 Thread Olivier Lamy
2012/11/24 Jason van Zyl : > Most things are ready release-wise but I found a rather nasty performance > regression. Seems to be two contributing factors: differing versions of Wagon > seem to contribute to a large slow down and there appears to be some massive > classloader leakage which is pro

Changing MavenProjectHelper

2012-11-24 Thread Benson Margulies
MavenProjectHelper lives in the core, and I'd like to add another method. What's the procedure from a compatibility standpoint? Do I define a MavenProjectHelper2 that inherits from it so that existing plugins can continue to have refs to the current interface? -

Re: [VOTE] Release Maven Invoker Plugin version 1.8

2012-11-24 Thread Robert Scholte
My own +1 Op Sat, 24 Nov 2012 14:13:57 +0100 schreef Tony Chemit : On Fri, 23 Nov 2012 19:04:07 +0100 "Robert Scholte" wrote: +1 (nb) works fine to me thanks, tony. Hi, We solved 14 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11441&styleName=Html&version=18730

Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Stephen Connolly
Well if we need to get a supporting change into core, and this feature only works on newer versions of maven, falling back to the old way. I think we can live with that. If anything it would be a driver for people to upgrade ;-) On Saturday, 24 November 2012, Benson Margulies wrote: > I'm having

Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Benson Margulies
I'm having a bit of a pause figuring out how to implement Stephen's idea. The crux here is to tell the reactor that the official output of shade should function in the reactor as the primary result artifact of the current project, *without* overwriting the usual file name. Since the jar plugin wil

Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Benson Margulies
I'm having a bit of a pause figuring out how to implement Stephen's idea. The crux here is to tell the reactor that the official output of shade should function in the reactor as the primary result artifact of the current project, *without* overwriting the usual file name. My initial thought is t

Maven 3.1.0 update

2012-11-24 Thread Jason van Zyl
Most things are ready release-wise but I found a rather nasty performance regression. Seems to be two contributing factors: differing versions of Wagon seem to contribute to a large slow down and there appears to be some massive classloader leakage which is probably something I did recently. Run

Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Jochen Wiedmann
In that case, it's got to be 3.0, IMO. On Fri, Nov 23, 2012 at 11:06 PM, Benson Margulies wrote: > On Fri, Nov 23, 2012 at 4:57 PM, Jochen Wiedmann > wrote: > > This would be an incompatible change, would it? > > Yes, indeed, insofar as anyone who scripted to expect the shaded > version to be

Re: [VOTE] Release Maven Invoker Plugin version 1.8

2012-11-24 Thread Tony Chemit
On Fri, 23 Nov 2012 19:04:07 +0100 "Robert Scholte" wrote: +1 (nb) works fine to me thanks, tony. > Hi, > > We solved 14 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11441&styleName=Html&version=18730 > > There are no more open bugs, but still a couple of issues left