Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Hervé BOUTEMY
Le lundi 13 juin 2016 00:21:34 Michael Osipov a écrit : > Am 2016-06-12 um 23:55 schrieb Hervé BOUTEMY: > > Le dimanche 12 juin 2016 22:51:36 Michael Osipov a écrit : > >> Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: > >>> if someone has an objection, just tell and we can easily revert > >> > >>

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
Am 2016-06-12 um 23:55 schrieb Hervé BOUTEMY: Le dimanche 12 juin 2016 22:51:36 Michael Osipov a écrit : Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: if someone has an objection, just tell and we can easily revert I am afraid that I have to downvote this for two reasons: the issues you're f

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
Am 2016-06-12 um 23:55 schrieb Hervé BOUTEMY: Le dimanche 12 juin 2016 22:51:36 Michael Osipov a écrit : Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: if someone has an objection, just tell and we can easily revert I am afraid that I have to downvote this for two reasons: the issues you're f

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
Am 2016-06-12 um 23:36 schrieb Robert Scholte: If #2 is fixed, then #1 is not really an issue. But yes, is should be documented. I assume that it should be easy to wrap the AnsiConsole statements with a try/catch for java.lang.UnsatisfiedLinkError but what will the output do? mangled with unread

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Hervé BOUTEMY
Le dimanche 12 juin 2016 22:51:36 Michael Osipov a écrit : > Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: > > if someone has an objection, just tell and we can easily revert > > I am afraid that I have to downvote this for two reasons: the issues you're facing do not seem to be tied to Gossip slf

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Robert Scholte
If #2 is fixed, then #1 is not really an issue. But yes, is should be documented. I assume that it should be easy to wrap the AnsiConsole statements with a try/catch for java.lang.UnsatisfiedLinkError but what will the output do? mangled with unreadable characters? Robert On Sun, 12 Jun

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: if someone has an objection, just tell and we can easily revert I am afraid that I have to downvote this for two reasons: 1. JAnsi requires Microsoft Visual C++ 2008 SP1 Redistributable Package [1]. According to Microsoft, this applies to Windows

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
Something is still fishy about it. I have constant IT failure with MavenITmng3748BadSettingsXmlTest. Log is: === [INFO] Error stacktraces are turned on. [WARNING] [WARNING] Some problems were encountered while building the effective settings [[1

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
Am 2016-06-12 um 10:38 schrieb Christian Schulte: Am 06/12/16 um 00:03 schrieb Michael Osipov: Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: if someone has an objection, just tell and we can easily revert Hervé, thank you for the hard work. I not sure wether this is related to recent change

Re: Please consider my PRs :-)

2016-06-12 Thread Jochen Wiedmann
Hello, Markus, are you aware, that plexus-utils is being replaced by the maven-shared-utils? Jochen On Sun, Jun 12, 2016 at 6:03 PM, Markus KARG wrote: > Hello Maven Committers, > > > > I would like to kindly ask to consider my PRs for merging: > > > > * Plexus Utils: https://github.com/codeha

Please consider my PRs :-)

2016-06-12 Thread Markus KARG
Hello Maven Committers, I would like to kindly ask to consider my PRs for merging: * Plexus Utils: https://github.com/codehaus-plexus/plexus-utils/pull/12 * Plexus Utils: https://github.com/codehaus-plexus/plexus-utils/pull/13 * Maven Plugins: https://github.com/apache/maven-plugins/pull/

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Hervé BOUTEMY
good concern Here is my personal analysis on this important topic Until now, our full color strategy was based on logging implementation: then logging implementation was a strategic choice But the current strategy is now to put color in messages, independantly from logging implementation: see

Re: [2/2] maven git commit: [MNG-6006] Import Aether to Maven codebase

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 16:14 schrieb Karl Heinz Marbaise: > Hi Christian, > > On 6/12/16 4:06 PM, Christian Schulte wrote: >> Am 06/12/16 um 15:56 schrieb Karl Heinz Marbaise: >>> Hi, >>> >>> We might make a few weeks later a bug fix release 3.4.1 which contains >>> those changes...but this changes behavi

Re: [2/2] maven git commit: [MNG-6006] Import Aether to Maven codebase

2016-06-12 Thread Karl Heinz Marbaise
Hi Christian, On 6/12/16 4:06 PM, Christian Schulte wrote: Am 06/12/16 um 15:56 schrieb Karl Heinz Marbaise: Hi, We might make a few weeks later a bug fix release 3.4.1 which contains those changes...but this changes behaviour so we might need to make a 3.5.0 ... That same discussion will ta

Re: [2/2] maven git commit: [MNG-6006] Import Aether to Maven codebase

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 15:56 schrieb Karl Heinz Marbaise: > Hi, > > We might make a few weeks later a bug fix release 3.4.1 which contains > those changes...but this changes behaviour so we might need to make a > 3.5.0 ... That same discussion will take place for Maven 3.5, 3.6, 3.7 and so on. That's a

Re: https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 15:40 schrieb Robert Scholte: >> >> Why? >> > > Let me quote myself: > "I've been talking about this change with a couple of fellow committers at > FOSDEM and it convinced me that you never ever want to manage optional. > They have too much effect on the dependencies using it. F

Re: [2/2] maven git commit: [MNG-6006] Import Aether to Maven codebase

2016-06-12 Thread Karl Heinz Marbaise
Hi, We might make a few weeks later a bug fix release 3.4.1 which contains those changes...but this changes behaviour so we might need to make a 3.5.0 ... Kind regards Karl Heinz Marbaise On 6/12/16 3:49 PM, Karl Heinz Marbaise wrote: Hi, this can not be done at the moment, cause the Aethe

Re: https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Karl Heinz Marbaise
Hi Christian, On 6/12/16 3:48 PM, Christian Schulte wrote: That will all go into the release notes, of course. There is more to come. Before we go any further. I've just pushed a MNG-6006 branch. Do this: Which couldn't be done yet cause the sub tasks are not completed. As i mentioned in the

Re: [2/2] maven git commit: [MNG-6006] Import Aether to Maven codebase

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 15:49 schrieb Karl Heinz Marbaise: > Hi, > > this can not be done at the moment, cause the Aether thing is not clear > yet...Changes for package structure is not yet done. Meeting of Eclipse > board will be done mid june as far as i know... > > So -1 for this change... Also for

Re: [2/2] maven git commit: [MNG-6006] Import Aether to Maven codebase

2016-06-12 Thread Karl Heinz Marbaise
Hi, this can not be done at the moment, cause the Aether thing is not clear yet...Changes for package structure is not yet done. Meeting of Eclipse board will be done mid june as far as i know... So -1 for this change... Karl Heinz Marbaise Aapche PMC Member On 6/12/16 3:32 PM, schu...@apa

Re: https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 15:01 schrieb Robert Scholte: >> Hi, >> >> based on the feedback of the tests for current Maven 3.4.0-SNAPSHOT >> testing I have taken a deeper look into some of the changes. >> >> Based on the above issue we now have changed the behaviour of Maven >> 3.4.0 compared to 3.3.9 (and

Re: https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Robert Scholte
On Sun, 12 Jun 2016 15:10:35 +0200, Christian Schulte wrote: Am 06/12/16 um 15:01 schrieb Robert Scholte: Based on the description "Make 'optional' flag of a dependency manageable" I would say -1 for this change. Why? Let me quote myself: "I've been talking about this change with a co

Re: https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Karl Heinz Marbaise
Hi, On 6/12/16 3:10 PM, Christian Schulte wrote: Am 06/12/16 um 15:01 schrieb Robert Scholte: Based on the description "Make 'optional' flag of a dependency manageable" I would say -1 for this change. Why? At the moment (I'm not sure about this) is that this change is changing behaviour in

Re: https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 15:01 schrieb Robert Scholte: > Based on the description "Make 'optional' flag of a dependency manageable" > I would say -1 for this change. Why? > Or is this the answer to global excludes? It can be used to exclude a dependency globally by flagging it optional in dependency man

Re: https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Robert Scholte
Based on the description "Make 'optional' flag of a dependency manageable" I would say -1 for this change. Or is this the answer to global excludes? Even then I'm -1 and prefer extra elements in the model 5. Maybe the description is misleading, because IIRC this is more about transitive dep

https://issues.apache.org/jira/browse/MNG-5227

2016-06-12 Thread Karl Heinz Marbaise
Hi, based on the feedback of the tests for current Maven 3.4.0-SNAPSHOT testing I have taken a deeper look into some of the changes. Based on the above issue we now have changed the behaviour of Maven 3.4.0 compared to 3.3.9 (and before). It looks like this change breaks some builds... So

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 00:03 schrieb Michael Osipov: > Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY: >> if someone has an objection, just tell and we can easily revert > > Hervé, > > thank you for the hard work. > > I not sure wether this is related to recent changes to master or Maven > Core ITs maste

Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)

2016-06-12 Thread Michael Osipov
True words. What is actually wrong with the color support in Logback? Regardless of this, issues filed with Logback can take a very long time to fix. Some of mine are still open after several years. I'd rather have one quick dev than several which constantly ignore reports. M Am 2016-06-12 um