[GitHub] maven issue #112: Fix snapshot regular expression

2017-04-16 Thread kevin-canadian
Github user kevin-canadian commented on the issue: https://github.com/apache/maven/pull/112 If I run into any problems I'll mention them here, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven issue #112: Fix snapshot regular expression

2017-04-16 Thread khmarbaise
Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/112 It would be great if you could do that, cause it should be honoured to those who found the bug(s)...If I can support you please ask how? --- If your project is set up for it, you can reply to

[GitHub] maven issue #112: Fix snapshot regular expression

2017-04-16 Thread kevin-canadian
Github user kevin-canadian commented on the issue: https://github.com/apache/maven/pull/112 Thanks for the quick reply. This PR was prompted by a bug we discovered in our production build environment. When we updated our release artifact version number format to be

[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...

2017-04-16 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 I hope we will release 2.20.1 soon, EO April - BO May. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...

2017-04-16 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 @jerrinot Thx for contributing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...

2017-04-16 Thread jerrinot
Github user jerrinot commented on the issue: https://github.com/apache/maven-surefire/pull/147 @Tibor17: excellent, many thanks for a quick fix! Do you have an expected release date for 2.20.1 ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven-surefire pull request #147: Reporters use buffers to reduce number of ...

2017-04-16 Thread jerrinot
Github user jerrinot closed the pull request at: https://github.com/apache/maven-surefire/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: New branch SUREFIRE-1361 to approve

2017-04-16 Thread Michael Osipov
Am 2017-04-16 um 17:57 schrieb Tibor Digana: Hi, I have copied [1] to branch SUREFIRE-1361 [2] and fixed checkstyle from the contributor. Can we proceed and push it to the master? [1] https://github.com/apache/maven-surefire/pull/147 [2]

Re: New branch SUREFIRE-1361 to approve

2017-04-16 Thread Tibor Digana
If there are no objections I will push it to master. On Sun, Apr 16, 2017 at 5:57 PM, Tibor Digana wrote: > Hi, > I have copied [1] to branch SUREFIRE-1361 [2] and fixed checkstyle from > the contributor. > Can we proceed and push it to the master? > > [1]

[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...

2017-04-16 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 @jerrinot Pls close this PR. I created a branch https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=9c0025ed53d70c06279fef6c0fc30a54aeeab27b --- If your project is

[GitHub] maven issue #112: Fix snapshot regular expression

2017-04-16 Thread khmarbaise
Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/112 If you will take some time it's not a problem...the PR will be kept here for a long time until you will close it yourself ..so you can be patient and take the time you need...no hurry

Re: New branch SUREFIRE-1361 to approve

2017-04-16 Thread Tibor Digana
The build passed. On Sun, Apr 16, 2017 at 5:57 PM, Tibor Digana-2 [via Maven] < ml-node+s40175n5906549...@n5.nabble.com> wrote: > Hi, > I have copied [1] to branch SUREFIRE-1361 [2] and fixed checkstyle from > the > contributor. > Can we proceed and push it to the master? > > [1]

New branch SUREFIRE-1361 to approve

2017-04-16 Thread Tibor Digana
Hi, I have copied [1] to branch SUREFIRE-1361 [2] and fixed checkstyle from the contributor. Can we proceed and push it to the master? [1] https://github.com/apache/maven-surefire/pull/147 [2]

[GitHub] maven issue #112: Fix snapshot regular expression

2017-04-16 Thread kevin-canadian
Github user kevin-canadian commented on the issue: https://github.com/apache/maven/pull/112 I actually just wanted to let you know about the bug, and since the fix was so simple I made a PR rather than creating an issue. It will be a while before I have time look into the

Re: rewrite StatelessXmlReporter fo JAXB

2017-04-16 Thread Michael Osipov
Am 2017-04-16 um 16:52 schrieb Tibor Digana: That would still create a string in memory, won't it? It would still leak in memory while getter is called. Streaming to XML is better in this case. Do we have any alternative? I have to think about it and understand the whole system. But why not

Re: rewrite StatelessXmlReporter fo JAXB

2017-04-16 Thread Tibor Digana
>> That would still create a string in memory, won't it? It would still leak in memory while getter is called. Streaming to XML is better in this case. Do we have any alternative? On Sun, Apr 16, 2017 at 4:40 PM, Michael Osipov wrote: > Am 2017-04-16 um 16:15 schrieb Tibor

Re: rewrite StatelessXmlReporter fo JAXB

2017-04-16 Thread Michael Osipov
Am 2017-04-16 um 16:15 schrieb Tibor Digana: Since we have XSD [1] we can generate classes and call setters in particular places in StatelessXmlReporter.java. Regarding memory consumption system-out may consume really a lot of memory. Therefore this is my proposal:

Re: rewrite StatelessXmlReporter fo JAXB

2017-04-16 Thread Tibor Digana
Since we have XSD [1] we can generate classes and call setters in particular places in StatelessXmlReporter.java. Regarding memory consumption system-out may consume really a lot of memory. Therefore this is my proposal: @XmlJavaTypeAdapter(CdataSystemAdapter.class) public

Re: Publish Maven releases on SDKMAN!

2017-04-16 Thread Stephen Connolly
On Sun 16 Apr 2017 at 11:32, Marco Vermeulen wrote: > Hi Maven folks, > > I really haven't come here to start a flame war or to give justification > about why/how I built SDKMAN. Even less, justifying why I gave it such a > "silly" name. I have come here with friendly

Re: rewrite StatelessXmlReporter fo JAXB

2017-04-16 Thread Michael Osipov
Am 2017-04-16 um 14:21 schrieb Tibor Digana: Hi, I want to first talk with you about XML marshaller StatelessXmlReporter [1] in Surefire which is built on the top of SharedUtils' PrettyPrintXMLWriter. I found out issues after a contributor opened this issue [2]. The problem is that we are

[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...

2017-04-16 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 I am just discussing with ASF colleagues rewriting `StatelessXmlReporter` to JAXB. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Publish Maven releases on SDKMAN!

2017-04-16 Thread Marco Vermeulen
Hi Maven folks, I really haven't come here to start a flame war or to give justification about why/how I built SDKMAN. Even less, justifying why I gave it such a "silly" name. I have come here with friendly intent to help your community publish their own releases on SDKMAN. I've come back since I

Re: Publish Maven releases on SDKMAN!

2017-04-16 Thread Aldrin Leal
just fyi: github releases has an atom feed. https://github.com/apache/maven/releases.atom -- -- Aldrin Leal, / http://about.me/aldrinleal On Sun, Apr 16, 2017 at 4:49 AM, Marco Vermeulen wrote: > Hi Heinz, > > On Sun, 16 Apr 2017 at 08:41 Karl

Re: Publish Maven releases on SDKMAN!

2017-04-16 Thread Marco Vermeulen
Hi Heinz, On Sun, 16 Apr 2017 at 08:41 Karl Heinz Marbaise wrote: > Hi, > > On 16/04/17 00:56, Marco Vermeulen wrote: > > Hi Maven folks, > > > > Some time ago I asked the Maven dev community whether they would be > willing > > to publish their releases on SDKMAN! [1] using

Re: Publish Maven releases on SDKMAN!

2017-04-16 Thread Aldrin Leal
Ironically, I've ported nvm (for node), but for Maven , but ended up using sdkman later. I wonder if it would be interesting to have a service to generate webhooks and rss feeds for new versions/releases on github and apache overall. -- -- Aldrin Leal,

Re: Publish Maven releases on SDKMAN!

2017-04-16 Thread Karl Heinz Marbaise
Hi, On 16/04/17 00:56, Marco Vermeulen wrote: Hi Maven folks, Some time ago I asked the Maven dev community whether they would be willing to publish their releases on SDKMAN! [1] using our Vendor API [2]. Unfortunately, my request was met with scepticism and ultimately resulted in no action

[GitHub] maven-surefire pull request #147: Reporters use buffers to reduce number of ...

2017-04-16 Thread jerrinot
Github user jerrinot commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/147#discussion_r111679651 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java --- @@ -292,15 +293,15 @@ private

[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...

2017-04-16 Thread jerrinot
Github user jerrinot commented on the issue: https://github.com/apache/maven-surefire/pull/147 @Tibor17: thanks a lot for a quick review, I updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven-surefire pull request #147: Reporters use buffers to reduce number of ...

2017-04-16 Thread jerrinot
Github user jerrinot commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/147#discussion_r111679608 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java --- @@ -91,7 +93,7 @@ public

Re: Publish Maven releases on SDKMAN!

2017-04-16 Thread Thomas Matthijs
Looks like yet another package manager, and just as most upstream projects don't provide the packages/build for every linux distro and package manager system under the sun, this project looks no different. The sdkman community should help provide the maven releases on it, and not the maven