Re: ATTN: Maven core build is broken

2017-08-30 Thread Tibor Digana
Class-Path is used in Manifest unless you configure the plugin to use env variable CLASSPATH. On Thu, Aug 31, 2017 at 12:24 AM, Igor Fedorenko wrote: > How does surefire setup jvm classpath when it runs plugin unit and > integration tests? > > -- > Regards, > Igor > > On Wed, Aug 30, 2017, at 05

Re: ATTN: Maven core build is broken

2017-08-30 Thread Igor Fedorenko
How does surefire setup jvm classpath when it runs plugin unit and integration tests? -- Regards, Igor On Wed, Aug 30, 2017, at 05:22 PM, Stephen Connolly wrote: > Unit test is still present in my branch, so should be a yes (if your unit > test works) > > On Wed 30 Aug 2017 at 21:50, Robert Sch

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
Unit test is still present in my branch, so should be a yes (if your unit test works) On Wed 30 Aug 2017 at 21:50, Robert Scholte wrote: > But can you access classes via the ServiceLoader? > > On Wed, 30 Aug 2017 22:48:40 +0200, Stephen Connolly > wrote: > > > Oh wow! > > > https://builds.apach

Re: ATTN: Maven core build is broken

2017-08-30 Thread Robert Scholte
But can you access classes via the ServiceLoader? On Wed, 30 Aug 2017 22:48:40 +0200, Stephen Connolly wrote: Oh wow! https://builds.apache.org/blue/organizations/jenkins/maven-3.x-jenkinsfile/detail/mng-6275/3/pipeline Can we get Stuart and Igor to review: https://github.com/apache/maven/

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
Oh wow! https://builds.apache.org/blue/organizations/jenkins/maven-3.x-jenkinsfile/detail/mng-6275/3/pipeline Can we get Stuart and Igor to review: https://github.com/apache/maven/compare/mng-6275 Seems almost too easy! On 30 August 2017 at 17:02, Robert Scholte wrote: > I agree > > > On Wed

Re: ATTN: Maven core build is broken

2017-08-30 Thread Robert Scholte
I agree On Wed, 30 Aug 2017 18:01:12 +0200, Stephen Connolly wrote: I think we'll de-scope 6275 for 3.5.1 On Wed 30 Aug 2017 at 16:04, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: Hmmm... looking like we may have to descope MNG-6275... I'll do some more digging first t

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
I think we'll de-scope 6275 for 3.5.1 On Wed 30 Aug 2017 at 16:04, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hmmm... looking like we may have to descope MNG-6275... I'll do some more > digging first though > > > On 30 August 2017 at 04:34, Stephen Connolly < > stephen.alan.c

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
Hmmm... looking like we may have to descope MNG-6275... I'll do some more digging first though On 30 August 2017 at 04:34, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > fef668789f6abe79f603b96a8ee6f13ea52de4df should verify if that fixes > things > > On 30 August 2017 at 04:13, St

[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...

2017-08-30 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @owenfarrell I will try by myself. I will let you know with new branch and we can discuss it. --- If your project is set up for it, you can reply to this email and have your reply appea

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
fef668789f6abe79f603b96a8ee6f13ea52de4df should verify if that fixes things On 30 August 2017 at 04:13, Stuart McCulloch wrote: > On Wednesday, 30 August 2017 at 10:26, Stephen Connolly wrote: > > https://github.com/apache/maven/commit/39004f6aee634a0ac6daa1f99add29 > 9ff439f5ec > > should fix >

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
On 30 August 2017 at 04:13, Stuart McCulloch wrote: > On Wednesday, 30 August 2017 at 10:26, Stephen Connolly wrote: > > https://github.com/apache/maven/commit/39004f6aee634a0ac6daa1f99add29 > 9ff439f5ec > > should fix > > > > > > Is it worth storing the chosen context/system loader in a member v

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stuart McCulloch
On Wednesday, 30 August 2017 at 10:26, Stephen Connolly wrote: > https://github.com/apache/maven/commit/39004f6aee634a0ac6daa1f99add299ff439f5ec > should fix > > Is it worth storing the chosen context/system loader in a member variable, or maybe even statically like PARENT_CLASSLOADER, rather

Re: ATTN: Maven core build is broken

2017-08-30 Thread Robert Scholte
https://builds.apache.org/job/maven-3.x-jenkinsfile/job/mng-6275/1/testReport/junit/org.apache.maven.it/MavenITmng4273RestrictedCoreRealmAccessForPluginTest/testit/ This one now fails as well, suggesting that suddenly classes solely for core became available for the plugin. Would mean to me t

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
The question is this: Is plexus-interpolator part of the classes contracted to be exposed from core or is it one of the classes that plugin-first classloading should apply. If the first then we have exposed a bug... if the latter then the fix is incomplete On 30 August 2017 at 04:02, Stephen

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
https://github.com/codehaus-plexus/plexus-interpolation/commit/0714af6ce3b4371a8a914496f3632c405b2e3e0c#diff-95342973516cd90dd54ef6a15afa1961 should have *added* the methods taking BasicInterpolator rather than replace the methods taking Interpolator Then https://github.com/codehaus-plexus/plexus-

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
Kristian, FYI https://github.com/codehaus-plexus/plexus-interpolation/commit/0714af6ce3b4371a8a914496f3632c405b2e3e0c broke binary compatibility On 30 August 2017 at 03:54, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hmmm so my fix has 24 failing tests... most of which seem to b

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
Hmmm so my fix has 24 failing tests... most of which seem to be failing due to: Caused by: java.lang.NoSuchMethodError: org.codehaus.plexus.interpolation.object.FieldBasedObjectInterpolator.interpolate(Ljava/lang/Object;Lorg/codehaus/plexus/interpolation/Interpolator;Lorg/codehaus/plexus/interpola

[VOTE] Release Apache Maven JDeps Plugin version 3.1.0

2017-08-30 Thread Robert Scholte
Hi, We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319223&version=12341415&styleName=Text There is still one issue left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012319223%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20

Re: ATTN: Maven core build is broken

2017-08-30 Thread Robert Scholte
I agree, it would be nice if this one was shipped with one of the next releases, as long as it's stable. I was kind of surprised that the contextloader could be null, but after reading the docs this change makes sense. I was too fast with the revert, meaning you could reintroduce the unit-tes

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
I have deleted bisect-0 through -3 as they have served their purpose On Wed 30 Aug 2017 at 10:31, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > > https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/mng-6275/ > will report the status... I am more in favour of

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/mng-6275/ will report the status... I am more in favour of including MNG-6275 rather than reverting, but let's get Igor's opinion after we (hopefully) get a clean test run. Absence a clean test run on https://builds.apache

Re: ATTN: Maven core build is broken

2017-08-30 Thread Stephen Connolly
https://github.com/apache/maven/commit/39004f6aee634a0ac6daa1f99add299ff439f5ec should fix On 30 August 2017 at 02:09, Robert Scholte wrote: > Now that the ITs are all in place again it is good to see that these > failures reflect the concerns of Igor. > Originally this issue said it was Java 9

Re: ATTN: Maven core build is broken

2017-08-30 Thread Robert Scholte
Now that the ITs are all in place again it is good to see that these failures reflect the concerns of Igor. Originally this issue said it was Java 9 related, but this is a Java 8 issue as well, so there's no real need to include it for 3.5.1 I'll revert this commit and reopen the issue. Future