Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

2018-11-04 Thread Tibor Digana
Well, yes there should be two repos. One is Maven Central and the second is the staging because the ASF staging Nexus is not a copy of Central. There are only our Apache artifacts deployed. On Sun, Nov 4, 2018 at 5:12 PM Eric Lilja wrote: > +1 (non-binding) > > When testing on my personal projec

Re: [VOTE] Release Apache Maven Jarsigner Plugin version 3.0.0

2018-11-04 Thread Eric Lilja
Aha, indeed, I missed that part. Sorry for the noise! - EL On 2018-11-03 22:26, Tibor Digana wrote: It was a component [1] but now it is a plugin [2]. [1]: https://github.com/apache/maven-jarsigner [2]: https://github.com/apache/maven-jarsigner-plugin On Sat, Nov 3, 2018 at 6:32 PM Eric Lilj

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

2018-11-04 Thread Eric Lilja
+1 (non-binding) When testing on my personal projects, I did see one JUnit test failure on some very old code, a test which didn't have any problems on surefire 2.18.1-2.22.1. I examined the test and came to the conclusion that is was misbehaved as it tried to treat a classpath resource as a f

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Mark Raynsford
On 2018-11-04T15:34:11 +0100 Hervé BOUTEMY wrote: > you can build https://github.com/apache/maven/tree/MNG-6059 with quick build > instruction at the end of README > Thanks. I've built 523db580468bc2b9d8420470bb24f5f688220701 and it seems to be working for all but the project/distributionManag

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Hervé BOUTEMY
you can build https://github.com/apache/maven/tree/MNG-6059 with quick build instruction at the end of README Regards, Hervé Le dimanche 4 novembre 2018, 13:48:51 CET Mark Raynsford a écrit : > On 2018-11-04T13:34:39 +0100 > > Hervé BOUTEMY wrote: > > Hi Mark, > > > > Seems you found one mor

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Mark Raynsford
On 2018-11-04T13:34:39 +0100 Hervé BOUTEMY wrote: > Hi Mark, > > Seems you found one more thing that I forgot when merging MNG-6059: > inheritance of these child.inherit.append.path configurations... > > I created MNG-6505 [1] and added the fix to MNG-6059 branch. > > Can you check that it wo

Re: Inheritance behaviour for MNG-5951 attributes?

2018-11-04 Thread Hervé BOUTEMY
Hi Mark, Seems you found one more thing that I forgot when merging MNG-6059: inheritance of these child.inherit.append.path configurations... I created MNG-6505 [1] and added the fix to MNG-6059 branch. Can you check that it works as you expect? (notice: with the new child.x.y.inherit.append.p

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

2018-11-04 Thread Tibor Digana
One important remark regarding testing with JDK 9+. The Surefire project runs itself tests within maven-surefire-plugin:2.12.4 which properly isolates project classes and plugin's classes. Next version 3.0.0-M2 should load user's classes in IsolatedClassLoader (configured by parameter in POM). Due

[VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

2018-11-04 Thread Tibor Digana
Hi, We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC Staging repo: https://r