Re: Yearly JIRA cleanup

2019-12-12 Thread Stephen Connolly
On Thu 12 Dec 2019 at 17:31, Robert Scholte wrote: > IIUC since Jira uses the ASF LDAP, there's no extra need for Brian to do > this anymore. All should be in place by now. > I think we have some crazy permissions that Brian manages. Ldap just fixes the account name to match across systems AIUI

Re: Creating stub artifacts through ArtifactStubFactory

2019-12-12 Thread Robert Scholte
The maven-plugin-testing-harness isn't that popular anymore by most Maven Developers. Even though it executes like a plugin, there's still a lot of stubbing required to make a test work. Hence the integration-tests with the maven-invoker-plugin which reflects much better the usage with Maven.

Re: Yearly JIRA cleanup

2019-12-12 Thread Robert Scholte
IIUC since Jira uses the ASF LDAP, there's no extra need for Brian to do this anymore. All should be in place by now. thanks, Robert On 12-12-2019 15:20:24, Stephen Connolly wrote: On Mon 9 Dec 2019 at 20:53, Elliotte Rusty Harold wrote: > On Mon, Dec 9, 2019 at 3:18 PM Michael Osipov wrote:

Please close MCHECKSTYLE-383

2019-12-12 Thread Benjamin Marwell
Hello, the issue https://issues.apache.org/jira/browse/MCHECKSTYLE-383 can be closed if I read it correctly. I think the issue reporter meant to report this issue over at https://github.com/checkstyle/checkstyle/issues. Ben -

Re: Yearly JIRA cleanup

2019-12-12 Thread Stephen Connolly
On Mon 9 Dec 2019 at 20:53, Elliotte Rusty Harold wrote: > On Mon, Dec 9, 2019 at 3:18 PM Michael Osipov wrote: > > > > Am 2019-12-08 um 18:08 schrieb Elliotte Rusty Harold: > > > Please don't. There are certainly some real and important issues in > > > there. More importantly, users spent a

Re: Contributing on the maven Checkstyle plugin

2019-12-12 Thread Benjamin Marwell
There you go: https://github.com/apache/maven-checkstyle-plugin/pull/17 I also created an improvement issue for this: https://issues.apache.org/jira/browse/MCHECKSTYLE-385 Do you need a --sign-off? Also, I haven't signed the CLA yet. Maybe the code change is insignificant enough, because it does

Creating stub artifacts through ArtifactStubFactory

2019-12-12 Thread Maarten Mulders
Hi all, As I was working on MDEP-666 I noticed the test suite for the tree mojo is effectively disabled. This is also blocking progress on MDEP-435, as it's hard to verify it doesn't break anything. So I thought of re-enabling the test suite for the tree mojo. I found a way to make it work,