[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

2021-09-22 Thread GitBox
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-924734705 @cstamas Go ahead a merge it. I appreciate your high quality work. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

2021-09-08 Thread GitBox
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-915321903 Question to reviews. Do we really need Sisu support for Maven 3.0.x? I'd rather drop it and focus on 3.1.x+ only. -- This is an automated message from the Apach

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

2021-09-08 Thread GitBox
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-915269142 Maven Deploy Plugin must be tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

2021-06-02 Thread GitBox
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-852851846 I will check when I can... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

2021-06-02 Thread GitBox
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-852847100 I will check when I can... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

2021-05-02 Thread GitBox
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850011 Can you explain why we need `Maven302RepositoryManager? instead of just `Maven302RepositoryManager`? -- This is an automated message from the Apache Git Servic

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

2021-05-02 Thread GitBox
michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849772 > > > General remark @michael-o : I did not made any other code change then: > > * added ProjectBuildingRequest parameter to methods, removed som