Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-167269576
@seanf done!
You can check it out with 2.20-SNAPSHOT.
I will start the Release Vote on Sunday/Monday.
2.19.1 will be in Maven Central on Wednesday.
Github user seanf commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-164965305
Okay, thanks @Tibor17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user seanf closed the pull request at:
https://github.com/apache/maven-surefire/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-164952250
@seanf Please close this PR. I will push the fix to the master. Thx for
contributing.
---
If your project is set up for it, you can reply to this email and
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-162313183
@seanf I think your feature should be possible only in `surefire-junit4`
provider. Not in `surefire-junit47`. Did you have time to run tests with your
Github user seanf commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-161909472
Hi Tibor,
I don't understand. Are you saying you did try to build an IT for this?
Could you share it, please? What counts would you consider realistic?
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-161945817
@seanf
>>Are you saying you did try to build an IT for this?
reuseForks=false would not work in 2.19 feature.
Initially skipAfterFailureCount was not
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-161337141
Try to build IT with your code with more realistic counts, but the
fail-fast feature would not be coherent due to concurrency problem across forks.
---
If your
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/108#issuecomment-161285312
@seanf Can you edd integration test?
You can add new test method to an existing IT.
---
If your project is set up for it, you can reply to this email and
GitHub user seanf opened a pull request:
https://github.com/apache/maven-surefire/pull/108
[SUREFIRE-1202] Allow rerunFailingTestsCount, skipAfterFailureCount tâ¦
â¦ogether
You can merge this pull request into a Git repository by running:
$ git pull
10 matches
Mail list logo
