Re: ComparableVersionTest

2016-09-25 Thread Stephen Connolly
So let's think how this would work in a project dependency tree world... For each node in the tree we would need to provide: 1. Any coordinates of artifacts that are provided by this artifact (or a compatible implementation is provided)... in most cases this will be empty, but still 2. Any

Re: ComparableVersionTest

2016-09-25 Thread Hervé BOUTEMY
Le dimanche 25 septembre 2016 13:21:27 Karl Heinz Marbaise a écrit : > If you start thinking about version comparison in detail (I have > started with this a little bit ;-( ) it will become really a > nightmare...and really hard... > > What happens with artifacts in your repository manager if

Re: ComparableVersionTest

2016-09-25 Thread Tibor Digana
point is not the > test > >> however I read your test completely and have nothing against your test > >> LGTM. The purpose of the scripts is to move the responsibility to user > in > >> order to implement some user's wishes on their side. > >> >

Re: ComparableVersionTest

2016-09-25 Thread Karl Heinz Marbaise
on the code in comparison to the original ComparableVersionTest which uses Comparator as return type which produces warnings in IDE about raw types which I tried to fix...and now I would like to have someone taken a look on it if I didn't missing an important thing in the test which might make an assu

Re: ComparableVersionTest

2016-09-25 Thread Karl Heinz Marbaise
Regards, Hervé Le samedi 24 septembre 2016 19:12:34 Karl Heinz Marbaise a écrit : Hi, I have polished the code of the ComparableVersionTest class a little bit...which looks like this: https://gist.github.com/khmarbaise/a75a967983118de0dddea0adbd21b9d7 This will prevent warnings in IDE about raw

Re: ComparableVersionTest

2016-09-25 Thread Hervé BOUTEMY
t; Hi Tibor, > > > > maybe you misunderstand my request...I would like to have review on the > > code in comparison to the original ComparableVersionTest which uses > > Comparator as return type which produces warnings in IDE about raw types > > which I tried to

Re: ComparableVersionTest

2016-09-25 Thread Hervé BOUTEMY
septembre 2016 19:12:34 Karl Heinz Marbaise a écrit : > Hi, > > I have polished the code of the ComparableVersionTest class a little > bit...which looks like this: > > https://gist.github.com/khmarbaise/a75a967983118de0dddea0adbd21b9d7 > > This will prevent warnings in IDE abou

Re: ComparableVersionTest

2016-09-25 Thread Tibor Digana
:25 AM, Karl Heinz Marbaise <khmarba...@gmx.de> wrote: > Hi Tibor, > > maybe you misunderstand my request...I would like to have review on the > code in comparison to the original ComparableVersionTest which uses > Comparator as return type which produces warnings in IDE abou

Re: ComparableVersionTest

2016-09-25 Thread Karl Heinz Marbaise
Hi Tibor, maybe you misunderstand my request...I would like to have review on the code in comparison to the original ComparableVersionTest which uses Comparator as return type which produces warnings in IDE about raw types which I tried to fix...and now I would like to have someone taken

Re: ComparableVersionTest

2016-09-25 Thread Tibor Digana
at 7:13 PM, Karl Heinz Marbaise-3 [via Maven] < ml-node+s40175n5881382...@n5.nabble.com> wrote: > Hi, > > I have polished the code of the ComparableVersionTest class a little > bit...which looks like this: > > https://gist.github.com/khmarbaise/a75a967983118de0dddea0adbd21b

ComparableVersionTest

2016-09-24 Thread Karl Heinz Marbaise
Hi, I have polished the code of the ComparableVersionTest class a little bit...which looks like this: https://gist.github.com/khmarbaise/a75a967983118de0dddea0adbd21b9d7 This will prevent warnings in IDE about raw types... WDYT ? Kind regards Karl Heinz Marbaise