I think this is still waiting for feedback from me. There are parts that I
still don't like.
Now that maven-wrapper is mostly done, I will put effort on build-consumer
first, because even once implemented, there will be several other tasks that
needs to be done.
After that I might have time to e
Stephen,
do we have news about this great feature ?
Enrico
Il giorno sab 23 nov 2019 alle ore 11:51 Stephen Connolly <
stephen.alan.conno...@gmail.com> ha scritto:
> Ok I figured out dynamic lookup from plexus:
>
> $ mvn -version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>
Ok I figured out dynamic lookup from plexus:
$ mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T19:33:14+01:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 1.8.0_152, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk
I have advanced the PoC a bit more by adding an experiments mechanism.
To use the dynamic phases PoC you now need to:
1. Build and install Maven on the branch
2. Add the experiments extension in .mvn/extensions.xml, e.g.
http://maven.apache.org/EXTENSIONS/1.0.0"; xmlns:xsi="
http://www.w3.org/2
On Fri 15 Nov 2019 at 15:18, Robert Scholte wrote:
> I have to admit that when trying to figure out from a Maven perspective it
> felt like post-X should be called with pre-X too, but that opinion has
> changed.
> Why would anybody call pre-X? I'd say to bring the system ready to do
> custom X st
I have to admit that when trying to figure out from a Maven perspective it felt
like post-X should be called with pre-X too, but that opinion has changed.
Why would anybody call pre-X? I'd say to bring the system ready to do custom X
stuff, so it should stop here executing any other phases.
Howev
On Fri 15 Nov 2019 at 09:18, Robert Scholte wrote:
> On 13-11-2019 21:46:04, Stephen Connolly
> wrote:
> On Wed 13 Nov 2019 at 19:29, Robert Scholte wrote:
>
> > The name of the branch contains MNG-5668, but it contains much more.
> > I'd likely lead to comments like "great", without being expli
On 13-11-2019 21:46:04, Stephen Connolly
wrote:
On Wed 13 Nov 2019 at 19:29, Robert Scholte wrote:
> The name of the branch contains MNG-5668, but it contains much more.
> I'd likely lead to comments like "great", without being explicit saying
> which part(s).
> I am aware there's all proposals
On Wed 13 Nov 2019 at 19:29, Robert Scholte wrote:
> The name of the branch contains MNG-5668, but it contains much more.
> I'd likely lead to comments like "great", without being explicit saying
> which part(s).
> I am aware there's all proposals touch the same code, but can be released
> isolat
On Wed 13 Nov 2019 at 19:29, Robert Scholte wrote:
> The name of the branch contains MNG-5668, but it contains much more.
> I'd likely lead to comments like "great", without being explicit saying
> which part(s).
> I am aware there's all proposals touch the same code, but can be released
> isolat
The name of the branch contains MNG-5668, but it contains much more.
I'd likely lead to comments like "great", without being explicit saying which
part(s).
I am aware there's all proposals touch the same code, but can be released
isolated from each other.
e.g. if the enums-value are changed to "p
Stephen Connolly wrote:
> https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases
>
> Thoughts?
Very nice. I like this a lot. In particular, it still feels like Maven
with its well-known phases rather than like the "every project rolls
their own" approach of Ant or Gradle.
And to answer
On Tue 12 Nov 2019 at 07:34, Robert Scholte wrote:
> This is not just MNG-5668, but also contains several non-existing issues,
> that should be mentioned explicitly as they will have huge impact:
>
> - support before:/after: prefix for phase-binding
>
> - introduce priority
> - reduce phases (thi
This is not just MNG-5668, but also contains several non-existing issues, that
should be mentioned explicitly as they will have huge impact:
- support before:/after: prefix for phase-binding
- introduce priority
- reduce phases (this one hasn't been implemented, but seems to be the reason
behin
https://github.com/apache/maven/tree/mng-5668-poc is my POC implementation
for anyone interested in trying it out.
Here's a pom that builds with the PoC
4.0.0
localdomain
foo
1.0-SNAPSHOT
maven-antrun-plugin
TLDR: We can do better than, but who is in control? lifecycle-owner,
plugin-owner or pom-owner?
I think we all recognize the issues we're trying to solve, but to me this
proposal is not the right solution.
In general there are 2 issues:
1. provide a mechanism that makes sure some executions are
On Sat 26 Oct 2019 at 10:50, Robert Scholte wrote:
> To avoid confusion, let's call it stages.
>
> Stage 1: Always call post-bound executions (MNG-5665[1])
> Stage 2: before and after
> Stage 3: priorities (MNG-3522[2])
> Stage 4: transitional lifecycle
I have a prototype of stages 1-3 nearly (
To avoid confusion, let's call it stages.
Stage 1: Always call post-bound executions (MNG-5665[1])
Stage 2: before and after
Stage 3: priorities (MNG-3522[2])
Stage 4: transitional lifecycle
For both all you need to start evaluating the value of phase.
For now we can assume that after:clean is ju
I have a question to the old phases in CLI.
I will use the phase "post-site" in my examples.
$ mvn post-site
What did we expect from "post-site" and why we supported it in CLI?
>From my point of view, it is a bad use. I used it as well because I
expected Maven to run "post-site" after
$ mvn site
On Fri 25 Oct 2019 at 22:48, Tamás Cservenák wrote:
> I am referring to this sentence:
> "The logic of using : in these prefix names is that it would expressly be
> impossible to invoke these dynamic pseudo phases from the CLI as Maven will
> interpret any attempt to invoke them as $plugin:$goal
I am referring to this sentence:
"The logic of using : in these prefix names is that it would expressly be
impossible to invoke these dynamic pseudo phases from the CLI as Maven will
interpret any attempt to invoke them as $plugin:$goal and look for a
maven-before-plugin or maven-after-plugin".
On Fri 25 Oct 2019 at 21:41, Tamás Cservenák wrote:
> The fixed phases were one of the main strengths of Maven, and with this
> automatism it could really be enhanced.
>
> My dislike: the `before:goal` invocation is being "projected" to non
> existent plugin invocation. This sounds like a hack. C
The fixed phases were one of the main strengths of Maven, and with this
automatism it could really be enhanced.
My dislike: the `before:goal` invocation is being "projected" to non
existent plugin invocation. This sounds like a hack. Could we clear that
part up?
T
On Fri, Oct 25, 2019 at 10:23 P
Le 25/10/2019 à 21:01, Stephen Connolly a écrit :
> https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases
>
> Thoughts?
Sounds interesting. You may want to forbid the before/after prefix on
the deprecated phases (such as after:pre-clean).
The name of the phases use to start with a ver
I like
package[2000]
because it solves my problems when I had to order plugins to reach exactly
this feature. Even impossible to do it if plugins use different phases,
then ordering of plugins would not help.
The syntax package[2000] will solve this!
On Fri, Oct 25, 2019 at 9:36 PM Romain Manni-Bu
Hi Stephen,
I like the priority a lot and shortcut syntax - not having -
sounds a good compromise on user side (inline is always appreciated) and
impl side (no model change).
Romain
Le ven. 25 oct. 2019 à 21:02, Stephen Connolly <
stephen.alan.conno...@gmail.com> a écrit :
> https://cwiki.apac
Robert,
I would be fine splitting out into, pardon the pun, phases:
Phase 1: before and after
Phase 2: priorities
Phase 3: transitional lifecycle
Might have a phase 1.5 of before:* and after:* to catch the start of a
lifecycle and the end of a lifecycle...
On Fri 25 Oct 2019 at 20:30, Stephen C
Robert, Michael, Tibor, let’s continue here (though I asked Infra and it’s
fine that anyone in the community can join our Slack)
On Fri 25 Oct 2019 at 20:01, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:
> https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases
>
> Thoughts?
https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases
Thoughts?
--
Sent from my phone
29 matches
Mail list logo