Re: issues with the user property "maven.test.failure.ignore" and new proposals

On Thu, 24 Mar 2022 at 01:18, Tibor Digana wrote: > Hi Olivier, I have used the Maven branch according to your instructions. I > have used the snapshot version of the plugin and JDK 1.8.0u05. > Both implementations end up with the same build result. The only > difference is the number of IF-Else

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Hi Olivier, I have used the Maven branch according to your instructions. I have used the snapshot version of the plugin and JDK 1.8.0u05. Both implementations end up with the same build result. The only difference is the number of IF-Else branches in the implementation. I started Maven build

Re: issues with the user property "maven.test.failure.ignore" and new proposals

On Tue, 22 Mar 2022 at 14:40, Tibor Digana wrote: > Sorry for late reply. > > I have created a demo project > https://github.com/Tibor17/maven.test.failure.ignore/ which simulates > OOM. > > According to the definition of the parameter "maven.failure.test.ignore" > the failures (also errors)

Re: issues with the user property "maven.test.failure.ignore" and new proposals

On Tue, 22 Mar 2022 at 14:40, Tibor Digana wrote: > Sorry for late reply. > > I have created a demo project > https://github.com/Tibor17/maven.test.failure.ignore/ which simulates > OOM. > > According to the definition of the parameter "maven.failure.test.ignore" > the failures (also errors)

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Sorry for late reply. I have created a demo project https://github.com/Tibor17/maven.test.failure.ignore/ which simulates OOM. According to the definition of the parameter "maven.failure.test.ignore" the failures (also errors) should be ignored during testing. The word "during" is important

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Hi, I start to feel that we first try to define technical details but we don't know for what. Each business requirement should be resolved as simply as possible from a technical perspective. In other ways we will start to build complicated and many features which probably were not needed at all.

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Hi Tibor, just to make it clear, I don't talkin about log-levels here but how to intepret/handle a failure/failing/crashing test. Am 18.03.22 um 21:54 schrieb Tibor Digaňa: Christoph, just let me briefly explain the log level hierarchy. If you select WARN log level, then ERROR can be

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Christoph, just let me briefly explain the log level hierarchy. If you select WARN log level, then ERROR can be printed too. Similar with INFO, means that WARN and ERROR would be printed as well. The real decision making in the plugin is a bit more complicated, see the pull request

Re: issues with the user property "maven.test.failure.ignore" and new proposals

No I think more about if (severity == "WARN") { log.warn("There is something wrong"); } else if (severity == "ERROR") { throw new MojoFailureException("...") { } else { throw new MojoExecutionException("...") { } That way the plugin can handle any error/failure/... in a way that the user

Re: issues with the user property "maven.test.failure.ignore" and new proposals

@Christoph FATAL , WARN , ERROR They are log levels? The plugin does not control the log level after caught exception in Maven core. The Maven Core does! I think it's time to make a demo. On Thu, Mar 17, 2022 at 6:21 AM Christoph Läubrich wrote: > Hi Tibor, > > it shouldn't be to hard to

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Hi Tibor, it shouldn't be to hard to guess another property like maven.test.jvmcrash=FATAL maven.test.failure=WARN maven.test.error=ERROR :-) Am 16.03.22 um 12:25 schrieb Tibor Digana: Hi Christoph, Such a granularity with error/failure might be also an additional requirement but still you

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Hi Slawomir, Your second second example -DargLine=-Xxx is used in an integration test in order to force producing exceptions, but IMHO it wants to simulate two different situations. In such cases the JVM: 1. fails on JVM startup because of low RAM (fails the JVM on --add-reads or illegal

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Hi Christoph, Such a granularity with error/failure might be also an additional requirement but still you miss the third option to JVM error which is different from test error/failure - they don;t have the same meaning. T On Mon, Mar 14, 2022 at 10:57 AM Christoph Läubrich wrote: > Just

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Hi First sentence: Set this to "true" to ignore a failure during testing. It is clear for me - we want to ignore a failure during testing ... So if the testing process is not starting for any reason or was broken for reasons other than test failure this property should not be considered. Most

Re: issues with the user property "maven.test.failure.ignore" and new proposals

pon., 14 mar 2022 o 10:52 Tibor Digana napisał(a): > Romain, it is not a bug. > Don't consider this as a bug. It was a feature request for change by > Olivier, and not a bug. > I closed both issues years ago but not because of ignorance but because the > appearance of the exceptional behavior is

Re: issues with the user property "maven.test.failure.ignore" and new proposals

@Tibor: I never said it was a bug, my point is that you never needs it so we should keep that deprecated/not recommended and enable people having too constrained env to work on it through a SPI as proposed by Guillaume. So proposal was to drop that property support and add a SPI if anyone think

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Just wondering but maybe it would be better to configure the severity instead of a true/false, something like: maven.test.failure=WARN maven.test.error=ERROR would only warn about failing tests but thrw exception if starting the test fails? Am 14.03.22 um 10:52 schrieb Tibor Digana:

Re: issues with the user property "maven.test.failure.ignore" and new proposals

Romain, it is not a bug. Don't consider this as a bug. It was a feature request for change by Olivier, and not a bug. I closed both issues years ago but not because of ignorance but because the appearance of the exceptional behavior is a wrong compromise and which does not help anyone and even it

Re: issues with the user property "maven.test.failure.ignore" and new proposals

+1 if it is to investigate a CI issue, it is generally easy to add debug insights (by code or agent) so a SPI sounds like the sanest for the plugin to me. Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: issues with the user property "maven.test.failure.ignore" and new proposals

If that's not currently possible, maybe a SPI should be provided so that people can use plug in extensions to analyze the test result and override it if necessary (transforming an error into a warning, storing results in a way which is easier to use by other tools later...) ? Guillaume Le lun.

Re: issues with the user property "maven.test.failure.ignore" and new proposals

I also agree that the test at least should run, we use this property to run the test and produce result and later on have a buildstep that analyze the results (and probably fail the build job). As it is not recommend, I wonder what is the recommended way to archive something similar? Am

Re: issues with the user property "maven.test.failure.ignore" and new proposals

On Mon, 14 Mar 2022 at 11:55, Tibor Digana wrote: > In case of the user property *maven.test.failure.ignore* the MOJO must not > throw any exception which is interpreted by the Maven Core as BUILD > SUCCESS. > This is a very simple reduction of the problem description. The documentation here

issues with the user property "maven.test.failure.ignore" and new proposals

In case of the user property *maven.test.failure.ignore* the MOJO must not throw any exception which is interpreted by the Maven Core as BUILD SUCCESS. We have received an internal requirement to change the behavior of the user property *maven.test.failure.ignore* so that the behavior will have