RE: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java

2008-03-16 Thread Brian E. Fox
>Frankly, I think you should have given Nicolas the benefit of the >doubt before charging forth to rollback his commit, and just asked the >question here like I did in February when I had a suggestion about the >original implementation. Given that the change amounted to about 3 lines of code

Re: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java

2008-03-16 Thread Brett Porter
On 17/03/2008, at 9:49 AM, Brian E. Fox wrote: Not that it's entirely relevant, but making the assumption this is archiva motivated is not completely out of the blue. The unit test mentions archiva, the jira mentions archiva, the only site docs I noticed being updated showed how this was used w

RE: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java

2008-03-16 Thread Brian E. Fox
maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java Jason, Saying that this commit is Archiva-motivated is an incorrect rush to judgment and is insulting. Unprovoked and inacc

Re: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java

2008-03-15 Thread Jason van Zyl
On 15-Mar-08, at 9:35 PM, Joakim Erdfelt wrote: Jason, Saying that this commit is Archiva-motivated is an incorrect rush to judgment and is insulting. Nico, what was your motivation for the change? You can clarify as I obviously rushed to judgement assuming it was something you specifi

Re: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java

2008-03-15 Thread Joakim Erdfelt
Jason, Saying that this commit is Archiva-motivated is an incorrect rush to judgment and is insulting. Unprovoked and inaccurate attacks against members of the committer pool are also unhealthy to the community at large. Brian's concerns about this change are valid as is, and need to be addr

Re: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java

2008-03-15 Thread Jason van Zyl
I also thought this was a little sketchy and is why I don't like the cross project commit privs because people think it's just ok to do this kind of thing. Due to a limitation in Archiva not being able to deal with a single URL (which the other repositories managers don't have a problem wit

re: svn commit: r630789 - in /maven/artifact/trunk/src: main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java

2008-03-15 Thread Brian E. Fox
I'm -1 on this commit for several reasons: First and foremost, there was no proposal on the wiki or any discussion on the dev list that I can see for this. Second, the use case is not very clear and implementation questionable. If this functionality is needed for some reason, it should be br