Re: svn commit: r775049 - in /maven/plugins/trunk/maven-checkstyle-plugin: ./ src/main/java/org/apache/maven/plugin/checkstyle/ src/main/resources/config/ src/test/java/org/apache/maven/plugin/check

2009-05-31 Thread nicolas de loof
I've reverted the trunk to pre-MCHECKSTYLE-105. I'll review this patch according to the issues detected in a dedicated java5 branch. Should I set version to 3.0 in this branch to show the breaking change with 2.x versions due to java5 requirement ? Nicolas 2009/5/30 nicolas de loof

Re: svn commit: r775049 - in /maven/plugins/trunk/maven-checkstyle-plugin: ./ src/main/java/org/apache/maven/plugin/checkstyle/ src/main/resources/config/ src/test/java/org/apache/maven/plugin/check

2009-05-31 Thread Benjamin Bentmann
nicolas de loof wrote: I've reverted the trunk to pre-MCHECKSTYLE-105. Thanks. Should I set version to 3.0 in this branch to show the breaking change with 2.x versions due to java5 requirement ? IMHO, a minor increment would suffice. For users already building with Java 1.5, the change

Re: svn commit: r775049 - in /maven/plugins/trunk/maven-checkstyle-plugin: ./ src/main/java/org/apache/maven/plugin/checkstyle/ src/main/resources/config/ src/test/java/org/apache/maven/plugin/check

2009-05-31 Thread nicolas de loof
I've also deployed a 2.3 SNAPSHOT (2.3-20090531.103812-3), hope this will fix issues on dependending projects 2009/5/31 Benjamin Bentmann benjamin.bentm...@udo.edu nicolas de loof wrote: I've reverted the trunk to pre-MCHECKSTYLE-105. Thanks. Should I set version to 3.0 in this branch

Re: svn commit: r775049 - in /maven/plugins/trunk/maven-checkstyle-plugin: ./ src/main/java/org/apache/maven/plugin/checkstyle/ src/main/resources/config/ src/test/java/org/apache/maven/plugin/check

2009-05-30 Thread nicolas de loof
Sory, I missed time to follow this thread, thanks to benjamin for the ping. I applied MCHECKSTYLE-105 patch as is and did not detect the breacking changes, it can be rollbacked - I will check MCHECKSTYLE-101later. Following the thread about plugin and Java5 I've created a branch for checkstyle

Re: svn commit: r775049 - in /maven/plugins/trunk/maven-checkstyle-plugin: ./ src/main/java/org/apache/maven/plugin/checkstyle/ src/main/resources/config/ src/test/java/org/apache/maven/plugin/check

2009-05-22 Thread Mark Hobson
2009/5/20 Mark Hobson markhob...@gmail.com: Just noticed this thread after posting a proposed solution to mojo-dev: http://markmail.org/message/qnipbser4hktewvq I've fixed this in mojo-parent, do you want me to also apply the fix to maven-parent and deploy a new snapshot? Mark

Re: svn commit: r775049 - in /maven/plugins/trunk/maven-checkstyle-plugin: ./ src/main/java/org/apache/maven/plugin/checkstyle/ src/main/resources/config/ src/test/java/org/apache/maven/plugin/check

2009-05-20 Thread Mark Hobson
2009/5/20 Paul Gier pg...@redhat.com: This change [1] breaks the site generation for a lot of projects.  Specifically, the checkstyle plugin config in the maven parent pom depends on the file maven_checks.xml in trunk of the checkstyle plugin.  This should probably be changed in the parent pom