dependabot[bot] commented on pull request #33:
URL: https://github.com/apache/maven-doxia/pull/33#issuecomment-645397266
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR and I'll
elharo merged pull request #22:
URL: https://github.com/apache/maven-doxia/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo commented on pull request #32:
URL: https://github.com/apache/maven-doxia/pull/32#issuecomment-645607012
apache incompatible
This is an automated message from the Apache Git Service.
To respond to the message, please
elharo merged pull request #34:
URL: https://github.com/apache/maven-doxia/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo opened a new pull request #34:
URL: https://github.com/apache/maven-doxia/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elharo closed pull request #21:
URL: https://github.com/apache/maven-doxia/pull/21
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo commented on pull request #21:
URL: https://github.com/apache/maven-doxia/pull/21#issuecomment-645609968
not java 7 compatible
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] commented on pull request #21:
URL: https://github.com/apache/maven-doxia/pull/21#issuecomment-645609984
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR and I'll
elharo merged pull request #23:
URL: https://github.com/apache/maven-doxia/pull/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo closed pull request #32:
URL: https://github.com/apache/maven-doxia/pull/32
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] commented on pull request #32:
URL: https://github.com/apache/maven-doxia/pull/32#issuecomment-645607024
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR and I'll
elharo merged pull request #8:
URL: https://github.com/apache/maven-doxia-site/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
elharo opened a new pull request #9:
URL: https://github.com/apache/maven-doxia-site/pull/9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
elharo commented on pull request #9:
URL: https://github.com/apache/maven-doxia-site/pull/9#issuecomment-646611368
[2020-06-18T19:36:57.967Z] [ERROR] The build could not read 1 project ->
[Help 1]
[2020-06-18T19:36:57.967Z] [ERROR]
[2020-06-18T19:36:57.967Z] [ERROR] The project
slachiewicz commented on pull request #9:
URL: https://github.com/apache/maven-doxia-site/pull/9#issuecomment-646621708
Interesting, because here we have definition for snapshots
(https://github.com/apache/maven-doxia-site/blob/a74c6e351af682aea3cecfaa866243de4dd7f82c/pom.xml#L162)
with
slachiewicz edited a comment on pull request #9:
URL: https://github.com/apache/maven-doxia-site/pull/9#issuecomment-646621708
Interesting, because here we have definition for snapshots
asfgit merged pull request #9:
URL: https://github.com/apache/maven-doxia-site/pull/9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
abelsromero commented on pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#issuecomment-651269972
Applied the suggestions tried to keep commit history clean.
- Squashed test change in Test commit
- Added new commit for Doxia's JavaDoc review
abelsromero commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447219577
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java
##
@@ -100,7 +98,7 @@
private boolean validate =
abelsromero commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447224575
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
##
@@ -179,15 +178,32 @@ protected File getBasedir()
abelsromero commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447224915
##
File path: doxia-core/src/main/java/org/apache/maven/doxia/Doxia.java
##
@@ -41,24 +41,35 @@
* Parses the given source model using a parser
elharo commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447236450
##
File path: doxia-core/src/main/java/org/apache/maven/doxia/Doxia.java
##
@@ -52,6 +52,22 @@
void parse( Reader source, String parserId, Sink sink
elharo commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447151457
##
File path: doxia-core/src/main/java/org/apache/maven/doxia/Doxia.java
##
@@ -41,24 +41,35 @@
* Parses the given source model using a parser with
abelsromero commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447219577
##
File path:
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java
##
@@ -100,7 +98,7 @@
private boolean validate =
abelsromero commented on pull request #5:
URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-651344760
> I'm not in favor of removing doxia-logging: deprecating and modifying it
to use slf4j would be more compatible
> I know there are not so much Doxia extensions in the
dependabot[bot] opened a new pull request #21:
URL: https://github.com/apache/maven-doxia/pull/21
Bumps [flexmark-all](https://github.com/vsch/flexmark-java) from 0.42.14 to
0.62.2.
Commits
dependabot[bot] opened a new pull request #26:
URL: https://github.com/apache/maven-doxia/pull/26
Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.3 to 2.7.0.
Release notes
Sourced from https://github.com/xmlunit/xmlunit/releases;>xmlunit-core's
releases.
dependabot[bot] opened a new pull request #24:
URL: https://github.com/apache/maven-doxia/pull/24
Bumps ant-apache-regexp from 1.7.1 to 1.10.8.
[![Dependabot compatibility
dependabot[bot] opened a new pull request #29:
URL: https://github.com/apache/maven-doxia/pull/29
Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from
3.1.0 to 3.3.0.
Commits
dependabot[bot] opened a new pull request #27:
URL: https://github.com/apache/maven-doxia/pull/27
Bumps
[plexus-component-annotations](https://github.com/codehaus-plexus/plexus-containers)
from 1.7.1 to 2.1.0.
Changelog
Sourced from
dependabot[bot] opened a new pull request #22:
URL: https://github.com/apache/maven-doxia/pull/22
Bumps httpcore from 4.4.11 to 4.4.13.
[![Dependabot compatibility
dependabot[bot] opened a new pull request #25:
URL: https://github.com/apache/maven-doxia/pull/25
Bumps
[plexus-container-default](https://github.com/codehaus-plexus/plexus-containers)
from 1.7.1 to 2.1.0.
Changelog
Sourced from
dependabot[bot] opened a new pull request #28:
URL: https://github.com/apache/maven-doxia/pull/28
Bumps fop from 2.4 to 2.5.
[![Dependabot compatibility
dependabot[bot] opened a new pull request #23:
URL: https://github.com/apache/maven-doxia/pull/23
Bumps httpclient from 4.5.8 to 4.5.12.
[![Dependabot compatibility
dependabot[bot] opened a new pull request #30:
URL: https://github.com/apache/maven-doxia/pull/30
Bumps xalan from 2.7.1 to 2.7.2.
[![Dependabot compatibility
elharo commented on a change in pull request #176:
URL: https://github.com/apache/maven-site/pull/176#discussion_r439823779
##
File path: content/markdown/docs/history.md.vm
##
@@ -93,6 +93,22 @@ Date format is: -MM-DD
#release( "2013-10-04" "3.1.1"
elharo merged pull request #30:
URL: https://github.com/apache/maven-doxia/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo merged pull request #29:
URL: https://github.com/apache/maven-doxia/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] commented on pull request #24:
URL: https://github.com/apache/maven-doxia/pull/24#issuecomment-644768174
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR and I'll
asfgit closed pull request #24:
URL: https://github.com/apache/maven-doxia/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo merged pull request #27:
URL: https://github.com/apache/maven-doxia/pull/27
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
asfgit closed pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elharo opened a new pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32
@slachiewicz Dependabot seems to be working well on the parent repos. Let's
try it here.
This is an automated message from the
olamy commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647455416
OMG another spam generator
This is an automated message from the Apache Git Service.
To respond to the
michael-o commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647470345
I have a huge problem with these PRs: no one create JIRA issues for these...
This is an automated
elharo commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647508322
Latest communication from @rfscholte was that dependency upgrades should
just happen without JIRA issues. I'm inclined to agree, but if the community
decides we must have
michael-o edited a comment on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647470345
I have a huge problem with these PRs: no one creates JIRA issues for these...
This is an
elharo opened a new pull request #8:
URL: https://github.com/apache/maven-doxia-site/pull/8
to https
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
abelsromero opened a new pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35
There's still a thing to fix with test begin discussed in
https://issues.apache.org/jira/browse/DOXIA-614.
Other than that, the changes are all done and the tests pass. I tried to
minimize
elharo commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r446678771
##
File path: doxia-core/src/test/java/org/apache/maven/doxia/DefaultDoxiaTest.java
##
@@ -0,0 +1,54 @@
+package org.apache.maven.doxia;
+
+/*
+ *
abelsromero commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r446685351
##
File path: doxia-core/src/main/java/org/apache/maven/doxia/Doxia.java
##
@@ -52,6 +52,22 @@
void parse( Reader source, String parserId, Sink
hboutemy commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647613135
> If there are accepted conventions for code commits, it would be worth
investing some time to enforce in our systems.
implementing is just one line in .asf.yaml:
elharo opened a new pull request #174:
URL: https://github.com/apache/maven-site/pull/174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elharo merged pull request #174:
URL: https://github.com/apache/maven-site/pull/174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elharo opened a new pull request #175:
URL: https://github.com/apache/maven-site/pull/175
@suztomo
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo opened a new pull request #13:
URL: https://github.com/apache/maven-artifact-transfer/pull/13
Deliberately did not file a JIRA issue for this per latest communication
from project lead
This is an automated message
elharo merged pull request #13:
URL: https://github.com/apache/maven-artifact-transfer/pull/13
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo opened a new pull request #14:
URL: https://github.com/apache/maven-artifact-transfer/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo merged pull request #14:
URL: https://github.com/apache/maven-artifact-transfer/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
olamy commented on pull request #13:
URL:
https://github.com/apache/maven-artifact-transfer/pull/13#issuecomment-640130752
**NO NEED OF PR FOR THIS**
This is an automated message from the Apache Git Service.
To respond to
slachiewicz opened a new pull request #15:
URL: https://github.com/apache/maven-artifact-transfer/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
elharo commented on a change in pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434760284
##
File path: src/it/projects/MSITE-856/src/site/site.xml
##
@@ -0,0 +1,30 @@
+
+
+
+
+http://maven.apache.org/DECORATION/1.6.0;
+
jonvolfson commented on a change in pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434688818
##
File path: src/main/java/org/apache/maven/plugins/site/render/SiteMap.java
##
@@ -172,9 +172,13 @@ private static void extractItems( List
jonvolfson commented on a change in pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434863055
##
File path: src/it/projects/MSITE-856/verify.bsh
##
@@ -0,0 +1,48 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
project. In order to remove all doubt, this page only applies to code
+ which has a Github URL that starts with
+ <<<https://github.com/apache/maven>>> or a Gitbox URL
+ starting with <<<https://git-wip-us.apache.org/repos/asf/maven>>>
Review comment:
elharo opened a new pull request #173:
URL: https://github.com/apache/maven-site/pull/173
@rfscholte use Github
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kwin opened a new pull request #16:
URL: https://github.com/apache/maven-artifact-transfer/pull/16
The checksums are generated in aether/maven-resolver
This is an automated message from the Apache Git Service.
To respond to
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642617311
I wonder whether this could affect older Maven versions which update to a
plugin with this shared component version.
elharo merged pull request #6:
URL: https://github.com/apache/maven-reporting-exec/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642647582
Makes sense. I'll run all tests on Jenkins. @rfscholte @khmarbaise opinions?
This is an
elharo merged pull request #2:
URL: https://github.com/apache/maven-reporting-exec/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kwin commented on pull request #16:
URL:
https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642622795
The relevant IT is executed with Maven 3.0.5 and newer
elharo merged pull request #3:
URL: https://github.com/apache/maven-reporting-exec/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elharo opened a new pull request #3:
URL: https://github.com/apache/maven-reporting-exec/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo opened a new pull request #5:
URL: https://github.com/apache/maven-reporting-exec/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo opened a new pull request #2:
URL: https://github.com/apache/maven-reporting-exec/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo opened a new pull request #4:
URL: https://github.com/apache/maven-reporting-exec/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo opened a new pull request #6:
URL: https://github.com/apache/maven-reporting-exec/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo merged pull request #5:
URL: https://github.com/apache/maven-reporting-exec/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elharo commented on pull request #3:
URL:
https://github.com/apache/maven-reporting-exec/pull/3#issuecomment-642632642
For test code it probably doesn't matter, but in general that's not a good
idea. Collections.singletonList violates the Liskov Substitution Principle.
This is a common
elharo merged pull request #4:
URL: https://github.com/apache/maven-reporting-exec/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elharo commented on pull request #4:
URL:
https://github.com/apache/maven-reporting-exec/pull/4#issuecomment-642675049
On further investigation, it looks like we can completely remove the
velocity dependence.
This is an
rfscholte commented on pull request #16:
URL:
https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642837228
It confirms my expectations: checksums are indeed generated by
Aether/Artifact Resolver and not anymore required in the plugins or
artifact-transfer.
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642842341
So we are good to merge here...?
This is an automated message from the Apache Git Service.
To
asfgit closed pull request #16:
URL: https://github.com/apache/maven-artifact-transfer/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
elharo opened a new pull request #176:
URL: https://github.com/apache/maven-site/pull/176
Pushed for discussion
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Tibor17 commented on pull request #176:
URL: https://github.com/apache/maven-site/pull/176#issuecomment-643656541
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
elharo commented on a change in pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434153263
##
File path: src/it/projects/MSITE-856/pom.xml
##
@@ -0,0 +1,69 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0;
jonvolfson opened a new pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jonvolfson commented on pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#issuecomment-637769611
@elharo @bimargulies
This is an automated message from the Apache Git Service.
To respond to the
asfgit closed pull request #15:
URL: https://github.com/apache/maven-artifact-transfer/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Tibor17 removed a comment on pull request #176:
URL: https://github.com/apache/maven-site/pull/176#issuecomment-643656541
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
suztomo commented on a change in pull request #176:
URL: https://github.com/apache/maven-site/pull/176#discussion_r439793731
##
File path: content/markdown/docs/history.md.vm
##
@@ -93,6 +93,22 @@ Date format is: -MM-DD
#release( "2013-10-04" "3.1.1"
elharo opened a new pull request #183:
URL: https://github.com/apache/maven-site/pull/183
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
elharo merged pull request #182:
URL: https://github.com/apache/maven-site/pull/182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
edburns opened a new pull request #184:
URL: https://github.com/apache/maven-site/pull/184
…ic in addition to text.
modified:
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
- When reading "A, B, and C are defined as A -> B -> C -> D 2.0 and A ->
mkarg commented on pull request #184:
URL: https://github.com/apache/maven-site/pull/184#issuecomment-663903450
> Can you squash this into a single commit? Thanks.
Why should he invest time into doing that? Any committer can simply click on
that green arrow button to do that *on the
elharo closed pull request #36:
URL: https://github.com/apache/maven-doxia/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
slachiewicz commented on pull request #33:
URL: https://github.com/apache/maven-site-plugin/pull/33#issuecomment-665078752
please put a surefire version in a commit message - it will be easier to see
that has changed in this commit (without looking into diff)
elharo opened a new pull request #33:
URL: https://github.com/apache/maven-site-plugin/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
401 - 500 of 1543 matches
Mail list logo
