[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-854121719 Note to myself: I'd do one more thing in this PR: move out things into own packages (the "provider" ones), as currently all I did is just move out things in their

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-854119930 @slachiewicz cool, thanks for testing, maybe drop here some more plugins that use m-a-t and have nice IT suite, so I could test some of those as well... -- This

[GitHub] [maven-artifact-transfer] cstamas edited a comment on pull request #24: [MSHARED-987] Make use of SISU

cstamas edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-854121719 Note to myself: I'd do one more thing in this PR: move out things into own packages (the "provider" ones), as currently all I did is just move out things in

[GitHub] [maven-artifact-transfer] cstamas edited a comment on pull request #24: [MSHARED-987] Make use of SISU

cstamas edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-854121719 Note to myself: I'd do one more thing in this PR: move out things into own packages (the "provider" ones), as currently all I did is just move out things in

[GitHub] [maven-artifact-transfer] cstamas edited a comment on pull request #24: [MSHARED-987] Make use of SISU

cstamas edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-854121719 Note to myself: I'd do one more thing in this PR: move out things into own packages (the "provider" ones), as currently all I did is just move out things in

[GitHub] [maven-artifact-transfer] cstamas edited a comment on pull request #24: [MSHARED-987] Make use of SISU

cstamas edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-854121719 Note to myself: I'd do one more thing in this PR: move out things into own packages (the "provider" ones), as currently all I did is just move out things in

[GitHub] [maven-doxia] elharo merged pull request #64: remove unused code

elharo merged pull request #64: URL: https://github.com/apache/maven-doxia/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [maven-doxia] elharo closed pull request #67: Bump commons-text from 1.3 to 1.9

elharo closed pull request #67: URL: https://github.com/apache/maven-doxia/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #51: Bump jettyVersion from 9.2.29.v20191105 to 11.0.3

dependabot[bot] commented on pull request #51: URL: https://github.com/apache/maven-site-plugin/pull/51#issuecomment-854228833 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases

[GitHub] [maven-site-plugin] asfgit closed pull request #51: Bump jettyVersion from 9.2.29.v20191105 to 11.0.3

asfgit closed pull request #51: URL: https://github.com/apache/maven-site-plugin/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request #56: Bump doxiaSitetoolsVersion from 1.9.2 to 1.10

dependabot[bot] opened a new pull request #56: URL: https://github.com/apache/maven-site-plugin/pull/56 Bumps `doxiaSitetoolsVersion` from 1.9.2 to 1.10. Updates `doxia-decoration-model` from 1.9.2 to 1.10 Commits

[GitHub] [maven-site] dependabot[bot] opened a new pull request #243: Bump doxiaToolsVersion from 1.9.2 to 1.10

dependabot[bot] opened a new pull request #243: URL: https://github.com/apache/maven-site/pull/243 Bumps `doxiaToolsVersion` from 1.9.2 to 1.10. Updates `doxia-decoration-model` from 1.9.2 to 1.10 Commits

[GitHub] [maven-site] dependabot[bot] opened a new pull request #241: Bump doxiaVersion from 1.9.1 to 1.10

dependabot[bot] opened a new pull request #241: URL: https://github.com/apache/maven-site/pull/241 Bumps `doxiaVersion` from 1.9.1 to 1.10. Updates `doxia-sink-api` from 1.9.1 to 1.10 Commits

[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #53: Bump jettyVersion from 9.2.29.v20191105 to 11.0.5

dependabot[bot] commented on pull request #53: URL: https://github.com/apache/maven-site-plugin/pull/53#issuecomment-871972627 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases

[GitHub] [maven-site-plugin] asfgit closed pull request #53: Bump jettyVersion from 9.2.29.v20191105 to 11.0.5

asfgit closed pull request #53: URL: https://github.com/apache/maven-site-plugin/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] asfgit closed pull request #241: Bump doxiaVersion from 1.9.1 to 1.10

asfgit closed pull request #241: URL: https://github.com/apache/maven-site/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site-plugin] asfgit closed pull request #56: Bump doxiaSitetoolsVersion from 1.9.2 to 1.10

asfgit closed pull request #56: URL: https://github.com/apache/maven-site-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #56: Bump doxiaSitetoolsVersion from 1.9.2 to 1.10

dependabot[bot] commented on pull request #56: URL: https://github.com/apache/maven-site-plugin/pull/56#issuecomment-871988731 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases

[GitHub] [maven-site-plugin] dependabot[bot] commented on pull request #55: Bump doxiaVersion from 1.9.1 to 1.10

dependabot[bot] commented on pull request #55: URL: https://github.com/apache/maven-site-plugin/pull/55#issuecomment-871988521 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases

[GitHub] [maven-site-plugin] asfgit closed pull request #55: Bump doxiaVersion from 1.9.1 to 1.10

asfgit closed pull request #55: URL: https://github.com/apache/maven-site-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] dependabot[bot] commented on pull request #243: Bump doxiaToolsVersion from 1.9.2 to 1.10

dependabot[bot] commented on pull request #243: URL: https://github.com/apache/maven-site/pull/243#issuecomment-871968677 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

[GitHub] [maven-site] dependabot[bot] commented on pull request #241: Bump doxiaVersion from 1.9.1 to 1.10

dependabot[bot] commented on pull request #241: URL: https://github.com/apache/maven-site/pull/241#issuecomment-871968619 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

[GitHub] [maven-site] slachiewicz closed pull request #243: Bump doxiaToolsVersion from 1.9.2 to 1.10

slachiewicz closed pull request #243: URL: https://github.com/apache/maven-site/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] elharo merged pull request #242: docs: minor cleanup

elharo merged pull request #242: URL: https://github.com/apache/maven-site/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] elharo opened a new pull request #244: docs: rewrite More Project Information

elharo opened a new pull request #244: URL: https://github.com/apache/maven-site/pull/244 @michael-o focus on element's expected content, and in general be a little less flip and somewhat more direct -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-site] michael-o commented on pull request #240: Use an SPDX identifier in example, as recommended

michael-o commented on pull request #240: URL: https://github.com/apache/maven-site/pull/240#issuecomment-872147844 I think this is wrong. the `name` shall remain as is. In a future version of the POM we will add something for SPDX. Therefore, I'd recommend to modify the SPDX part. --

[GitHub] [maven-site-plugin] elharo merged pull request #54: Bump slf4jVersion from 1.7.29 to 1.7.31

elharo merged pull request #54: URL: https://github.com/apache/maven-site-plugin/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] elharo opened a new pull request #245: docs: remove forward looking statement

elharo opened a new pull request #245: URL: https://github.com/apache/maven-site/pull/245 @khmarbaise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven-site] elharo merged pull request #245: docs: remove forward looking statement

elharo merged pull request #245: URL: https://github.com/apache/maven-site/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] elharo merged pull request #244: docs: rewrite More Project Information

elharo merged pull request #244: URL: https://github.com/apache/maven-site/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] rjmunro commented on pull request #240: Use an SPDX identifier in example, as recommended

rjmunro commented on pull request #240: URL: https://github.com/apache/maven-site/pull/240#issuecomment-872241122 @michael-o I think it would make sense to re-write the docs when a SPDX field is added, but right now, the docs say to put SPDX into the name, but then don't actually do it.

[GitHub] [maven-site] michael-o commented on pull request #240: Use an SPDX identifier in example, as recommended

michael-o commented on pull request #240: URL: https://github.com/apache/maven-site/pull/240#issuecomment-872241943 > > > @michael-o I think it would make sense to re-write the docs when a SPDX field is added, but right now, the docs say to put SPDX into the name, but then don't

[GitHub] [maven-site] elharo commented on a change in pull request #240: Use an SPDX identifier in example, as recommended

elharo commented on a change in pull request #240: URL: https://github.com/apache/maven-site/pull/240#discussion_r662193689 ## File path: content/apt/pom.apt ## @@ -1474,10 +1474,10 @@ Display parameters as parsed by Maven (in canonical form) and comparison result:

[GitHub] [maven-site] elharo opened a new pull request #242: docs: minor cleanup

elharo opened a new pull request #242: URL: https://github.com/apache/maven-site/pull/242 @michael-o omit needless words -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-site] pat-lego opened a new pull request #246: Adding .mavenrc documentation

pat-lego opened a new pull request #246: URL: https://github.com/apache/maven-site/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site] michael-o commented on a change in pull request #246: Adding .mavenrc documentation

michael-o commented on a change in pull request #246: URL: https://github.com/apache/maven-site/pull/246#discussion_r668139207 ## File path: content/markdown/configure.md ## @@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request #57: Bump jettyVersion from 9.2.29.v20191105 to 11.0.6

dependabot[bot] opened a new pull request #57: URL: https://github.com/apache/maven-site-plugin/pull/57 Bumps `jettyVersion` from 9.2.29.v20191105 to 11.0.6. Updates `jetty-server` from 9.2.29.v20191105 to 11.0.6 Release notes Sourced from

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

michael-o commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r620052947 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -118,17 +118,14 @@ public void doFilter( ServletRequest

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

michael-o commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r620052947 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -118,17 +118,14 @@ public void doFilter( ServletRequest

[GitHub] [maven-site-plugin] elharo commented on pull request #42: Bump wagonVersion from 3.3.1 to 3.4.3

elharo commented on pull request #42: URL: https://github.com/apache/maven-site-plugin/pull/42#issuecomment-826632538 [main] ERROR org.sonatype.guice.bean.reflect.NamedClass - Error injecting: org.apache.maven.wagon.providers.webdav.WebDavWagon java.lang.NoClassDefFoundError: Could not

[GitHub] [maven-site-plugin] qualitesys commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

qualitesys commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r619859807 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -114,6 +116,8 @@ public void doFilter( ServletRequest

[GitHub] [maven-site-plugin] elharo merged pull request #47: Bump plexus-archiver from 4.2.4 to 4.2.5

elharo merged pull request #47: URL: https://github.com/apache/maven-site-plugin/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r619700755 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -114,6 +116,8 @@ public void doFilter( ServletRequest

[GitHub] [maven-site-plugin] qualitesys commented on pull request #48: [MSITE-872] Set the Content-Type header

qualitesys commented on pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#issuecomment-826562224 Tests are needed : I need to first start the jetty server (mvn site:run) then make a simple GET http call, then stop the jetty server. Is there a similar Integration

[GitHub] [maven-site-plugin] elharo commented on pull request #48: [MSITE-872] Set the Content-Type header

elharo commented on pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#issuecomment-826633737 I think this could be tested as a unit test that invokes the method directly and confirms the response. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-doxia] qualitesys opened a new pull request #61: [DOXIA-588] The Sink.JUSTIFY_XXX was ignored

qualitesys opened a new pull request #61: URL: https://github.com/apache/maven-doxia/pull/61 See Jira ticket https://issues.apache.org/jira/browse/DOXIA-588 Source code patch Update Unit test as well -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-site-plugin] elharo opened a new pull request #49: update wagon

elharo opened a new pull request #49: URL: https://github.com/apache/maven-site-plugin/pull/49 @rfscholte not the latest version, but the latest version for which the tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

michael-o commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r620587860 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -118,8 +118,7 @@ public void doFilter( ServletRequest

[GitHub] [maven-site-plugin] qualitesys commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

qualitesys commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r620608861 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -118,8 +118,7 @@ public void doFilter( ServletRequest

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r620644555 ## File path: src/test/java/org/apache/maven/plugins/site/run/SiteRunMSITE872Test.java ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache

[GitHub] [maven-site] lokesh090297 opened a new pull request #235: Updated one typo in pom documentation

lokesh090297 opened a new pull request #235: URL: https://github.com/apache/maven-site/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [maven-site] elharo commented on a change in pull request #235: Updated one typo in pom documentation

elharo commented on a change in pull request #235: URL: https://github.com/apache/maven-site/pull/235#discussion_r621142216 ## File path: content/apt/guides/introduction/introduction-to-the-pom.apt ## @@ -212,8 +212,8 @@ Introduction to the POM parent of our POM. And we do

[GitHub] [maven-site] elharo closed pull request #231: Maven 3.3.4

elharo closed pull request #231: URL: https://github.com/apache/maven-site/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [maven-site] elharo commented on pull request #233: [MNGSITE-449] Clarify usage of '-' for profile deactivation

elharo commented on pull request #233: URL: https://github.com/apache/maven-site/pull/233#issuecomment-827554810 running through jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-site/job/MNGSITE-449/ -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-site] elharo merged pull request #233: [MNGSITE-449] Clarify usage of '-' for profile deactivation

elharo merged pull request #233: URL: https://github.com/apache/maven-site/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-829350347 but now to "drop 3.0.x", it is simple as dropping module for 3.0.x :wink: -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #23: [MSHARED-987] Drop legacy, prepare for future

cstamas commented on pull request #23: URL: https://github.com/apache/maven-artifact-transfer/pull/23#issuecomment-829236111 Superseded by https://github.com/apache/maven-artifact-transfer/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-artifact-transfer] cstamas closed pull request #23: [MSHARED-987] Drop legacy, prepare for future

cstamas closed pull request #23: URL: https://github.com/apache/maven-artifact-transfer/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [maven-artifact-transfer] cstamas opened a new pull request #24: [MSHARED-987] Make use of SISU

cstamas opened a new pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24 https://issues.apache.org/jira/browse/MSHARED-987 Drop all the reflection hoops and loops, and organize into api-provider layout. Should have NO IMPACT on consumers. -- This

[GitHub] [maven-site-plugin] qualitesys commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

qualitesys commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r621483341 ## File path: src/test/java/org/apache/maven/plugins/site/run/SiteRunMSITE872Test.java ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-829348216 As mentioned above UTs pass OK The ITs pass, **except for maven 3.0.5**, reason: it seems it was not yet honoring "sisu index"

[GitHub] [maven-site] MartinKanters opened a new pull request #236: [MNGSITE-444] Add missing reactor documentation

MartinKanters opened a new pull request #236: URL: https://github.com/apache/maven-site/pull/236 This PR describes most of the changes to the reactor that are coming in Maven 4. @mthmulders and I also extended the existing docs. @elharo We would like to ask you for a review at

[GitHub] [maven-site] mthmulders commented on pull request #236: [MNGSITE-444] Add missing reactor documentation

mthmulders commented on pull request #236: URL: https://github.com/apache/maven-site/pull/236#issuecomment-830141468 > I would prefer no priorpritary format/application to be necessary to draw stuff. SVG is preferred or as @hboutemy did a dep over view with LO Draw. I found some .ai

[GitHub] [maven-site] michael-o commented on pull request #236: [MNGSITE-444] Add missing reactor documentation

michael-o commented on pull request #236: URL: https://github.com/apache/maven-site/pull/236#issuecomment-830131062 I would prefer no priorpritary format/application to be necessary to draw stuff. SVG is preferred or as @hboutemy did a dep over view with LO Draw. -- This is an automated

[GitHub] [maven-site] MartinKanters commented on pull request #236: [MNGSITE-444] Add missing reactor documentation

MartinKanters commented on pull request #236: URL: https://github.com/apache/maven-site/pull/236#issuecomment-830636724 @elharo @hboutemy Thanks for your feedback! I've processed all points. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-site] MartinKanters commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

MartinKanters commented on a change in pull request #236: URL: https://github.com/apache/maven-site/pull/236#discussion_r624514244 ## File path: content/apt/guides/mini/guide-multiple-modules.apt ## @@ -59,25 +75,117 @@ Guide to Working with Multiple Modules Note that

[GitHub] [maven-site] elharo commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

elharo commented on a change in pull request #236: URL: https://github.com/apache/maven-site/pull/236#discussion_r624241259 ## File path: content/apt/guides/mini/guide-multiple-modules.apt ## @@ -37,11 +39,25 @@ Guide to Working with Multiple Modules * Collects all the

[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

hboutemy commented on a change in pull request #236: URL: https://github.com/apache/maven-site/pull/236#discussion_r624361148 ## File path: content/apt/guides/mini/guide-multiple-modules.apt ## @@ -37,11 +39,25 @@ Guide to Working with Multiple Modules * Collects all

[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

hboutemy commented on a change in pull request #236: URL: https://github.com/apache/maven-site/pull/236#discussion_r624361148 ## File path: content/apt/guides/mini/guide-multiple-modules.apt ## @@ -37,11 +39,25 @@ Guide to Working with Multiple Modules * Collects all

[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

hboutemy commented on a change in pull request #236: URL: https://github.com/apache/maven-site/pull/236#discussion_r624362868 ## File path: content/apt/guides/mini/guide-multiple-modules.apt ## @@ -59,25 +75,117 @@ Guide to Working with Multiple Modules Note that only

[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

hboutemy commented on a change in pull request #236: URL: https://github.com/apache/maven-site/pull/236#discussion_r624362541 ## File path: content/apt/guides/mini/guide-multiple-modules.apt ## @@ -59,25 +75,117 @@ Guide to Working with Multiple Modules Note that only

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #27: Bump maven-artifact from 3.0 to 3.8.1

dependabot[bot] opened a new pull request #27: URL: https://github.com/apache/maven-artifact-transfer/pull/27 Bumps [maven-artifact](https://github.com/apache/maven) from 3.0 to 3.8.1. Commits

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #28: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0

dependabot[bot] opened a new pull request #28: URL: https://github.com/apache/maven-artifact-transfer/pull/28 Bumps [maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters) from 3.1.0 to 3.2.0. Commits

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #25: Bump aether-util from 0.9.0.M2 to 1.1.0

dependabot[bot] opened a new pull request #25: URL: https://github.com/apache/maven-artifact-transfer/pull/25 Bumps aether-util from 0.9.0.M2 to 1.1.0. [![Dependabot compatibility

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #26: Bump aether-api from 0.9.0.M2 to 1.1.0

dependabot[bot] opened a new pull request #26: URL: https://github.com/apache/maven-artifact-transfer/pull/26 Bumps aether-api from 0.9.0.M2 to 1.1.0. [![Dependabot compatibility

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #25: Bump aether-util from 0.9.0.M2 to 1.1.0

dependabot[bot] commented on pull request #25: URL: https://github.com/apache/maven-artifact-transfer/pull/25#issuecomment-830804164 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR

[GitHub] [maven-artifact-transfer] asfgit closed pull request #25: Bump aether-util from 0.9.0.M2 to 1.1.0

asfgit closed pull request #25: URL: https://github.com/apache/maven-artifact-transfer/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [maven-artifact-transfer] asfgit closed pull request #28: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0

asfgit closed pull request #28: URL: https://github.com/apache/maven-artifact-transfer/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #28: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0

dependabot[bot] commented on pull request #28: URL: https://github.com/apache/maven-artifact-transfer/pull/28#issuecomment-830804334 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #29: Bump aether-impl from 1.7 to 1.13.1

dependabot[bot] opened a new pull request #29: URL: https://github.com/apache/maven-artifact-transfer/pull/29 Bumps [aether-impl](https://github.com/sonatype/sonatype-aether) from 1.7 to 1.13.1. Commits

[GitHub] [maven-artifact-transfer] asfgit closed pull request #26: Bump aether-api from 0.9.0.M2 to 1.1.0

asfgit closed pull request #26: URL: https://github.com/apache/maven-artifact-transfer/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #27: Bump maven-artifact from 3.0 to 3.8.1

dependabot[bot] commented on pull request #27: URL: https://github.com/apache/maven-artifact-transfer/pull/27#issuecomment-830803947 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR

[GitHub] [maven-artifact-transfer] asfgit closed pull request #27: Bump maven-artifact from 3.0 to 3.8.1

asfgit closed pull request #27: URL: https://github.com/apache/maven-artifact-transfer/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #29: Bump aether-impl from 1.7 to 1.13.1

dependabot[bot] commented on pull request #29: URL: https://github.com/apache/maven-artifact-transfer/pull/29#issuecomment-830803994 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR

[GitHub] [maven-artifact-transfer] asfgit closed pull request #29: Bump aether-impl from 1.7 to 1.13.1

asfgit closed pull request #29: URL: https://github.com/apache/maven-artifact-transfer/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #26: Bump aether-api from 0.9.0.M2 to 1.1.0

dependabot[bot] commented on pull request #26: URL: https://github.com/apache/maven-artifact-transfer/pull/26#issuecomment-830804047 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR

[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734274 ## File path: maven-artifact-transfer/pom.xml ## @@ -0,0 +1,188 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734298 ## File path: maven-artifact-transfer/pom.xml ## @@ -0,0 +1,188 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849694 Applied PR comments (sans NPE, see above why), all ITs pass except the 3.0.5 (as before, as it's sisu does not speak sisu index) -- This is an automated message

[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624730059 ## File path: maven-3.0.x/pom.xml ## @@ -0,0 +1,148 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [maven-artifact-transfer] michael-o edited a comment on pull request #24: [MSHARED-987] Make use of SISU

michael-o edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850011 Can you explain why we need `Maven302RepositoryManager` instead of just `Maven302RepositoryManager`? -- This is an automated message from the Apache

[GitHub] [maven-site-plugin] qualitesys commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

qualitesys commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r624727891 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -114,6 +117,16 @@ public void doFilter( ServletRequest

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830844133 General remark @michael-o : I did not made any other code change then: * added to methods ProjectBuildingRequest * removed reflection bits, replaced with

[GitHub] [maven-site-plugin] michael-o commented on pull request #48: [MSITE-872] Set the Content-Type header

michael-o commented on pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#issuecomment-830843997 The test looks convoluted to me. Why not fire up Jetty, and get the `Content-Type` header from response? Done. -- This is an automated message from the Apache Git

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830849772 > > > General remark @michael-o : I did not made any other code change then: > > * added ProjectBuildingRequest parameter to methods, removed

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #24: [MSHARED-987] Make use of SISU

michael-o commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830850011 Can you explain why we need `Maven302RepositoryManager? instead of just `Maven302RepositoryManager`? -- This is an automated message from the Apache Git

[GitHub] [maven-artifact-transfer] michael-o commented on a change in pull request #24: [MSHARED-987] Make use of SISU

michael-o commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624720934 ## File path: maven-3.0.x/pom.xml ## @@ -0,0 +1,148 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [maven-artifact-transfer] cstamas edited a comment on pull request #24: [MSHARED-987] Make use of SISU

cstamas edited a comment on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-830844133 General remark @michael-o : I did not made any other code change then: * added ProjectBuildingRequest parameter to methods, removed some unneeded members

[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734173 ## File path: maven-3.0.x/src/main/java/org/apache/maven/shared/transfer/repository/internal/Maven302RepositoryManager.java ## @@ -20,18

[GitHub] [maven-artifact-transfer] cstamas commented on a change in pull request #24: [MSHARED-987] Make use of SISU

cstamas commented on a change in pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#discussion_r624734205 ## File path: maven-3.1.x/pom.xml ## @@ -0,0 +1,148 @@ + + +http://maven.apache.org/POM/4.0.0;

<    4   5   6   7   8   9   10   11   12   13   >