Re: Review Request 12890: Refactored Jenkins to make resources configurable.

2013-07-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12890/#review23733 --- Ship it! jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCl

Review Request 12890: Refactored Jenkins to make resources configurable.

2013-07-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12890/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-gi

Re: Review Request 11131: Changed cgroups killTasks() sequence.

2013-07-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11131/#review23732 --- Ship it! Modulo comments below. src/linux/cgroups.cpp

Re: Review Request 12884: Fixed JenkinsScheduler to not crash when the Mesos native library is not bundled with the plugin.

2013-07-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12884/#review23731 --- Ship it! Modulo the comment below. jenkins/src/main/java/org/jenk

Re: Review Request 12847: Fixed Slave, Cloud and Retention strategy for Jenkins.

2013-07-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12847/#review23730 --- Ship it! jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCl

Re: Review Request 12846: Removed the ability to manually provision Jenkins slaves.

2013-07-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12846/#review23729 --- Ship it! Ship It! - Ben Mahler On July 23, 2013, 5:50 a.m., Vino

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1432

2013-07-23 Thread Apache Jenkins Server
See

Re: git commit: Terminate executors that aren't needed.

2013-07-23 Thread Benjamin Mahler
Hey Brenden, can you remove the '<< executor' in the line below? + CHECK(executor->launchedTasks.empty()) << executor; This will print the pointer address: ➜ scratch cat output_operator.c #include struct Executor { }; int main() { Executor* e = new Executor(); std::cout << e <

Review Request 12887: Style /browse to distinguish folders

2013-07-23 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12887/ --- Review request for mesos. Repository: mesos-git Description --- Style /b

Review Request 12888: Remove 'ui-if' direction in favor of 'ng-show'

2013-07-23 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12888/ --- Review request for mesos. Repository: mesos-git Description --- Remove '

Re: Review Request 12878: Replace popover with copy button on /slaves/:id

2013-07-23 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12878/ --- (Updated July 24, 2013, 12:11 a.m.) Review request for mesos. Changes ---

[jira] [Resolved] (MESOS-549) Change truncated IDs to show on hover

2013-07-23 Thread Ross Allen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ross Allen resolved MESOS-549. -- Resolution: Fixed Submitted via a different review due to post-reviews.py issues at the time. The final

Review Request 12885: Slave ping timeout may be increased by flags.

2013-07-23 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12885/ --- Review request for mesos. Repository: mesos-git Description --- Slave pi

Re: Review Request 11125: Terminate executors that aren't needed.

2013-07-23 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/ --- (Updated July 23, 2013, 10:54 p.m.) Review request for mesos. Changes ---

Re: Review Request 11125: Terminate executors that aren't needed.

2013-07-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/#review23724 --- Ship it! Hmm. can't see the diff for some reason, though the file i

Review Request 12884: Fixed JenkinsScheduler to not crash when the Mesos native library is not bundled with the plugin.

2013-07-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12884/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

Re: Review Request 11125: Terminate executors that aren't needed.

2013-07-23 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/ --- (Updated July 23, 2013, 10:39 p.m.) Review request for mesos. Repository: mes

Re: Review Request 11125: Terminate executors that aren't needed.

2013-07-23 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/ --- (Updated July 23, 2013, 10:36 p.m.) Review request for mesos. Changes ---

[jira] [Resolved] (MESOS-553) Jenkins plugin should bundle the native Mesos library

2013-07-23 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone resolved MESOS-553. -- Resolution: Fixed > Jenkins plugin should bundle the native Mesos library >

[jira] [Resolved] (MESOS-552) Jenkins scheduler should use the latest Mesos jar built from the repo

2013-07-23 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone resolved MESOS-552. -- Resolution: Fixed > Jenkins scheduler should use the latest Mesos jar built from the repo >

Re: Mesos Hadoop scheduler refactoring

2013-07-23 Thread Brenden Matthews
Thanks Ben! I'm working on updating these ASAP. If there's anything else I can do to expedite the process, let me know as well. Looking forward to getting this stuff squared away :) On Mon, Jul 22, 2013 at 6:05 PM, Benjamin Mahler wrote: > Great!! Looking forward to it. > > In the meantime, c

Re: Review Request 11131: Changed cgroups killTasks() sequence.

2013-07-23 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11131/ --- (Updated July 23, 2013, 9:47 p.m.) Review request for mesos. Changes ---

[jira] [Resolved] (MESOS-580) Improve Command Executor

2013-07-23 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone resolved MESOS-580. -- Resolution: Fixed > Improve Command Executor > > > Key: MES

Review Request 12880: Compute framework stats in one iteration

2013-07-23 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/ --- Review request for mesos. Repository: mesos-git Description --- Compute

Review Request 12879: Search frameworks & executors successively to save concat

2013-07-23 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12879/ --- Review request for mesos. Repository: mesos-git Description --- Search f

Review Request 12878: Replace popover with copy button on /slaves/:id

2013-07-23 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12878/ --- Review request for mesos. Repository: mesos-git Description --- Replace

Re: Review Request 12836: Moved Jenkins out of the default build path of Mesos.

2013-07-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12836/#review23709 --- Ship it! Ship It! - Benjamin Hindman On July 23, 2013, 6:49 p.m.

Re: Review Request 12876: Fixed IO.BufferedRead test to cleanup the file created by the test.

2013-07-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12876/#review23708 --- Ship it! Ship It! - Benjamin Hindman On July 23, 2013, 7:15 p.m.

Review Request 12876: Fixed IO.BufferedRead test to cleanup the file created by the test.

2013-07-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12876/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-gi

Re: Review Request 12836: Moved Jenkins out of the default build path of Mesos.

2013-07-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12836/ --- (Updated July 23, 2013, 6:49 p.m.) Review request for mesos, Benjamin Hindman a

Review Request 12847: Fixed Slave, Cloud and Retention strategy for Jenkins.

2013-07-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12847/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-gi