Re: Review Request 16149: Containerizer - launchers (part 2)

2014-01-29 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review33125 --- Hey Ian, Took your latest diff for a spin and ran into a compile

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review33127 --- Ship it! 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review33129 --- Ship it! Good stuff!

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Ian Downes
On Jan. 29, 2014, 6:34 p.m., Vinod Kone wrote: 3rdparty/libprocess/include/process/subprocess.hpp, line 124 https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line124 can we just use constants (e.g:. 29 and 3) here instead of strlen and add a note that strlen is not

[jira] [Created] (MESOS-955) Unify stats naming scheme

2014-01-29 Thread Vinod Kone (JIRA)
Vinod Kone created MESOS-955: Summary: Unify stats naming scheme Key: MESOS-955 URL: https://issues.apache.org/jira/browse/MESOS-955 Project: Mesos Issue Type: Improvement Reporter:

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-29 Thread Ben Mahler
On Jan. 29, 2014, 7:03 a.m., Benjamin Hindman wrote: src/tests/environment.cpp, line 243 https://reviews.apache.org/r/17305/diff/3/?file=453453#file453453line243 Another thought, what about getting the process tree instead and printing that if this process has children? That

Re: Review Request 17481: Fixed the use of a raw unix time in the Slave.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17481/ --- (Updated Jan. 29, 2014, 8:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-29 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review33160 --- src/webui/master/static/js/controllers.js

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-29 Thread Thomas Rampelberg
On Jan. 29, 2014, 8:39 p.m., Ross Allen wrote: src/webui/master/static/index.html, line 65 https://reviews.apache.org/r/17431/diff/11/?file=453075#file453075line65 This can lead to an odd state, although it might be fine for now: 1. Open the config and set the host to

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-29 Thread Thomas Rampelberg
On Jan. 29, 2014, 8:34 p.m., Ross Allen wrote: src/webui/master/static/js/controllers.js, line 342 https://reviews.apache.org/r/17431/diff/11/?file=453077#file453077line342 Nuke the console.log for production use. I need a pre-commit lint hook for console.log. - Thomas

Re: Review Request 17304: Added a child Reaper utility in libprocess.

2014-01-29 Thread Ben Mahler
On Jan. 29, 2014, 7:03 a.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/reap.cpp, line 79 https://reviews.apache.org/r/17304/diff/3/?file=453443#file453443line79 We had discussed this back when Yan worked on this code ... but I don't remember what we determined and there

Re: Review Request 17304: Added a child Reaper utility in libprocess.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- (Updated Jan. 29, 2014, 10:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/ --- (Updated Jan. 29, 2014, 10:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17304: Added a child Reaper utility in libprocess.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- (Updated Jan. 29, 2014, 10:38 p.m.) Review request for mesos, Benjamin

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Ben Mahler
On Jan. 29, 2014, 5:57 p.m., Jie Yu wrote: 3rdparty/libprocess/include/process/subprocess.hpp, line 184 https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line184 What about moving the these 'close' calls to the destructor of Data. In that case, you just need to do

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Ben Mahler
On Jan. 29, 2014, 6:34 p.m., Vinod Kone wrote: 3rdparty/libprocess/include/process/subprocess.hpp, line 124 https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line124 can we just use constants (e.g:. 29 and 3) here instead of strlen and add a note that strlen is not

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Ben Mahler
On Jan. 29, 2014, 7:39 a.m., Benjamin Hindman wrote: 3rdparty/libprocess/include/process/subprocess.hpp, line 37 https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line37 It is a little ironic that you went with in(), out(), err() as functions but still called the

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/ --- (Updated Jan. 29, 2014, 10:39 p.m.) Review request for mesos, Benjamin

[jira] [Assigned] (MESOS-953) default value of JSON::Value is empty string

2014-01-29 Thread Charlie Carson (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charlie Carson reassigned MESOS-953: Assignee: Charlie Carson default value of JSON::Value is empty string

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review33183 --- Ship it! 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 16724: Added completed frameworks/tasks to slave re-registration.

2014-01-29 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/ --- (Updated Jan. 29, 2014, 4:17 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/ --- (Updated Jan. 30, 2014, 12:28 a.m.) Review request for mesos, Benjamin Hindman

Review Request 17519: Added a missing lock acquisition in /__processes__.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17519/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-954

[jira] [Assigned] (MESOS-954) The /__processes__ endpoint in libprocess is missing a needed lock acquisition.

2014-01-29 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler reassigned MESOS-954: - Assignee: Benjamin Mahler The /__processes__ endpoint in libprocess is missing a needed

[jira] [Commented] (MESOS-954) The /__processes__ endpoint in libprocess is missing a needed lock acquisition.

2014-01-29 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886089#comment-13886089 ] Benjamin Mahler commented on MESOS-954: --- https://reviews.apache.org/r/17519/ The

[jira] [Commented] (MESOS-939) assignment of bool to Stout JSON::Value yields JSON::Double

2014-01-29 Thread Charlie Carson (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886099#comment-13886099 ] Charlie Carson commented on MESOS-939: -- Ok, final update - inheritance does work, it

Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-01-29 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/ --- Review request for mesos, Benjamin Hindman and Jeff Currier. Bugs:

Re: Review Request 17476: Added a Sequencer abstraction.

2014-01-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/#review33089 --- Ship it! 3rdparty/libprocess/include/process/sequencer.hpp

Re: Review Request 16724: Added completed frameworks/tasks to slave re-registration.

2014-01-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review33187 --- Ship it! src/master/master.hpp

Re: Review Request 17519: Added a missing lock acquisition in /__processes__.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17519/ --- (Updated Jan. 30, 2014, 1:10 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17476: Added a Sequencer abstraction.

2014-01-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/#review33193 --- Ship it! Ship It! - Vinod Kone On Jan. 29, 2014, 1:40 a.m., Jie

[jira] [Updated] (MESOS-943) Provide an abstraction for asynchronous launching of subprocesses.

2014-01-29 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-943: -- Fix Version/s: 0.18.0 Provide an abstraction for asynchronous launching of subprocesses.

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1860

2014-01-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/1860/changes Changes: [bmahler] Added a missing lock acquisition in /__processes__. [bmahler] Updated the semantics of Clock::resume. [bmahler] Fixed the use of a raw unix time in

Re: Review Request 17476: Added a Sequencer abstraction.

2014-01-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/ --- (Updated Jan. 30, 2014, 5:41 a.m.) Review request for mesos and Benjamin

Re: Review Request 17476: Added a Sequence abstraction.

2014-01-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/ --- (Updated Jan. 30, 2014, 5:42 a.m.) Review request for mesos and Benjamin