---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16149/#review33125
---
Hey Ian,
Took your latest diff for a spin and ran into a compile
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17306/#review33127
---
Ship it!
3rdparty/libprocess/include/process/subprocess.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17306/#review33129
---
Ship it!
Good stuff!
On Jan. 29, 2014, 6:34 p.m., Vinod Kone wrote:
3rdparty/libprocess/include/process/subprocess.hpp, line 124
https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line124
can we just use constants (e.g:. 29 and 3) here instead of strlen and
add a note that strlen is not
Vinod Kone created MESOS-955:
Summary: Unify stats naming scheme
Key: MESOS-955
URL: https://issues.apache.org/jira/browse/MESOS-955
Project: Mesos
Issue Type: Improvement
Reporter:
On Jan. 29, 2014, 7:03 a.m., Benjamin Hindman wrote:
src/tests/environment.cpp, line 243
https://reviews.apache.org/r/17305/diff/3/?file=453453#file453453line243
Another thought, what about getting the process tree instead and
printing that if this process has children? That
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17481/
---
(Updated Jan. 29, 2014, 8:27 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review33160
---
src/webui/master/static/js/controllers.js
On Jan. 29, 2014, 8:39 p.m., Ross Allen wrote:
src/webui/master/static/index.html, line 65
https://reviews.apache.org/r/17431/diff/11/?file=453075#file453075line65
This can lead to an odd state, although it might be fine for now:
1. Open the config and set the host to
On Jan. 29, 2014, 8:34 p.m., Ross Allen wrote:
src/webui/master/static/js/controllers.js, line 342
https://reviews.apache.org/r/17431/diff/11/?file=453077#file453077line342
Nuke the console.log for production use.
I need a pre-commit lint hook for console.log.
- Thomas
On Jan. 29, 2014, 7:03 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/src/reap.cpp, line 79
https://reviews.apache.org/r/17304/diff/3/?file=453443#file453443line79
We had discussed this back when Yan worked on this code ... but I don't
remember what we determined and there
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17304/
---
(Updated Jan. 29, 2014, 10:29 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17305/
---
(Updated Jan. 29, 2014, 10:30 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17304/
---
(Updated Jan. 29, 2014, 10:38 p.m.)
Review request for mesos, Benjamin
On Jan. 29, 2014, 5:57 p.m., Jie Yu wrote:
3rdparty/libprocess/include/process/subprocess.hpp, line 184
https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line184
What about moving the these 'close' calls to the destructor of Data. In
that case, you just need to do
On Jan. 29, 2014, 6:34 p.m., Vinod Kone wrote:
3rdparty/libprocess/include/process/subprocess.hpp, line 124
https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line124
can we just use constants (e.g:. 29 and 3) here instead of strlen and
add a note that strlen is not
On Jan. 29, 2014, 7:39 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/include/process/subprocess.hpp, line 37
https://reviews.apache.org/r/17306/diff/3/?file=453457#file453457line37
It is a little ironic that you went with in(), out(), err() as
functions but still called the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17306/
---
(Updated Jan. 29, 2014, 10:39 p.m.)
Review request for mesos, Benjamin
[
https://issues.apache.org/jira/browse/MESOS-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charlie Carson reassigned MESOS-953:
Assignee: Charlie Carson
default value of JSON::Value is empty string
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17306/#review33183
---
Ship it!
3rdparty/libprocess/include/process/subprocess.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16724/
---
(Updated Jan. 29, 2014, 4:17 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17306/
---
(Updated Jan. 30, 2014, 12:28 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17519/
---
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-954
[
https://issues.apache.org/jira/browse/MESOS-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Mahler reassigned MESOS-954:
-
Assignee: Benjamin Mahler
The /__processes__ endpoint in libprocess is missing a needed
[
https://issues.apache.org/jira/browse/MESOS-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886089#comment-13886089
]
Benjamin Mahler commented on MESOS-954:
---
https://reviews.apache.org/r/17519/
The
[
https://issues.apache.org/jira/browse/MESOS-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886099#comment-13886099
]
Charlie Carson commented on MESOS-939:
--
Ok, final update - inheritance does work, it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17520/
---
Review request for mesos, Benjamin Hindman and Jeff Currier.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17476/#review33089
---
Ship it!
3rdparty/libprocess/include/process/sequencer.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16724/#review33187
---
Ship it!
src/master/master.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17519/
---
(Updated Jan. 30, 2014, 1:10 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17476/#review33193
---
Ship it!
Ship It!
- Vinod Kone
On Jan. 29, 2014, 1:40 a.m., Jie
[
https://issues.apache.org/jira/browse/MESOS-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Mahler updated MESOS-943:
--
Fix Version/s: 0.18.0
Provide an abstraction for asynchronous launching of subprocesses.
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/1860/changes
Changes:
[bmahler] Added a missing lock acquisition in /__processes__.
[bmahler] Updated the semantics of Clock::resume.
[bmahler] Fixed the use of a raw unix time in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17476/
---
(Updated Jan. 30, 2014, 5:41 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17476/
---
(Updated Jan. 30, 2014, 5:42 a.m.)
Review request for mesos and Benjamin
35 matches
Mail list logo