Re: Review Request 19901: Added Termination protobuf message.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19901/#review39523 --- Patch looks great! Reviews applied: [19795, 18403, 19901] All

Re: Review Request 17567: Added External Containerizer.

2014-04-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 4, 2014, 8:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

2014-04-04 Thread Till Toenshoff
On March 31, 2014, 8:03 p.m., Vinod Kone wrote: include/mesos/mesos.proto, line 508 https://reviews.apache.org/r/17567/diff/15/?file=531795#file531795line508 does this need to be a protobuf? Till Toenshoff wrote: My idea was to adhere to our general communication scheme by

Re: Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-04 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/#review39548 --- src/slave/containerizer/launcher.cpp

Re: Review Request 20025: Rename CgroupsLauncher to LinuxLauncher

2014-04-04 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/#review39549 --- src/Makefile.am https://reviews.apache.org/r/20025/#comment71953

Re: Review Request 19180: cli: only add local bin direcotry to PATH at first through

2014-04-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19180/#review39551 --- src/cli/mesos.cpp https://reviews.apache.org/r/19180/#comment71957

Re: Review Request 20026: Support optional container set up commands and Linux namespaces.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/#review39556 --- Patch looks great! Reviews applied: [20025, 20026] All tests

[jira] [Assigned] (MESOS-1191) ProcTest unit tests flaky

2014-04-04 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Downes reassigned MESOS-1191: - Assignee: Ian Downes ProcTest unit tests flaky -

[jira] [Resolved] (MESOS-1191) ProcTest unit tests flaky

2014-04-04 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Downes resolved MESOS-1191. --- Resolution: Fixed Fix Version/s: 0.19.0 ProcTest unit tests flaky -

Re: Review Request 20025: Rename CgroupsLauncher to LinuxLauncher

2014-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/#review39557 --- Ship it! src/slave/containerizer/cgroups_launcher.cpp

Re: Review Request 19761: Added a benchmark test for Registrar which is enabled by 'make bench'.

2014-04-04 Thread Jiang Yan Xu
On April 3, 2014, 3:51 p.m., Dominic Hamon wrote: src/tests/registrar_tests.cpp, line 291 https://reviews.apache.org/r/19761/diff/2/?file=548409#file548409line291 can you inherit from Registrar_Test and just change the storage? RegistrarTest also inherits TestWithParamT but with a

[jira] [Commented] (MESOS-1190) Add make bench target for benchmark tests.

2014-04-04 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960189#comment-13960189 ] Yan Xu commented on MESOS-1190: --- https://reviews.apache.org/r/20017/ Add make bench target

Re: Review Request 19761: Added a benchmark test for Registrar which is enabled by 'make bench'.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/#review39563 --- Patch looks great! Reviews applied: [19761] All tests passed. -

Re: Review Request 20017: Added 'make bench' make target to run benchmark tests under 'src'.

2014-04-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20017/ --- (Updated April 4, 2014, 11:20 a.m.) Review request for mesos, Benjamin

Re: Review Request 19761: Added a benchmark test for Registrar which is enabled by 'make bench'.

2014-04-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/ --- (Updated April 4, 2014, 11:33 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 20017: Added 'make bench' make target to run benchmark tests under 'src'.

2014-04-04 Thread Jiang Yan Xu
On April 3, 2014, 2:39 p.m., Dominic Hamon wrote: Looks good. Have you seen https://github.com/google/benchmark /shamelessplug? Looks interesting! We should integrate it into our testing tools. - Jiang Yan --- This is an

[jira] [Commented] (MESOS-1160) Support flattening from {Try,Result} into Future.

2014-04-04 Thread Ritwik Yadav (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960265#comment-13960265 ] Ritwik Yadav commented on MESOS-1160: - I looked into this issue. There are a couple of

Re: Review Request 19762: Improved Registrar performance by using a hashset on SlaveIDs.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19762/#review39574 --- Patch looks great! Reviews applied: [19762] All tests passed. -

Re: Review Request 18600: Allowed replicated log to do auto initialization.

2014-04-04 Thread Jie Yu
On March 27, 2014, 11:38 p.m., Ben Mahler wrote: src/log/log.hpp, line 193 https://reviews.apache.org/r/18600/diff/8/?file=525771#file525771line193 Can you update the documentation? I'm a bit hesitant about having an implicit 'auto-initialize=false', since it's less

Review Request 20047: Added abstraction for calculating aggregate statistics from TimeSeries.

2014-04-04 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20047/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description

Re: Review Request 20017: Added 'make bench' make target to run benchmark tests under 'src'.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20017/#review39580 --- Patch looks great! Reviews applied: [20017] All tests passed. -

Re: Review Request 20025: Rename CgroupsLauncher to LinuxLauncher

2014-04-04 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/ --- (Updated April 4, 2014, 8:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 20025: Rename CgroupsLauncher to LinuxLauncher

2014-04-04 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/#review39592 --- Ship it! LGTM! src/slave/containerizer/cgroups_launcher.hpp

Fwd: [proposal] Annotated tags for mesos release

2014-04-04 Thread Bhuvan Arumugam
Hello, Here's a proposal on how we tag our releases. This is primarily to help continuous integration and stay in line with other communities. This should also help git describe do the right thing. For those who don't have the context, currently we don't create tags at the beginning of the

Re: Review Request 18600: Allowed replicated log to do auto initialization.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18600/#review39595 --- Patch looks great! Reviews applied: [18600] All tests passed. -

[jira] [Created] (MESOS-1193) Check failed: promises.contains(containerId) crashes slave

2014-04-04 Thread Tobi Knaup (JIRA)
:58.307122 3932 gc.cpp:56] Scheduling '/tmp/mesos5053/slaves/20140404-164105-3823062160-5050-24762-5/frameworks/201404041625-3823062160-55371-22555-/executors/web_467-1396634277535/runs/6d4de71c-a491-4544-afe0-afcbfa37094a' for gc 6.9644578667days in the future I0404 17:58:58.307157 3932

[jira] [Commented] (MESOS-1193) Check failed: promises.contains(containerId) crashes slave

2014-04-04 Thread Ian Downes (JIRA)
'web_467-1396634277535' of framework 201404041625-3823062160-55371-22555- I0404 17:58:58.307122 3932 gc.cpp:56] Scheduling '/tmp/mesos5053/slaves/20140404-164105-3823062160-5050-24762-5/frameworks/201404041625-3823062160-55371-22555-/executors/web_467-1396634277535/runs/6d4de71c-a491-4544-afe0

[jira] [Closed] (MESOS-1163) make check fails on ubuntu 12.04

2014-04-04 Thread Bharath Bhushan (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Bhushan closed MESOS-1163. -- Resolution: Not a Problem Fix Version/s: 0.17.0 make check fails on ubuntu 12.04

[proposal] Annotated tags for mesos release

2014-04-04 Thread Bhuvan Arumugam
Hello, Here's a proposal on how we tag our releases. This is primarily to help continuous integration and stay in line with other communities. This should also help git describe do the right thing. For those who don't have the context, currently we don't create tags at the beginning of the

[proposal] Annotated tags for mesos release

2014-04-04 Thread Bhuvan Arumugam
Hello, Here's a proposal on how we tag our releases. This is primarily to help continuous integration and stay in line with other communities. This should also help git describe do the right thing. For those who don't have the context, currently we don't create tags at the beginning of the

Re: Review Request 19761: Added a benchmark test for Registrar which is enabled by 'make bench'.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/#review39602 --- Patch looks great! Reviews applied: [19761] All tests passed. -

[jira] [Commented] (MESOS-1193) Check failed: promises.contains(containerId) crashes slave

2014-04-04 Thread Ian Downes (JIRA)
201404041625-3823062160-55371-22555- I0404 17:58:58.307122 3932 gc.cpp:56] Scheduling '/tmp/mesos5053/slaves/20140404-164105-3823062160-5050-24762-5/frameworks/201404041625-3823062160-55371-22555-/executors/web_467-1396634277535/runs/6d4de71c-a491-4544-afe0-afcbfa37094a' for gc

Review Request 20052: Replace CHECK with Failure for exec in MesosContainerizer

2014-04-04 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20052/ --- Review request for mesos, Ben Mahler, Tobi Knaup, and Vinod Kone. Bugs:

[jira] [Commented] (MESOS-1193) Check failed: promises.contains(containerId) crashes slave

2014-04-04 Thread Ian Downes (JIRA)
- I0404 17:58:58.307122 3932 gc.cpp:56] Scheduling '/tmp/mesos5053/slaves/20140404-164105-3823062160-5050-24762-5/frameworks/201404041625-3823062160-55371-22555-/executors/web_467-1396634277535/runs/6d4de71c-a491-4544-afe0-afcbfa37094a' for gc 6.9644578667days in the future I0404

Review Request 20055: Modifed getHostName to use the correct error code.

2014-04-04 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20055/ --- Review request for mesos. Repository: mesos-git Description --- see

Re: Review Request 20052: Replace CHECK with Failure for exec in MesosContainerizer

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20052/#review39603 --- Patch looks great! Reviews applied: [20052] All tests passed. -

[jira] [Commented] (MESOS-1154) Flaky SlaveRecoveryTest test: ReconcileKillTask and RecoverStatusUpdateManager.

2014-04-04 Thread Ian Downes (JIRA)
] SlaveRecoveryTest/0.ReconcileKillTask WARNING: Logging before InitGoogleLogging() is written to STDERR I0404 22:26:09.061580 52881 exec.cpp:131] Version: 0.19.0 I0404 22:26:09.064916 52906 exec.cpp:205] Executor registered on slave 20140404-222607-1828659978-41600-52820-0 Registered executor on smfd-atr-11-sr1

[jira] [Updated] (MESOS-425) abstract out disk operations into a disk manager

2014-04-04 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Downes updated MESOS-425: - Assignee: (was: Ian Downes) abstract out disk operations into a disk manager

[jira] [Commented] (MESOS-1160) Support flattening from {Try,Result} into Future.

2014-04-04 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960555#comment-13960555 ] Benjamin Mahler commented on MESOS-1160: I was also thinking this would be done

Re: Review Request 20055: Modifed getHostName to use the correct error code.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20055/#review39611 --- Patch looks great! Reviews applied: [20055] All tests passed. -

Re: Review Request 20047: Reused statistics for calculating statistics from TimeSeries.

2014-04-04 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20047/ --- (Updated April 4, 2014, 5:45 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 20047: Reused statistics for calculating statistics from TimeSeries.

2014-04-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20047/#review39622 --- Patch looks great! Reviews applied: [20047] All tests passed. -