Re: Review Request 20297: Added API for managing IP packet filters.

2014-05-13 Thread Jie Yu
> On May 13, 2014, 1:24 a.m., Vinod Kone wrote: > > src/linux/routing/filter/ip.cpp, line 184 > > > > > > s/destinationIP/destinationPorts/ Oops! Good catch! This is not captured by the unit test. I added another unit

Re: Review Request 21360: mesos-style.py accepts files to lint as args

2014-05-13 Thread Vinod Kone
> On May 14, 2014, 5:12 a.m., Dominic Hamon wrote: > > support/mesos-style.py, line 93 > > > > > > could we just run find_candidates on each of the file_paths in this > > case and avoid the cost of generating the candi

Re: Review Request 21360: mesos-style.py accepts files to lint as args

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21360/#review42947 --- Ship it! Ship It! - Vinod Kone On May 14, 2014, 4:24 a.m., Steve

Re: Review Request 21141: Allowed waiting for a link to be removed.

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21141/#review42802 --- src/linux/routing/link/link.hpp

Re: Review Request 21279: Added task gauges to Master.

2014-05-13 Thread Dominic Hamon
> On May 13, 2014, 6:47 p.m., Ben Mahler wrote: > > Looks like this needs a rebase? > > > > $ ./support/apply-review.sh 21279 > > error: patch failed: src/master/master.cpp:3747 > > error: src/master/master.cpp: patch does not apply > > Failed to apply patch it needs 19504 .. did the dependency

Re: Review Request 21279: Added task gauges to Master.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/ --- (Updated May 13, 2014, 10:03 p.m.) Review request for mesos and Ben Mahler. C

[jira] [Commented] (MESOS-1338) Add global counters for each message type on Master

2014-05-13 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996860#comment-13996860 ] Yan Xu commented on MESOS-1338: --- https://reviews.apache.org/r/21399 > Add global counters f

Re: Review Request 19504: Ported master stats to use new metrics library.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19504/ --- (Updated May 13, 2014, 9:53 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-13 Thread Jiang Yan Xu
> On May 13, 2014, 2:02 p.m., Dominic Hamon wrote: > > In regards to adding a layer of indirection: I'm not completely opposed to > > the idea, but I'd like to avoid the tautology. So it would be: > > > > master/messages/kill_task > > master/messages/reconcile_tasks > > master/messages/authenti

Re: Where did 0.18.1 go? Suggesting 0.18.2

2014-05-13 Thread Till Toenshoff
+1 On May 13, 2014, at 8:55 PM, Vinod Kone wrote: > +1 > > > On Tue, May 13, 2014 at 10:54 AM, Benjamin Hindman > wrote: > +1! > > > On Tue, May 13, 2014 at 9:51 AM, Niklas Nielsen wrote: > Hey everyone, > > First and foremost, I apologize for the radio silence on my part with regards >

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-13 Thread Dominic Hamon
> On May 13, 2014, 2:02 p.m., Dominic Hamon wrote: > > In regards to adding a layer of indirection: I'm not completely opposed to > > the idea, but I'd like to avoid the tautology. So it would be: > > > > master/messages/kill_task > > master/messages/reconcile_tasks > > master/messages/authenti

[jira] [Commented] (MESOS-1332) Improve Master and Slave metric names

2014-05-13 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997123#comment-13997123 ] Benjamin Mahler commented on MESOS-1332: Great point [~adam-mesos], we definitely

Re: Review Request 21360: mesos-style.py accepts files to lint as args

2014-05-13 Thread Steven Phung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21360/ --- (Updated May 14, 2014, 4:24 a.m.) Review request for mesos and Vinod Kone. Ch

[jira] [Created] (MESOS-1367) add polling to metrics library

2014-05-13 Thread Dominic Hamon (JIRA)
Dominic Hamon created MESOS-1367: Summary: add polling to metrics library Key: MESOS-1367 URL: https://issues.apache.org/jira/browse/MESOS-1367 Project: Mesos Issue Type: Task Compo

[jira] [Created] (MESOS-1363) ExternalContainerizer 'wait' invocations that survive a slave restart pile up

2014-05-13 Thread Till Toenshoff (JIRA)
Till Toenshoff created MESOS-1363: - Summary: ExternalContainerizer 'wait' invocations that survive a slave restart pile up Key: MESOS-1363 URL: https://issues.apache.org/jira/browse/MESOS-1363 Project

[jira] [Updated] (MESOS-1358) Show when the leading master was elected in the webui

2014-05-13 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1358: -- Component/s: webui > Show when the leading master was elected in the webui > --

[jira] [Commented] (MESOS-1332) Improve Master and Slave metric names

2014-05-13 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997149#comment-13997149 ] Vinod Kone commented on MESOS-1332: --- sgtm. > Improve Master and Slave metric names > --

Re: Review Request 21360: mesos-style.py accepts files to lint as args

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21360/#review42911 --- Sorry for not being clear. I think the script should by default look

Re: Review Request 21279: Added task gauges to Master.

2014-05-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review42930 --- Ship it! Looks like this needs a rebase? $ ./support/apply-review.

[jira] [Commented] (MESOS-1364) ExternalContainerizer 'recover' should destroy orphaned ContainerIDs

2014-05-13 Thread Till Toenshoff (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997228#comment-13997228 ] Till Toenshoff commented on MESOS-1364: --- So I reverted my initial patch towards some

Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

2014-05-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21424/ --- Review request for mesos, Ben Mahler and Niklas Nielsen. Bugs: MESOS-1364 h

[jira] [Created] (MESOS-1365) SlaveRecoveryTest/0.MultipleFrameworks is flaky

2014-05-13 Thread Dominic Hamon (JIRA)
:05.931761 4320 exec.cpp:131] Version: 0.19.0 I0513 15:42:05.936698 4340 exec.cpp:205] Executor registered on slave 20140513-154204-16842879-51872-13062-0 Registered executor on artoo Starting task 51991f97-f5fd-4905-ad0f-02668083af7c Forked command at 4367 sh -c 'sleep 1000' WARNING: Logg

[jira] [Created] (MESOS-1364) ExternalContainerizer 'recover' should destroy orphaned ContainerIDs

2014-05-13 Thread Till Toenshoff (JIRA)
Till Toenshoff created MESOS-1364: - Summary: ExternalContainerizer 'recover' should destroy orphaned ContainerIDs Key: MESOS-1364 URL: https://issues.apache.org/jira/browse/MESOS-1364 Project: Mesos

[jira] [Created] (MESOS-1368) Credentials file permissions check is broken

2014-05-13 Thread Vinod Kone (JIRA)
Vinod Kone created MESOS-1368: - Summary: Credentials file permissions check is broken Key: MESOS-1368 URL: https://issues.apache.org/jira/browse/MESOS-1368 Project: Mesos Issue Type: Bug Affe

Re: Review Request 21276: Added task gauges to slave metrics.

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21276/#review42843 --- src/slave/slave.hpp

[jira] [Created] (MESOS-1352) Uninitialized scalar field in usage/main.cpp

2014-05-13 Thread Niklas Quarfot Nielsen (JIRA)
Niklas Quarfot Nielsen created MESOS-1352: - Summary: Uninitialized scalar field in usage/main.cpp Key: MESOS-1352 URL: https://issues.apache.org/jira/browse/MESOS-1352 Project: Mesos

Review Request 21237: Added equal operator for stout Interval.

2014-05-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21237/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos-gi

[jira] [Resolved] (MESOS-838) Consider exporting queue size as a metric from the master

2014-05-13 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominic Hamon resolved MESOS-838. - Resolution: Fixed Fix Version/s: 0.19.0 Assignee: Dominic Hamon > Consider exporti

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-13 Thread Ben Mahler
> On May 13, 2014, 9:02 p.m., Dominic Hamon wrote: > > In regards to adding a layer of indirection: I'm not completely opposed to > > the idea, but I'd like to avoid the tautology. So it would be: > > > > master/messages/kill_task > > master/messages/reconcile_tasks > > master/messages/authenti

[jira] [Commented] (MESOS-1338) Add global counters for each message type on Master

2014-05-13 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996713#comment-13996713 ] Yan Xu commented on MESOS-1338: --- I am adding metrics for all message types in Master: {code

Review Request 21417: Updated Slave.MetricsInStatsEndpoint test to match latest metrics set.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21417/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

[jira] [Created] (MESOS-1356) Uncaught exceptions

2014-05-13 Thread Niklas Quarfot Nielsen (JIRA)
Niklas Quarfot Nielsen created MESOS-1356: - Summary: Uncaught exceptions Key: MESOS-1356 URL: https://issues.apache.org/jira/browse/MESOS-1356 Project: Mesos Issue Type: Technical tas

[jira] [Created] (MESOS-1355) Use of untrusted string value in jvm.cpp

2014-05-13 Thread Niklas Quarfot Nielsen (JIRA)
Niklas Quarfot Nielsen created MESOS-1355: - Summary: Use of untrusted string value in jvm.cpp Key: MESOS-1355 URL: https://issues.apache.org/jira/browse/MESOS-1355 Project: Mesos Issu

[jira] [Created] (MESOS-1366) Integrate metric existence and value checks into integration tests

2014-05-13 Thread Dominic Hamon (JIRA)
Dominic Hamon created MESOS-1366: Summary: Integrate metric existence and value checks into integration tests Key: MESOS-1366 URL: https://issues.apache.org/jira/browse/MESOS-1366 Project: Mesos

[jira] [Assigned] (MESOS-1340) add slave operation counters to Master

2014-05-13 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominic Hamon reassigned MESOS-1340: Assignee: Dominic Hamon > add slave operation counters to Master >

[jira] [Issue Comment Deleted] (MESOS-1332) Improve Master and Slave metric names

2014-05-13 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominic Hamon updated MESOS-1332: - Comment: was deleted (was: We should also be able to deprecate "active_tasks" from Master.) > Im

Re: Where did 0.18.1 go? Suggesting 0.18.2

2014-05-13 Thread Benjamin Hindman
+1! On Tue, May 13, 2014 at 9:51 AM, Niklas Nielsen wrote: > Hey everyone, > > First and foremost, I apologize for the radio silence on my part with > regards to the 0.18.1 release. We didn't announce it or make it public on > the website. > The reason is that a bug in the mesos-fetcher got it'

Review Request 21408: Added support for passing flags in override command.

2014-05-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21408/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript

Re: Review Request 21408: Added support for passing flags in override command.

2014-05-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21408/#review42906 --- Ship it! Let's also update the flag description (flags.hpp) that sa

Re: Review Request 21269: Added runtime check to the Linux routing library.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21269/#review42894 --- src/linux/routing/utils.hpp

[jira] [Created] (MESOS-1361) Flaky test: SlaveRecoveryTest/0.RecoverCompletedExecutor

2014-05-13 Thread Benjamin Mahler (JIRA)
.951233 12379 recover.cpp:451] Replica is in EMPTY status I0513 22:30:50.952393 12379 master.cpp:267] Master 20140513-223050-1740121354-41283-12347 (smfd-bkq-03-sr4.devel.twitter.com) started on 10.37.184.103:41283 I0513 22:30:50.952441 12379 master.cpp:304] Master only allowing authenticated

Re: Review Request 21279: Added task gauges to Master.

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review42890 --- Ship it! Ship It! - Vinod Kone On May 13, 2014, 9:31 p.m., Domin

Re: Review Request 21360: mesos-style.py accepts files to lint as args

2014-05-13 Thread Steven Phung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21360/ --- (Updated May 13, 2014, 9:56 p.m.) Review request for mesos and Vinod Kone. Su

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21399/#review42879 --- Just realized that I need to update MetricsInStatsEndpoint - Jiang

Re: Review Request 20295: Added API for managing ICMP packet filters.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20295/#review42900 --- src/linux/routing/filter/icmp.cpp

Testing of 0.18.2-rc1

2014-05-13 Thread Niklas Nielsen
Hey everyone, I just tagged 0.18.2-rc1 as a bug fix release candidate which includes the fix for https://issues.apache.org/jira/browse/MESOS-1313 Can you help us out by testing this RC so we can put this release up for a vote? Thanks! Niklas

[jira] [Closed] (MESOS-335) Statistics.truncate is flaky.

2014-05-13 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominic Hamon closed MESOS-335. --- > Statistics.truncate is flaky. > - > > Key: MESOS-335 >

Re: Review Request 21360: Optimized mesos-style.py to run cpplint on staged files only

2014-05-13 Thread Steven Phung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21360/ --- (Updated May 13, 2014, 9:53 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 21288: Allowed to get/set MTU for a link.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21288/#review42893 --- src/linux/routing/link/link.hpp

Re: Review Request 21279: Added task gauges to Master.

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review42875 --- src/master/master.cpp

[jira] [Created] (MESOS-1360) if POST Content-Type is application/json, translate JSON->Protobuf

2014-05-13 Thread brian wickman (JIRA)
brian wickman created MESOS-1360: Summary: if POST Content-Type is application/json, translate JSON->Protobuf Key: MESOS-1360 URL: https://issues.apache.org/jira/browse/MESOS-1360 Project: Mesos

Re: Review Request 20292: Added API for managing links.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20292/#review42892 --- src/linux/routing/link/link.cpp

Re: Review Request 21379: First phase: Mesos-slave support for "node drain"

2014-05-13 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21379/ --- (Updated May 13, 2014, 2:31 p.m.) Review request for mesos and Ben Mahler. Bu

Re: Review Request 21279: Added task gauges to Master.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/ --- (Updated May 13, 2014, 2:31 p.m.) Review request for mesos and Ben Mahler. Bu

[jira] [Created] (MESOS-1359) The SlaveTest.ROOT_RunTaskWithCommandInfoWithUser test is flaky / broken.

2014-05-13 Thread Benjamin Mahler (JIRA)
ositions 0 -> 0 with 1 holes and 0 unlearned I0513 21:22:59.789197 56060 recover.cpp:425] Starting replica recovery I0513 21:22:59.791005 56060 recover.cpp:451] Replica is in EMPTY status I0513 21:22:59.792076 56061 master.cpp:267] Master 20140513-212259-1740121354-48852-56024 (sm

Re: Review Request 21388: Added override of Flags::load that updates 'argc' and 'argv'.

2014-05-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21388/#review42885 --- Ship it! Thanks! Tested with command executor --override. Will publ

Re: Review Request 20850: Customize the configuration of logging level

2014-05-13 Thread Benjamin Mahler
Sorry for the delay, I've been bogged down quite a bit lately but I will take a look today! Sent from my iPhone > On May 7, 2014, at 5:17 AM, Alexandra Sava wrote: > > Hi guys, > > Any feedback for my changes would be welcomed. > > > > Thanks, > Alexandra > > >> On 1 May 2014 14:16, Alex

Re: Review Request 21246: Fixed Protobuf to JSON serialization of optional fields with default values.

2014-05-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21246/#review42554 --- Ship it! Yeeess. 3rdparty/libprocess/3rdparty/stout/include/s

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21399/ --- (Updated May 13, 2014, 1:59 p.m.) Review request for mesos, Ben Mahler and Domi

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21399/#review42884 --- In regards to adding a layer of indirection: I'm not completely oppo

Re: Assigning issues in JIRA

2014-05-13 Thread Chris Lambert
I have an INFRA ticket open for this: INFRA-7712. See the linked ticket for the initial change. On Tue, May 13, 2014 at 1:07 PM, Dave Lester wrote: > +1 > > Currently, JIRA users need to be manually given permission in order to > assign a ticke

Review Request 21399: Added message counters for all messages types in Master.

2014-05-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21399/ --- Review request for mesos, Ben Mahler and Dominic Hamon. Bugs: MESOS-1338 ht

[jira] [Updated] (MESOS-1313) The executor bit is now essentially ignored with the 0.18.1 fetcher implementation

2014-05-13 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen updated MESOS-1313: -- Fix Version/s: (was: 0.19.0) 0.18.2 > The executor bit i

Re: Review Request 21386: Add support for custom project to list-missing-shipits

2014-05-13 Thread Dominic Hamon
fixed up manually. looks like aurora reads ~/.reviewboardrc in preference to their own config. On Tue, May 13, 2014 at 10:58 AM, Vinod Kone wrote: > doesnt look this belongs to "mesos" group. s/mesos/aurora/ ? > > > On Tue, May 13, 2014 at 10:49 AM, Dominic Hamon > wrote: > >> >> -

[jira] [Created] (MESOS-1357) integrate self-bootstrapping self-contained rbt

2014-05-13 Thread Dominic Hamon (JIRA)
Dominic Hamon created MESOS-1357: Summary: integrate self-bootstrapping self-contained rbt Key: MESOS-1357 URL: https://issues.apache.org/jira/browse/MESOS-1357 Project: Mesos Issue Type: Imp

Re: Review Request 21276: Added task gauges to slave metrics.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21276/ --- (Updated May 13, 2014, 11:02 a.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 21279: Added task gauges to Master.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/ --- (Updated May 13, 2014, 12:35 p.m.) Review request for mesos and Ben Mahler. C

[jira] [Updated] (MESOS-1286) metrics Gauge doesn't need to depend on defer

2014-05-13 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominic Hamon updated MESOS-1286: - Sprint: (was: Q2'14 Sprint 1) > metrics Gauge doesn't need to depend on defer > ---

Re: Review Request 21276: Added task gauges to slave metrics.

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21276/#review42871 --- Ship it! src/slave/slave.cpp

Re: Review Request 21276: Added task gauges to slave metrics.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21276/ --- (Updated May 13, 2014, 12:10 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 20295: Added API for managing ICMP packet filters.

2014-05-13 Thread Jie Yu
> On May 13, 2014, 12:58 a.m., Vinod Kone wrote: > > src/linux/routing/filter/icmp.hpp, lines 77-92 > > > > > > Why not take action::Action and use the dynamic cast trick in an > > earlier review? > > Jie Yu wrote: >

Re: Where did 0.18.1 go? Suggesting 0.18.2

2014-05-13 Thread Vinod Kone
+1 On Tue, May 13, 2014 at 10:54 AM, Benjamin Hindman wrote: > +1! > > > On Tue, May 13, 2014 at 9:51 AM, Niklas Nielsen wrote: > >> Hey everyone, >> >> First and foremost, I apologize for the radio silence on my part with >> regards to the 0.18.1 release. We didn't announce it or make it publi

Re: Review Request 19504: Ported master stats to use new metrics library.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19504/ --- (Updated May 13, 2014, 10:52 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 21386: Add support for custom project to list-missing-shipits

2014-05-13 Thread Vinod Kone
doesnt look this belongs to "mesos" group. s/mesos/aurora/ ? On Tue, May 13, 2014 at 10:49 AM, Dominic Hamon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21386/ > --

Review Request 21386: Add support for custom project to list-missing-shipits

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21386/ --- Review request for mesos. Repository: aurora Description --- Add support

Re: Review Request 21249: Added test for killing unknown task with Slaves in transitional state.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21249/ --- (Updated May 13, 2014, 10:44 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 21166: Added resource Gauges to Master.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21166/ --- (Updated May 13, 2014, 10:52 a.m.) Review request for mesos and Ben Mahler. C

Re: Question on resource offers and framework failover

2014-05-13 Thread Sharma Podila
​Thanks for confirming that, Adam. ​ > , but it would be a good Mesos FAQ topic. I was thinking it might be good to also add to doc in code, either in mesos.proto or MesosSchedulerDriver (mesos.proto already refers to the latter for failover at FrameworkID definition). If you were to try to pers

[jira] [Reopened] (MESOS-1286) metrics Gauge doesn't need to depend on defer

2014-05-13 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone reopened MESOS-1286: --- Reopned because it's causing build issues on some compilers. {code} In file included from ../../src/mast

Review Request 21379: First phase: Mesos-slave support for "node drain"

2014-05-13 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21379/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-544 https://issues.apa

Re: Review Request 21384: Introduced '--' to flags parsing.

2014-05-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21384/#review42839 --- Ship it! Ship It! - Niklas Nielsen On May 13, 2014, 9:40 a.m., B

Where did 0.18.1 go? Suggesting 0.18.2

2014-05-13 Thread Niklas Nielsen
Hey everyone, First and foremost, I apologize for the radio silence on my part with regards to the 0.18.1 release. We didn't announce it or make it public on the website. The reason is that a bug in the mesos-fetcher got it's way in and would render 0.18.1 not useful for production settings ( http

Review Request 21384: Introduced '--' to flags parsing.

2014-05-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21384/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Descriptio

[jira] [Created] (MESOS-1353) Operands don't affect result in mesos_containerizer.cpp

2014-05-13 Thread Niklas Quarfot Nielsen (JIRA)
Niklas Quarfot Nielsen created MESOS-1353: - Summary: Operands don't affect result in mesos_containerizer.cpp Key: MESOS-1353 URL: https://issues.apache.org/jira/browse/MESOS-1353 Project: Mesos

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2119

2014-05-13 Thread Dominic Hamon
triage: it breaks differently in non-c++11 builds using g++-4.6. we should roll out the change: 249011b3d71fcc1776104132391c2011335788d5 Allowed Gauge to take synchronous functions. as some compilers can't disambiguate between Deferred and std::function. I was concerned about this during review b

[jira] [Updated] (MESOS-1346) Improve flags to parse json to protobuf

2014-05-13 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1346: - Issue Type: Story (was: Task) > Improve flags to parse json to protobuf > --

[jira] [Updated] (MESOS-1306) Support Framework API Rate Limiting on Master

2014-05-13 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1306: - Epic Name: FW rate limiting Epic Status: To Do Issue Type: Epic (was: Story) > Suppor

Re: Review Request 21246: Fixed Protobuf to JSON serialization of optional fields with default values.

2014-05-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21246/ --- (Updated May 8, 2014, 5:26 p.m.) Review request for mesos and Benjamin Hindman.

Review Request 21176: Added a test to ensure a recovered slave that does not re-register is removed.

2014-05-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21176/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1319 and

Build failed in Jenkins: Mesos-Ubuntu-distcheck #87

2014-05-13 Thread Apache Jenkins Server
See Changes: [yujie.jay] Add a return statement to Varint64Comparator::Compare in leveldb to [vinod] Moved ReconcileTaskTest test to its own file. [vinod] Fixed tasks reconciliation and added tests. [vinod] Fixed white space in

Re: Review Request 21233: Abstracted out invoking 'mesos-fetcher'.

2014-05-13 Thread Bernd Mathiske
> On May 9, 2014, 2 p.m., Ben Mahler wrote: > > Sending to /dev/null when the Options are none sounds good to me. While this is all very nice, shipping it would further delay MESOS-336. It would be easier to get that done first and refactor afterwards, IMHO. - Bernd

Re: Review Request 20995: Allow Gauge to take simple functions.

2014-05-13 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20995/ --- (Updated May 12, 2014, 12:29 p.m.) Review request for mesos and Ben Mahler. C

[jira] [Created] (MESOS-1348) The SlaveRecoveryTest.GCExecutor test leaks child processes.

2014-05-13 Thread Benjamin Mahler (JIRA)
Benjamin Mahler created MESOS-1348: -- Summary: The SlaveRecoveryTest.GCExecutor test leaks child processes. Key: MESOS-1348 URL: https://issues.apache.org/jira/browse/MESOS-1348 Project: Mesos

[jira] [Commented] (MESOS-1316) Implement decent unit test coverage for the mesos-fetcher tool

2014-05-13 Thread Bernd Mathiske (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996176#comment-13996176 ] Bernd Mathiske commented on MESOS-1316: --- I have submitted a preview patch for MESOS-

[jira] [Updated] (MESOS-1349) Mesos style checker should only check for updated files

2014-05-13 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen updated MESOS-1349: -- Assignee: Steven Phung > Mesos style checker should only check for updated file

Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java

2014-05-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21080/#review42790 --- src/java/src/org/apache/mesos/MesosSchedulerDriver.java

Re: Review Request 20781: Added internal filter and queueing APIs.

2014-05-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20781/#review42774 --- Ship it! src/linux/routing/filter/internal.hpp