Review Request 23916: Fixed a memory leak in limiter.hpp.

2014-07-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23916/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1639

Re: Review Request 23916: Fixed a memory leak in limiter.hpp.

2014-07-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23916/#review48755 --- Ship it! Ship It! - Jie Yu On July 25, 2014, 6:31 a.m., Jiang

Re: Review Request 23695: Allowed LoadGeneratorFramework to read password from a file.

2014-07-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23695/ --- (Updated July 25, 2014, 11:47 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 23911: multihashmap.getKey() method (useful for fixing MESOS-947)

2014-07-25 Thread Ben Mahler
On July 25, 2014, 12:51 a.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, line 42 https://reviews.apache.org/r/23911/diff/1/?file=641620#file641620line42 Aren't there potentially multiple keys for a particular value? i.e.

Re: Review Request 23867: Handle discards on the master detection futures.

2014-07-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23867/#review48760 --- src/master/detector.cpp

Re: Review Request 23453: Unbundle glog

2014-07-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23453/#review48761 --- Bad patch! Reviews applied: [23453] Failed command: git apply

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #236

2014-07-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/236/changes

Re: Review Request 23596: Fix namespace and todo styles in mesos source

2014-07-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23596/#review48769 --- Ship it! Ship It! - Niklas Nielsen On July 16, 2014, 6:22 p.m.,

Re: Review Request 23598: Fix 3rdparty stout namespace and todo style

2014-07-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23598/#review48770 --- Ship it! Ship It! - Niklas Nielsen On July 19, 2014, 1:51 a.m.,

Re: Review Request 23707: Fix line comments end punctuation in mesos source

2014-07-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23707/#review48771 --- Ship it! Ship It! - Niklas Nielsen On July 19, 2014, 1:49 a.m.,

Re: Review Request 23710: Add line comments end punctuation style rule

2014-07-25 Thread Niklas Nielsen
On July 22, 2014, 12:25 a.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [23596, 23597, 23598, 23599, 23707] Failed command: git apply --index 23707.patch Error: error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:491 error:

Re: Review Request 23709: Fix line comments end punctuation in libprocess

2014-07-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23709/#review48773 --- Ship it! Ship It! - Niklas Nielsen On July 19, 2014, 1:52 a.m.,

Re: Review Request 23708: Fix line comments end punctuation in stout

2014-07-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23708/#review48774 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp

Re: Review Request 23597: Fix 3rdparty libprocess todo and namespace style

2014-07-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23597/#review48775 --- Ship it! Ship It! - Niklas Nielsen On July 19, 2014, 1:50 a.m.,

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2015

2014-07-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2015/changes

Re: Review Request 23913: Add C++11 (and boost) atomic support to stout

2014-07-25 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23913/#review48784 --- Let's get the new boost tar ball (with updated headers) up in a

Review Request 23954: Do not set private resources if network isolation is not enabled.

2014-07-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23954/ --- Review request for mesos, Ben Mahler and Ian Downes. Repository: mesos-git

Re: Review Request 23954: Do not set private resources if network isolation is not enabled.

2014-07-25 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23954/#review48786 --- src/slave/slave.cpp

Re: Review Request 23954: Do not set private resources if network isolation is not enabled.

2014-07-25 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23954/#review48788 --- Ship it! src/slave/slave.cpp

Review Request 23955: Fixed a bug in port mapping test cleanup function.

2014-07-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23955/ --- Review request for mesos, Chi Zhang and Ian Downes. Repository: mesos-git

Re: Review Request 23955: Fixed a bug in port mapping test cleanup function.

2014-07-25 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23955/#review48790 --- src/tests/port_mapping_tests.cpp

Re: Review Request 23875: Made WeakFutureT::get a const operation.

2014-07-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23875/#review48793 --- Patch looks great! Reviews applied: [23874, 23875] All tests

Re: Review Request 23698: MESOS-1616 Changed ReregisterCompletedFrameworks to use stout JSON framework

2014-07-25 Thread Craig Hansen-Sturm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23698/ --- (Updated July 26, 2014, 2:11 a.m.) Review request for mesos and Adam B.

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-25 Thread Thomas Rampelberg
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: Looks good Thomas, just a few cleanups and we'll get this committed! Also, I still have a few questions regarding the naming/structure of the modules. ;-) In particular, if we didn't have a native component, would we still

Re: Review Request 23771: Added a Docker containerizer.

2014-07-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review48796 --- Bad patch! Reviews applied: [23771] Failed command: git apply