Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2055

See

Build failed in Jenkins: mesos-reviewbot #1358

See -- [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change within the response URL invocation (log) [URLTrig

Review Request 24768: Save docker pid for subsequent containerizer updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24768/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git

Re: Review Request 24767: Validate Docker version since we require >= 1.0.0.

> On Aug. 16, 2014, 5:13 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 137 > > > > > > I think we can use this as validation and remove calling docker info > > above. Yeah, great idea! - Benjamin

Re: Review Request 24766: Set ownership of stdout/stderr and container directory properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24766/#review50817 --- Ship it! Ship It! - Timothy Chen On Aug. 16, 2014, 4:36 a.m., Be

Re: Review Request 24767: Validate Docker version since we require >= 1.0.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24767/#review50816 --- src/docker/docker.cpp

Review Request 24767: Validate Docker version since we require >= 1.0.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24767/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Desc

Review Request 24766: Set ownership of stdout/stderr and container directory properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24766/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Desc

Build failed in Jenkins: mesos-reviewbot #1357

See Changes: [benjamin.hindman] Make sure the mesos-fetcher exits if the slave terminates. [benjamin.hindman] Introduced "states" for Docker containers to transition between. [benjamin.hindman] Improved safety of "higher-level" io::r

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

> On Aug. 16, 2014, 2:52 a.m., Benjamin Hindman wrote: > > Re-opened for review as a slave that was launched with the environment > > variable LIBPROCESS_PORT will cause the mesos-fetcher to fail to start > > because it also tries to bind to that port. > > Jie Yu wrote: > hum, does that ev

Review Request 24765: Added some slave recovery DockerContainerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24765/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Desc

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

> On Aug. 16, 2014, 2:52 a.m., Benjamin Hindman wrote: > > Re-opened for review as a slave that was launched with the environment > > variable LIBPROCESS_PORT will cause the mesos-fetcher to fail to start > > because it also tries to bind to that port. hum, does that even affect the mesos cont

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/#review50812 --- Re-opened for review as a slave that was launched with the environme

Re: Review Request 24761: Made DockerContainerizer be the default.

> On Aug. 16, 2014, 1:41 a.m., Jie Yu wrote: > > Ship It! There will be some extra logging in the docker containerizer launch (if not supported). So either remove those logging (otherwise, we'll see so many misleading logs in the slave log), or use 'mesos,docker'. - Jie ---

Re: Review Request 24761: Made DockerContainerizer be the default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24761/#review50810 --- Ship it! Ship It! - Jie Yu On Aug. 16, 2014, 1:28 a.m., Benjamin

Review Request 24761: Made DockerContainerizer be the default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24761/ --- Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone. Repos

Re: Review Request 24757: Cleaned up usage of io::read for new semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24757/#review50808 --- Ship it! Ship It! - Jie Yu On Aug. 15, 2014, 11:35 p.m., Benjami

Re: Review Request 24755: Improved safety of "higher-level" io::read/write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24755/#review50807 --- Ship it! Ship It! - Jie Yu On Aug. 15, 2014, 11:34 p.m., Benjami

Re: Review Request 24754: Introduced "states" for Docker containers to transition between.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24754/#review50806 --- src/slave/containerizer/docker.cpp

Re: Review Request 24754: Introduced "states" for Docker containers to transition between.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24754/#review50802 --- Ship it! This is looking really good! Much cleaner! src/slave/con

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/ --- (Updated Aug. 16, 2014, 12:07 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24754: Introduced "states" for Docker containers to transition between.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24754/ --- (Updated Aug. 15, 2014, 11:59 p.m.) Review request for mesos, Jie Yu and Timoth

Re: Review Request 24754: Introduced "states" for Docker containers to transition between.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24754/ --- (Updated Aug. 15, 2014, 11:55 p.m.) Review request for mesos, Jie Yu and Timoth

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

> On Aug. 15, 2014, 11:14 p.m., Timothy Chen wrote: > > src/tests/docker_containerizer_tests.cpp, lines 1108-1110 > > > > > > It's really just to test out value field explicitly. There are a lot > > more variations b

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

> On Aug. 15, 2014, 11:14 p.m., Timothy Chen wrote: > > src/tests/docker_containerizer_tests.cpp, lines 1108-1110 > > > > > > It's really just to test out value field explicitly. There are a lot > > more variations b

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

> On Aug. 15, 2014, 11:14 p.m., Timothy Chen wrote: > > src/tests/docker_containerizer_tests.cpp, lines 1108-1110 > > > > > > It's really just to test out value field explicitly. There are a lot > > more variations b

Re: Review Request 24754: Introduced "states" for Docker containers to transition between.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24754/ --- (Updated Aug. 15, 2014, 11:43 p.m.) Review request for mesos, Jie Yu and Timoth

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/ --- (Updated Aug. 15, 2014, 11:43 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

> On Aug. 15, 2014, 11:14 p.m., Timothy Chen wrote: > > src/tests/docker_containerizer_tests.cpp, lines 1108-1110 > > > > > > It's really just to test out value field explicitly. There are a lot > > more variations b

Review Request 24757: Cleaned up usage of io::read for new semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24757/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Desc

Review Request 24755: Improved safety of "higher-level" io::read/write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24755/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Descri

Review Request 24754: Introduced "states" for Docker containers to transition between.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24754/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Desc

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/#review50793 --- Ship it! Ship It! - Timothy Chen On Aug. 15, 2014, 11:30 p.m., B

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

> On Aug. 15, 2014, 11:14 p.m., Timothy Chen wrote: > > src/tests/docker_containerizer_tests.cpp, lines 1108-1110 > > > > > > It's really just to test out value field explicitly. There are a lot > > more variations b

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/ --- (Updated Aug. 15, 2014, 11:30 p.m.) Review request for mesos, Ian Downes and Ji

Review Request 24753: Moved 'mesos::internal::logging::installSignalFailureHandler()' to stout/logging.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24753/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-1705 https://i

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/#review50791 --- src/tests/docker_containerizer_tests.cpp

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/#review50790 --- Ship it! src/launcher/executor.cpp

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/#review50788 --- Ship it! Ship It! - Benjamin Hindman On Aug. 15, 2014, 9:50 p.m.

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/ --- (Updated Aug. 15, 2014, 9:50 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 24730: Allow override without CommandInfo value to run in command executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/ --- (Updated Aug. 15, 2014, 9:49 p.m.) Review request for drill, Benjamin Hindman a

Re: Review Request 24719: Added document for network monitoring.

> On Aug. 15, 2014, 6:13 p.m., Ian Downes wrote: > > docs/network-monitoring.md, line 9 > > > > > > Perhaps make explicit that they can reach other containers, including > > on the same host, and that they can still rea

Re: Review Request 24407: Use curl-config to locate lib curl when possible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/ --- (Updated Aug. 15, 2014, 9:14 p.m.) Review request for mesos and Timothy St. Cla

Re: Review Request 24730: Allow override to run in command executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/#review50778 --- Patch looks great! Reviews applied: [24730] All tests passed. - M

Jenkins build is back to normal : mesos-reviewbot #1355

See

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #277

See

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50772 --- Ship it! Ship It! - Timothy St. Clair On Aug. 15, 2014, 6:58 p.m

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50769 --- Ship it! Ship It! - Vinod Kone On Aug. 15, 2014, 6:58 p.m., Jie

Re: Review Request 24687: Added support for disabling glog initialization.

> On Aug. 15, 2014, 1:07 a.m., Ben Mahler wrote: > > src/logging/flags.hpp, lines 59-62 > > > > > > Does 'initialize_logging' read more naturally? > > > > Maybe we should have a NOTE in this flag description th

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ --- (Updated Aug. 15, 2014, 6:58 p.m.) Review request for mesos, Timothy St. Clair

Re: Review Request 24734: Fixed a few issues in configure.ac.

> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 111 > > > > > > should this be --with-http_parser? "_" between http and parser. > > Timothy St. Clair wrote: > why? >

Re: Review Request 24734: Fixed a few issues in configure.ac.

> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 111 > > > > > > should this be --with-http_parser? "_" between http and parser. > > Timothy St. Clair wrote: > why? >

Re: Review Request 24734: Fixed a few issues in configure.ac.

> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 111 > > > > > > should this be --with-http_parser? "_" between http and parser. why? $ sudo yum list | grep http | grep par

Re: Review Request 24734: Fixed a few issues in configure.ac.

> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 425 > > > > > > I'm little confused on what the difference is between PROTOCOMPILER vs > > PROTOBUF_COMPILER vs PROTOC. can w

Re: Review Request 24719: Added document for network monitoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/#review50746 --- docs/network-monitoring.md

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50751 --- 3rdparty/libprocess/configure.ac

Re: Review Request 24687: Added support for disabling glog initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24687/ --- (Updated Aug. 15, 2014, 5:42 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 24719: Added document for network monitoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/#review50740 --- docs/network-monitoring.md

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ --- (Updated Aug. 15, 2014, 5:19 p.m.) Review request for mesos, Timothy St. Clair

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ --- (Updated Aug. 15, 2014, 5:12 p.m.) Review request for mesos, Timothy St. Clair

Re: Review Request 24734: Fixed a few issues in configure.ac.

> On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote: > > configure.ac, line 283 > > > > > > This needs to be here or else the includes fail on distributions. > > Jie Yu wrote: > Are you saying that I should do:

Re: Review Request 24734: Fixed a few issues in configure.ac.

> On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote: > > configure.ac, line 283 > > > > > > This needs to be here or else the includes fail on distributions. Are you saying that I should do: CPPFLAGS="$CPPFLAGS -I

Re: Review Request 24714: fix prefix glog on mac

> On Aug. 15, 2014, 8:33 a.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [24714] > > > > All tests passed. contained in: https://reviews.apache.org/r/24734/ Lets close this one out. - Timothy --- This is

Build failed in Jenkins: mesos-reviewbot #1353

See Changes: [vinodkone] Fixed LDFLAGS for prefix installation of libev. -- [...truncated 2926 lines...] Generating google/protobuf/unittest_import_public_pb2.py... Generating google/protobuf/uni

Build failed in Jenkins: Mesos-Ubuntu-distcheck #276

See Changes: [vinodkone] Fixed LDFLAGS for prefix installation of libev. -- [...truncated 1783 lines...] checking how to print strings... printf checking for a sed that does not truncate ou

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50722 --- 3rdparty/libprocess/configure.ac

Re: Review Request 20983: Update system check (http-parser)

> On Aug. 15, 2014, 1:45 a.m., Vinod Kone wrote: > > Stuff is flying all over atm, lets rally around https://reviews.apache.org/r/24734/ for final cleanup. - Timothy --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50719 --- Thanks for all the help guys! & That is an epic configure line ;-)

Re: Review Request 24714: fix prefix glog on mac

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24714/#review50712 --- Patch looks great! Reviews applied: [24714] All tests passed. - M

Jenkins build is back to normal : mesos-reviewbot #1348

See

Re: Review Request 24734: Fixed a few issues in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50708 --- Ship it! LGTM. I'll let Tim give it a look over. - Vinod Kone On