Re: Review Request 25184: Delete framework data in TaskStatus to avoid OOM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25184/ --- (Updated Sept. 6, 2014, 11:38 a.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 25205: Fix command executor path check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/#review52533 --- Patch looks great! Reviews applied: [25205] All tests passed. - M

Review Request 25403: Override entrypoint when shell enabled in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-1770 htt

Re: Review Request 22169: Added External Containerizer documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22169/#review52520 --- Patch looks great! Reviews applied: [22169] All tests passed. - M

Re: Review Request 25371: Send pending tasks during re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25371/#review52511 --- Ship it! src/slave/slave.cpp

Re: Review Request 25193: Switch [mesos] to using compiler intrinsics for unreachable, exit, and abort

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25193/#review52508 --- Ship it! Ship It! - Dominic Hamon On Aug. 29, 2014, 10:54 a.m.,

Re: Review Request 25192: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25192/#review52507 --- Ship it! Ship It! - Dominic Hamon On Sept. 5, 2014, 2 p.m., Patr

Re: Review Request 25192: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25192/ --- (Updated Sept. 5, 2014, 2 p.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25191/#review52506 --- Ship it! Ship It! 3rdparty/libprocess/3rdparty/stout/include/stou

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2359

See

Re: Docker Containerization

Hey, Thank you both for taking the time to respond. I wanted to be very expressive and give context to the points I was making, hopefully it wasn't too ranty. Ben, I've made some inline comments below. I've had some chats with Ian Downes about doing something > like this for the MesosContainerize

Re: Review Request 22066: Added timeout to rescind unused offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review52485 --- Ship it! Thanks Kapil! Will commit this shortly. I made a few minor

Re: Docker Containerization

Hi Tom, As Ben mentioned it's definitely doable to introduce a default image for docker. I was hesitant to use the existing default image flag in the earlier point of the docker development as we didn't have DockerInfo and was just reusing the ContainerInfo from the CommandInfo, which makes it har

Re: Review Request 25334: Fixed python egg proto imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52475 --- Patch looks great! Reviews applied: [25334] All tests passed. - M

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/#review52470 --- 3rdparty/libprocess/src/encoder.hpp

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/ --- (Updated Sept. 5, 2014, 10 a.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

> On Sept. 4, 2014, 6:45 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [24984] > > > > All tests passed. > > Nikita Vetoshkin wrote: > Bot thinks patch is okay. Can someone take a look? there's no shepherd assigned so this might fall through the cracks. I th

Re: Review Request 25270: Enable bridge network in Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 5, 2014, 4:55 p.m.) Review request for mesos, Benjamin Hindman,

Re: Docker Containerization

I appreciate the thoughtful email Tom! There's a bunch there so I've just made some inline comments addressing your final questions. ;-) - Can the docker containerizer support more friendly defaults? If I only > want my mesos cluster to containerizer things with Docker, but don't wish > to require

Re: Review Request 25205: Fix command executor path check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/ --- (Updated Sept. 5, 2014, 4:34 p.m.) Review request for mesos, Adam B, Benjamin H

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2358

5.81.186:49188 I0905 15:53:16.378170 25794 master.cpp:1284] Authorizing framework principal 'test-principal' to receive offers for role '*' I0905 15:53:16.378247 25794 master.cpp:1383] Registering framework 20140905-155316-3125920579-49188-25769- at scheduler-002519ef-8af3-

Re: Review Request 25270: Enable bridge network in Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52462 --- Bad patch! Reviews applied: [25270] Failed command: ./support/meso

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/#review52452 --- Patch looks great! Reviews applied: [25371, 25372, 25373] All test

Re: Review Request 25355: Minor update to include package config file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/#review52448 --- Patch looks great! Reviews applied: [25355] All tests passed. - M

Docker Containerization

Hey everyone, First off; this is a long email... so brace yourself. I appreciate your time and patience. I wanted to open up discussion around this, since I've spoken to several people in isolation and feel it would be great to come to some kind of resolution. My aim here is to try and improve th

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

> On Sept. 5, 2014, 1:45 a.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [24984] > > > > All tests passed. Bot thinks patch is okay. Can someone take a look? - Nikita --- This is an automatically generated

Re: Review Request 22169: Added External Containerizer documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22169/ --- (Updated Sept. 5, 2014, 8:48 a.m.) Review request for mesos and Tom Arnfeld.

Re: deploy_dir

Hi Tim! Just took a quick look at other software. Looks like things like Hadoop and Cassandra both keep there config in /etc/hadoop and /etc/cassandra respectfully. Maybe a less surprise principle can be applied here. Anyway I have nothing against it personally. On Fri, Sep 5, 2014 at 3:08 AM, Ti

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review52429 --- src/tests/isolator_tests.cpp

Re: Review Request 25105: Explore disk io isolation in cgroups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review52428 --- src/linux/cgroups.cpp

Re: Review Request 25334: Fixed python egg proto imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52426 --- Ship it! Ship It! - Tom Arnfeld On Sept. 5, 2014, 7:35 a.m., Til

Re: Review Request 25270: Enable bridge network in Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 5, 2014, 7:50 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25334: Fixed python egg proto imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/ --- (Updated Sept. 5, 2014, 7:35 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25334: Fixed python egg proto imports.

> On Sept. 4, 2014, 5:03 p.m., Thomas Rampelberg wrote: > > :thumbsup: > > > > Is there any reason we're not running `test-containerizer` as part of the > > normal unit tests? I'd hate for something like this to happen accidentally > > again. Yes, the reason is that the tests around the exter

Re: Review Request 25334: Fixed python egg proto imports.

> On Sept. 4, 2014, 5:50 p.m., Vinod Kone wrote: > > src/Makefile.am, lines 219-232 > > > > > > Can you add a comment on why you are doing a 'sed' here? Yes, will do - thanks for reviewing. - Till

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

> On Sept. 4, 2014, 5:06 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 124 > > > > > > i'm not even sure how this was working given that Transfer-Encoding is > > an HTTP/1.1 feature. I gues