Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

On Sept. 5, 2014, 5:01 p.m., Dominic Hamon wrote: 3rdparty/libprocess/src/encoder.hpp, line 124 https://reviews.apache.org/r/24984/diff/2/?file=676526#file676526line124 there are a few other places in the code that work with Transfer-Encoding. check http.hpp and process.cpp. also

Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- Review request for mesos. Repository: mesos-git Description ---

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 8, 2014, 4:25 p.m.) Review request for mesos and Timothy St.

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 8, 2014, 4:27 p.m.) Review request for mesos and Timothy St.

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52600 --- Patch looks great! Reviews applied: [25439] All tests passed. -

Review Request 25447: Update deploy_dir from localstate to sysconf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25447/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1764

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52610 --- Ship it! Ship It! - Timothy St. Clair On Sept. 8, 2014, 2:27

Review Request 25448: Add std::unique_ptr and std::move checks to configure script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1771

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/#review52612 --- src/tests/mesos.hpp

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/#review52611 --- src/tests/fault_tolerance_tests.cpp

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 8, 2014, 8:35 p.m.) Review request for mesos and Timothy St.

Re: Review Request 25447: Update deploy_dir from localstate to sysconf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25447/#review52620 --- Patch looks great! Reviews applied: [25447] All tests passed. -

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/ --- (Updated Sept. 8, 2014, 8:04 p.m.) Review request for mesos, Niklas Nielsen,

Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

On Sept. 5, 2014, 9 p.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp, line 21 https://reviews.apache.org/r/25191/diff/1/?file=672334#file672334line21 can we use __builtin_unreachable instead? we should probably check for it

Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

On Sept. 5, 2014, 2 p.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp, line 21 https://reviews.apache.org/r/25191/diff/1/?file=672334#file672334line21 can we use __builtin_unreachable instead? we should probably check for it

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review52645 --- Patch looks great! Reviews applied: [25448] All tests passed. -

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52651 --- Bad patch! Reviews applied: [25439] Failed command: git apply

Re: Review Request 25371: Send pending tasks during re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25371/ --- (Updated Sept. 9, 2014, 12:41 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25371: Send pending tasks during re-registration.

On Sept. 5, 2014, 9:46 p.m., Vinod Kone wrote: src/slave/slave.cpp, line 897 https://reviews.apache.org/r/25371/diff/1/?file=679923#file679923line897 period at the end? done. - Ben --- This is an automatically generated

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, lines 155-164 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line155 Similar to Slave do you think these should be Owned? Good call, cleaned these up as well. - Ben

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/ --- (Updated Sept. 9, 2014, 12:42 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/ --- (Updated Sept. 9, 2014, 12:43 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

On Sept. 8, 2014, 6:02 p.m., Vinod Kone wrote: src/tests/fault_tolerance_tests.cpp, line 2322 https://reviews.apache.org/r/25373/diff/1/?file=679958#file679958line2322 Instead of having a mock gc executor and launching 2 tasks and pausing the gc's unschedule, can we just do:

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/ --- (Updated Sept. 9, 2014, 12:43 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 25447: Update deploy_dir from localstate to sysconf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25447/#review52659 --- Ship it! This probably needs a call out in the CHANGELOG so that

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52666 --- Patch looks great! Reviews applied: [25434] All tests passed. -

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/#review52669 --- Ship it! Ship It! - Vinod Kone On Sept. 9, 2014, 12:43 a.m.,

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, line 597 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597 Since you are cleaning up this code, I don't think this variable is necessary anymore? Actually I don't know why it was used in

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/#review52672 --- Patch looks great! Reviews applied: [25371, 25372, 25373] All