Re: Review Request 25523: Add Docker pull to docker abstraction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/ --- (Updated Sept. 11, 2014, 6:44 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 25523: Add Docker pull to docker abstraction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/#review53007 --- Bad patch! Reviews applied: [25523] Failed command: ./support/meso

Re: Review Request 25035: Fix for MESOS-1688

> On Sept. 11, 2014, 5:35 a.m., Vinod Kone wrote: > > Can you also update the summary of the review to something more meaningful? We typically use the summary to generate the commit message. - Vinod --- This is an automatically generat

Re: Review Request 25035: Fix for MESOS-1688

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review53002 --- src/common/resources.cpp

Re: Review Request 25511: Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the shutdown call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25511/#review53003 --- Patch looks great! Reviews applied: [25511] All tests passed. - M

Re: Review Request 25035: Fix for MESOS-1688

> On Sept. 9, 2014, 7:10 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1901 > > > > > > I like these warnings. > > > > Are you planning to get this in to 0.20.1 or 0.21.0 ? If the former, > > can y

Re: Review Request 25511: Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the shutdown call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25511/#review52999 --- Ship it! Ship It! - Ben Mahler On Sept. 10, 2014, 6:02 p.m., Jia

Re: Review Request 25487: Increased session timeouts for ZooKeeper related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25487/#review52998 --- Ship it! Ship It! - Ben Mahler On Sept. 10, 2014, 6 p.m., Jiang

Re: Review Request 25526: catch traling spaces in style checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25526/#review52994 --- Ship it! Thank you sir! Didn't realize this rule already existed in

Re: Review Request 25487: Increased session timeouts for ZooKeeper related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25487/#review52993 --- Patch looks great! Reviews applied: [25487] All tests passed. - M

Jenkins build is back to normal : mesos-reviewbot #1514

See

Review Request 25526: catch traling spaces in style checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25526/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1779

Build failed in Jenkins: mesos-reviewbot #1513

See Changes: [adam] Fixed command executor path check [yujie.jay] Made sure IPv6 is disabled for port mapping network isolator. -- [...truncated 5561 lines...] rm -f slave/containerizer/.dirstam

Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/ --- Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod Ko

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Sept. 11, 2014, 1:24 a.m.) Review request for mesos, Adam B and Benjam

Re: Completed tasks remains in TASK_RUNNING when framework is disconnected

I agree with Niklas that if the executor has sent a terminal status update to the slave, then the task is done and the master should be able to recover those resources. Only sending the oldest status update to the master, especially in the case of framework failover, prevents these resources from b

Re: Completed tasks remains in TASK_RUNNING when framework is disconnected

The main reason is to keep status update manager simple. Also, it is very easy to enforce the order of updates to the master/framework in this model. If we allow multiple updates for a task to be in flight, it's really hard (impossible?) to ensure that we are not delivering out-of-order updates eve

Re: Review Request 25270: Enable bridge network in Mesos

> On Sept. 9, 2014, 6:48 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 860 > > > > > > Any reason not to do s/NetworkMode/Network/ instead? Not really, I thought Network seems a bit too generic and

Re: Review Request 24776: Add docker containerizer destroy tests

> On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote: > > Why did you need to mock DockerContainerizerProcess in order to write these > > tests? Couldn't you have just used the existing MockDockerContainerizer? I wanted to simulate having destroy called in a pull/fetching state, so I thought

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/ --- (Updated Sept. 11, 2014, 12:40 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/ --- (Updated Sept. 11, 2014, 12:40 a.m.) Review request for drill, Benjamin Hindman

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

> On Sept. 9, 2014, 6:50 p.m., Benjamin Hindman wrote: > > src/docker/docker.cpp, line 337 > > > > > > Why not move this up above as well? The Docker cli --entrypoint only allows you to put in a single string, but we

Re: Completed tasks remains in TASK_RUNNING when framework is disconnected

Hey Vinod - thanks for chiming in! Is there a particular reason for only having one status in flight? Or to put it in another way, isn't that too strict behavior taken that the master state could present the most recent known state if the status update manager tried to send more than the front of

Review Request 25523: Add Docker pull to docker abstraction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25523/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript

Re: Completed tasks remains in TASK_RUNNING when framework is disconnected

What you observed is expected because of the way the slave (specifically, the status update manager) operates. The status update manager only sends the next update for a task if a previous update (if it exists) has been acked. In your case, since TASK_RUNNING was not acked by the framework, maste

Build failed in Jenkins: mesos-reviewbot #1512

See Changes: [bmahler] Send pending tasks during re-registration. [bmahler] Made the GarbageCollector injectable into the Slave. [bmahler] Added a test for sending pending tasks during re-registration. [tstclair] Fix git clean -xdf s

Re: Completed tasks remains in TASK_RUNNING when framework is disconnected

Here is the log of a mesos-local instance where I reproduced it: https://gist.github.com/nqn/f7ee20601199d70787c0 (Here task 10 to 19 are stuck in running state). There is a lot of output, so here is a filtered log for task 10: https://gist.github.com/nqn/a53e5ea05c5e41cd5a7d At first glance, it l

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

> On Sept. 10, 2014, 7:40 p.m., Chi Zhang wrote: > > agree to check to make sure this works in dev-clusters and the kernel > > warning messages go away, if hasn't been. The kernel log no longer has that warning after this change. - Jie ---

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

> On Sept. 10, 2014, 7:11 p.m., Ian Downes wrote: > > Does this mean that users that open sockets (withouth specifying) will only > > get a v4 socket? What happens if they try to open a v6 socket? Tested. If they open a v6 socket, IPv4 will be used for communication (unless they use IPV6_ONLY)

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

> On Sept. 10, 2014, 7:06 p.m., Cong Wang wrote: > > Maybe check if /proc/sys/net/ipv6/conf/all/disable_ipv6 exists in child > > script too since you did outside? It's OK, if the proc file does not exist, it'll be a no-op as we don't use set -e. - Jie --

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

> On Sept. 10, 2014, 6:48 p.m., Vinod Kone wrote: > > Have you confirmed/tested that this is safe? Tested. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25512/#review52913 ---

Completed tasks remains in TASK_RUNNING when framework is disconnected

Hi guys, We have run into a problem that cause tasks which completes, when a framework is disconnected and has a fail-over time, to remain in a running state even though the tasks actually finishes. Here is a test framework we have been able to reproduce the issue with: https://gist.github.com/nq

Re: Review Request 25516: Fixed authorization tests to properly deal with registration retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25516/#review52960 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 10, 2014, 12:55 p.m.,

Re: Review Request 25035: Fix for MESOS-1688

> On Sept. 9, 2014, 7:10 nachm., Vinod Kone wrote: > > src/master/master.cpp, line 1901 > > > > > > I like these warnings. > > > > Are you planning to get this in to 0.20.1 or 0.21.0 ? If the former, > > can

Re: Review Request 25035: Fix for MESOS-1688

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 10, 2014, 10 nachm.) Review request for mesos and Vinod Kone.

Design doc for updating FrameworkInfo

Hi folks, We have a design doc up (attached to MESOS-1784 ) for properly updating the FrameworkInfo. The basic idea is to provide frameworks the ability update any fields of their FrameworkInfo (e.g., 'user', 'failover_timeout') without having to

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2097

See

Build failed in Jenkins: mesos-reviewbot #1511

See Changes: [tstclair] Fix protobuf detection on systems with Python 3 as default (part2) -- [...truncated 5420 lines...] rm -f slave/containerizer/mesos/.dirstamp rm -f sasl/*.o rm -f state/.de

Review Request 25516: Fixed authorization tests to properly deal with registration retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25516/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-1760 and MESOS-1766

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25512/#review52923 --- Ship it! agree to check to make sure this works in dev-clusters and

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2096

19:26:48.923501 16947 slave.cpp:980] Will retry registration in 7.844963ms if necessary I0910 19:26:48.923569 16946 master.cpp:2843] Registering slave at slave(206)@67.195.81.186:41538 (penates.apache.org) with id 20140910-192648-3125920579-41538-16920-0 I0910 19:26:48.923704 16937 r

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25512/#review52920 --- Does this mean that users that open sockets (withouth specifying) wi

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25508/#review52919 --- Ship it! So for completeness the actual diff is not posted here b/c

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25512/#review52918 --- Ship it! Maybe check if /proc/sys/net/ipv6/conf/all/disable_ipv6 ex

Re: Review Request 25261: Check for variadic template and default/deleted function support

> On Sept. 2, 2014, 7:50 p.m., Michael Park wrote: > > Just something to note here, there's a bug in earlier GCC versions where > > the access control of `= default`ed functions aren't enforced correctly. > > > > e.g. > > > > ``` > > class Foo > > { > > private: > > > > Foo() = default; >

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25512/#review52913 --- Ship it! Have you confirmed/tested that this is safe? - Vinod Kone

Re: Mesos Driver aborted silently?

My guess is that your driver threw an exception while handling the offerRescinded() callback which was detected by the JNI binding (IIRC Mantis is a JVM framework?) causing it to abort the driver. Note that when a driver aborts, it will send a DeactivateFrameworkMessage to the master causing the ma

Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25512/ --- Review request for mesos, Chi Zhang, Vinod Kone, and Cong Wang. Repository: mes

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote: > > 3rdparty/Makefile.am, line 84 > > > > > > didn't realize that the leveldb we bundle has git files in it! isn't > > the proper fix here to bundle a proper 'dist'ribu

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote: > > 3rdparty/Makefile.am, line 84 > > > > > > didn't realize that the leveldb we bundle has git files in it! isn't > > the proper fix here to bundle a proper 'dist'ribu

Jenkins build is back to normal : mesos-reviewbot #1510

See

Review Request 25511: Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the shutdown call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25511/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

Re: Review Request 25487: Increased session timeouts for ZooKeeper related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25487/ --- (Updated Sept. 10, 2014, 11 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52898 --- Ship it! Ship It! - Timothy St. Clair On Sept. 9, 2014, 2:49 p.m

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

> On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote: > > 3rdparty/Makefile.am, line 84 > > > > > > didn't realize that the leveldb we bundle has git files in it! isn't > > the proper fix here to bundle a proper 'dist'ribu

Re: Review Request 25508: Fix git clean -xdf skipping leveldb

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25508/#review52894 --- 3rdparty/Makefile.am

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

> On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/slave/constants.hpp, line 53 > > > > > > What is the 'base executor' versus the 'command executor'? > > Alexander Rukletsov wrote: > We have Executor (

Re: Dynamic Resource Roles

BenH has been calling these "master reservations" (globally control reservations across all slaves through the master) and "offer reservations" (I don't care which nodes it's on, as long as I get X cpu and Y RAM, or Z sets of {X,Y}), and they're definitely on the roadmap. On Wed, Sep 10, 2014 at 9

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

> On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/slave/constants.hpp, line 53 > > > > > > What is the 'base executor' versus the 'command executor'? > > Alexander Rukletsov wrote: > We have Executor (

Review Request 25508: Fix git clean -xdf skipping leveldb

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25508/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1764 https://i

Re: Review Request 25487: Increased session timeouts for ZooKeeper related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25487/#review52884 --- src/tests/zookeeper.cpp

Re: Dynamic Resource Roles

That's very cool, thanks. On Wed, Sep 10, 2014 at 4:59 PM, Timothy Chen wrote: > Hi Tom, > Reservations is definitely something we've discussed and will be addressed in > the near future. > Tim >> On Sep 10, 2014, at 7:49 AM, Tom Arnfeld wrote: >> >> Hey everyone, >> >> Just a quick question

Re: Dynamic Resource Roles

Hi Tom, Reservations is definitely something we've discussed and will be addressed in the near future. Tim > On Sep 10, 2014, at 7:49 AM, Tom Arnfeld wrote: > > Hey everyone, > > Just a quick question. Has the ever been any discussion around dynamic > roles? > > What I mean by this – curre

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2358

Just flying cover, but my change is unrelated to the issue. However, I see this issue quite often as well. Cheers, Tim - Original Message - > From: "Yan Xu" > To: dev@mesos.apache.org > Cc: "Vinod Kone" > Sent: Tuesday, September 9, 2014 4:50:06 PM > Subject: Re: Build failed in Jen

Dynamic Resource Roles

Hey everyone, Just a quick question. Has the ever been any discussion around dynamic roles? What I mean by this – currently if I want to guarantee 1 core and 10 GB of ram to a specific type of framework (or "role") I need to do this at a slave level. This means if I only want to guarantee a small

Build failed in Jenkins: mesos-reviewbot #1509

See -- [...truncated 5591 lines...] rm -f slave/*.lo rm -f slave/containerizer/.deps/.dirstamp rm -f slave/containerizer/*.o rm -f slave/containerizer/.dirstamp rm -f slave/containerizer/*.lo rm -f slave/

Build failed in Jenkins: mesos-reviewbot #1508

See Changes: [niklas] Fixed line comments end punctuation in Mesos source. [niklas] Fixed line comments end punctuation in stout. [niklas] Fixed line comments end punctuation in libprocess. [dlester] Adds Qubit to PoweredByMesos list

Build failed in Jenkins: mesos-reviewbot #1507

See -- [...truncated 5668 lines...] make[1]: Leaving directory ` if test -d "mesos-0.21.0"; then find "mesos-0.21.0" -type d ! -perm