Build failed in Jenkins: mesos-reviewbot #1534

2014-09-12 Thread Apache Jenkins Server
See Changes: [bmahler] Fixed the flaky FaultToleranceTest.ReconcilePendingTasks. -- [...truncated 5696 lines...] Removing aclocal.m4 Removing ar-lib Removing autom4te.cache/ Removing bin/gdb-meso

Build failed in Jenkins: mesos-reviewbot #1533

2014-09-12 Thread Apache Jenkins Server
See Changes: [niklas] Fixed flaky MasterTest.LaunchDuplicateOfferTest. -- [...truncated 5487 lines...] rm -f slave/containerizer/.dirstamp rm -f slave/containerizer/isolators/cgroups/.deps/.dirst

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-12 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/ --- (Updated Sept. 13, 2014, 12:33 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-12 Thread Cody Maloney
> On Sept. 12, 2014, 11:48 p.m., Dominic Hamon wrote: > > src/common/slaveinfo_utils.cpp, line 44 > > > > > > std::pair might be preferable. T is a pointer to member function in this case. I could try specifying it mor

Re: Review Request 25604: Fixed the flaky FaultToleranceTest.ReconcilePendingTasks.

2014-09-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25604/#review53254 --- Ship it! Ship It! - Vinod Kone On Sept. 13, 2014, 12:13 a.m., Be

Re: ANN: Mesos bindings for Haskell

2014-09-12 Thread Vinod Kone
Great to see the Haskell bindings Ian! See my answers inline. * It seems like there are portions of mesos.proto that aren’t > currently supported by the API yet: in particular, “Credentials”, “ACL”, > “ACLS”, “RateLimit”, & “RateLimits” don’t seem like they do anything yet. > Am I missing

Re: Review Request 25597: Added a version checker class to stout.

2014-09-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25597/ --- (Updated Sept. 12, 2014, 8:14 p.m.) Review request for mesos, Adam B and Niklas

Review Request 25604: Fixed the flaky FaultToleranceTest.ReconcilePendingTasks.

2014-09-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25604/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1786 https://issues.ap

Re: Review Request 25551: Add standard versioning to shared libmesos.so

2014-09-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25551/#review53252 --- Bad patch! Reviews applied: [25551] Failed command: ./support/meso

Build failed in Jenkins: mesos-reviewbot #1532

2014-09-12 Thread Apache Jenkins Server
See -- [...truncated 5648 lines...] Removing 3rdparty/libprocess/3rdparty/stout/config.log Removing 3rdparty/libprocess/3rdparty/stout/config.status Removing 3rdparty/libprocess/3rdparty/stout/configure R

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-12 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review53248 --- src/Makefile.am

Re: Review Request 25569: Only perform docker validation once for tests

2014-09-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review53246 --- Thanks for following up! Not your fault, but the current design of

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-12 Thread Cody Maloney
> On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 3122 > > > > > > You should checkpoint the updated slave info! > > Cody Maloney wrote: > info contains the new slave info set at the

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-12 Thread Cody Maloney
> On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: > > OK. I went through parts of this review but I have a bigger suggestion in > > mind, before I get too much into the weeds. > > > > I think it's worthwhile for you to write up a design doc similar to the > > framework info doc w.r.t. updating

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-12 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/ --- (Updated Sept. 12, 2014, 11:33 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review53247 --- src/slave/flags.hpp

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-09-12 Thread Ben Mahler
> On Sept. 12, 2014, 7:03 p.m., Ben Mahler wrote: > > Thanks for doing this! A few higher level comments: > > > > (1) We have strings::join in stout. Have you considered implementing this > > TLineHelper as a generic Joiner in stout/strings.hpp? Seems like it belongs > > there instead of a new

Re: Review Request 25042: Remove duplicate headers imports

2014-09-12 Thread Niklas Nielsen
> On Sept. 12, 2014, 3:07 p.m., Niklas Nielsen wrote: > > Cool! Going to commit this in a bit Well, never mind - Adam already got this through. Remember to mark as submitted :) - Niklas --- This is an automatically generated e-mail. To

Re: Review Request 25042: Remove duplicate headers imports

2014-09-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25042/#review53231 --- Ship it! Cool! Going to commit this in a bit - Niklas Nielsen On

Re: Review Request 22526: WIP:Added resizeTask primitive.

2014-09-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22526/#review53230 --- I don't think Yifan is going to complete this work. I am going to di

Re: Review Request 25565: Added a removeExecutor helper in the Master.

2014-09-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25565/#review53222 --- Ship it! src/master/master.cpp

Re: Review Request 25588: Fixed flaky MasterTest.LaunchDuplicateOfferTest.

2014-09-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25588/#review53223 --- Ship it! Thanks Niklas for fixing additional tests! - Jiang Yan Xu

Build failed in Jenkins: mesos-reviewbot #1531

2014-09-12 Thread Apache Jenkins Server
See -- [...truncated 5622 lines...] rm -f sched/*.o rm -f slave/containerizer/isolators/network/.dirstamp rm -f sched/*.lo rm -f slave/containerizer/mesos/.deps/.dirstamp rm -f scheduler/*.o rm -f slave/c

Re: 0.20.1 Release Manager

2014-09-12 Thread Vinod Kone
awesome. thanks guys! On Fri, Sep 12, 2014 at 12:47 PM, Adam Bordelon wrote: > I can be the release manager, especially if Bhuvan wants to manage some of > the administrivia. > > On Fri, Sep 12, 2014 at 12:23 PM, Tim St Clair > wrote: > > > I would like to, but this next month is going to be cr

Re: 0.20.1 Release Manager

2014-09-12 Thread Adam Bordelon
I can be the release manager, especially if Bhuvan wants to manage some of the administrivia. On Fri, Sep 12, 2014 at 12:23 PM, Tim St Clair wrote: > I would like to, but this next month is going to be crazy for me. Perhaps > the next cycle. > > Regards, > Tim > > - Original Message - >

Re: 0.20.1 Release Manager

2014-09-12 Thread Niklas Nielsen
How about Till? I can help out too. Niklas On Friday, September 12, 2014, Tim St Clair wrote: > I would like to, but this next month is going to be crazy for me. Perhaps > the next cycle. > > Regards, > Tim > > - Original Message - > > From: "Vinod Kone" > > > To: "dev" > > > Sent: Fri

Re: 0.20.1 Release Manager

2014-09-12 Thread Tim St Clair
I would like to, but this next month is going to be crazy for me. Perhaps the next cycle. Regards, Tim - Original Message - > From: "Vinod Kone" > To: "dev" > Sent: Friday, September 12, 2014 12:22:59 PM > Subject: Re: 0.20.1 Release Manager > > Tim St. Clair or Adam, would you

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-09-12 Thread Cody Maloney
> On Sept. 12, 2014, 7:03 p.m., Ben Mahler wrote: > > Thanks for doing this! A few higher level comments: > > > > (1) We have strings::join in stout. Have you considered implementing this > > TLineHelper as a generic Joiner in stout/strings.hpp? Seems like it belongs > > there instead of a new

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-09-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/#review53198 --- Thanks for doing this! A few higher level comments: (1) We have str

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-09-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/#review53196 --- Ship it! This is awesome! I will commit shortly: I fixed a few mino

Review Request 25588: Fixed flaky MasterTest.LaunchDuplicateOfferTest.

2014-09-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25588/ --- Review request for mesos and Jiang Yan Xu. Bugs: mesos-1783 https://issues.

Re: 0.20.1 Release Manager

2014-09-12 Thread Vinod Kone
Tim St. Clair or Adam, would you guys be willing to work with Bhuvan to get the release out? On Fri, Sep 12, 2014 at 10:12 AM, Benjamin Mahler wrote: > Hi Bhuvan, that's great! However, doing a release requires commit access. > > > On Sep 12, 2014, at 8:06 AM, Bhuvan Arumugam wrote: > > > > I l

Re: Mesos webcast

2014-09-12 Thread Kamil Domański
Hi Vinod, much appreciated. Best regards, Kamil

Re: 0.20.1 Release Manager

2014-09-12 Thread Benjamin Mahler
Hi Bhuvan, that's great! However, doing a release requires commit access. > On Sep 12, 2014, at 8:06 AM, Bhuvan Arumugam wrote: > > I like to volunteer for this role. > > There are 18 bugs targetted for this release. If we want to target any > other bug fixes for this release, please ensure "Ta

Re: Mesos webcast

2014-09-12 Thread Vinod Kone
+Matt Hey Kamil, Bummed to hear that you weren't able to tune in to the webinar. Matt tells me that the webinar will be posted online soon. Will make sure to ping the dev list when that happens. Cheers, On Thu, Sep 11, 2014 at 11:22 AM, Kamil Domański wrote: > Hello Vinod, > thank you for doi

Re: Introduction

2014-09-12 Thread Dominic Hamon
Hi Sanjeet The existing documentation is all here: http://mesos.apache.org/documentation/latest/. That includes how to contribute to Mesos as well as some of the different concepts employed by the project. If you have any ideas for what improvements you would like to work on, or if you want to fi

Build failed in Jenkins: mesos-reviewbot #1530

2014-09-12 Thread Apache Jenkins Server
See -- [...truncated 5543 lines...] rm -f log/tool/*.lo rm -f usage/.deps/.dirstamp rm -f logging/*.o rm -f usage/.dirstamp rm -f zookeeper/.deps/.dirstamp rm -f logging/*.lo rm -f zookeeper/.dirstamp rm

Re: 0.20.1 Release Manager

2014-09-12 Thread Bhuvan Arumugam
I like to volunteer for this role. There are 18 bugs targetted for this release. If we want to target any other bug fixes for this release, please ensure "Target version" flag is set as "0.20.1" for that bug. https://issues.apache.org/jira/browse/MESOS-1621?jql=project%20%3D%20MESOS%20AND%20%22Tar

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-12 Thread Alexander Rukletsov
> On Sept. 11, 2014, 3:45 p.m., Timothy St. Clair wrote: > > src/exec/exec.cpp, line 82 > > > > > > Maybe I'm missing something, but is there a reason we don't check > > before a delay? If ShutdownProcess is spawned,

Build failed in Jenkins: mesos-reviewbot #1529

2014-09-12 Thread Apache Jenkins Server
See -- [...truncated 5543 lines...] rm -f logging/*.o rm -f tests/common/.dirstamp rm -f usage/.deps/.dirstamp rm -f logging/*.lo rm -f usage/.dirstamp rm -f master/*.o rm -f zookeeper/.deps/.dirstamp rm