---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/#review54395
---
Patch looks great!
Reviews applied: [25986]
All tests passed.
-
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2122/
--
[...truncated 3441 lines...]
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
running bdist_egg
running egg_info
creating src/mesos.interface.egg-info
Great comments Vinod!
- Original Message -
From: Vinod Kone vinodk...@gmail.com
To: dev dev@mesos.apache.org
Sent: Tuesday, September 23, 2014 1:59:26 PM
Subject: Re: Mesos Modules Design
Ok. I finally had a chance to read the design doc, go through the comments
on this thread
Did you send this to the aurora-team? Maybe I missed it.
On Monday, September 22, 2014, Dominic Hamon dha...@twopensource.com
wrote:
Hello
Here's our focus for the next two weeks. Some of these we are shepherding,
but are high enough profile that we want to track them.
Link to active
I added google test's xml output into a post-build step on Jenkins, you can
see the slowest tests if you sort the time column:
https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2391/testReport/(root)/
Ian's reaper
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25947/
---
(Updated Sept. 24, 2014, 10:52 a.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25965/
---
(Updated Sept. 24, 2014, 11 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/
---
(Updated Sept. 24, 2014, 11:09 a.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25965/
---
(Updated Sept. 24, 2014, 11:13 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25964/
---
(Updated Sept. 24, 2014, 11:14 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25655/
---
(Updated Sept. 24, 2014, 11:14 a.m.)
Review request for mesos, Jie Yu and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25947/#review54443
---
Ship it!
3rdparty/libprocess/src/reap.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25655/#review5
---
Ship it!
Ship It!
- Jie Yu
On Sept. 24, 2014, 6:14 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25947/#review54447
---
Patch looks great!
Reviews applied: [25947]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review54448
---
Bad patch!
Reviews applied: [25655, 24177, 25861]
Failed command:
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/354/
--
[...truncated 5280 lines...]
rm -f cscope.out cscope.in.out cscope.po.out cscope.files
make[4]: Leaving directory
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25947/#review54449
---
3rdparty/libprocess/src/reap.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54425
---
I still debate whether we should name it plugin vs. module.
833 master.cpp:1390] Registering framework
20140924-203300-3193029443-60680-816- at
scheduler-f00cbbab-8d81-4de7-b29d-85142325f060@67.195.81.190:60680
I0924 20:33:00.622068 833 sched.cpp:407] Framework registered with
20140924-203300-3193029443-60680-816-
I0924 20:33:00.622095 833
On Sept. 24, 2014, 1:05 p.m., Timothy St. Clair wrote:
I still debate whether we should name it plugin vs. module. Thoughts?
Could be called either or, but think the term 'module' is pretty clear and is
what we have gone with so far. I don't see any good reason to change it now
unless
scheduler-f00cbbab-8d81-4de7-b29d-85142325f060@67.195.81.190:60680
I0924 20:33:00.621840 833 master.cpp:1291] Authorizing framework
principal 'test-principal' to receive offers for role '*'
I0924 20:33:00.621961 833 master.cpp:1390] Registering framework
20140924-203300-3193029443-60680-816
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/355/changes
Changes:
[yujie.jay] Added support for getting socket diagnosis information.
--
[...truncated 5306 lines...]
rm -f *.lo
test -z || rm -f
test . =
:33:00.621961 833 master.cpp:1390] Registering framework
20140924-203300-3193029443-60680-816- at
scheduler-f00cbbab-8d81-4de7-b29d-85142325f060@67.195.81.190:60680
I0924 20:33:00.622068 833 sched.cpp:407] Framework registered with
20140924-203300-3193029443-60680-816-
I0924 20:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/#review54307
---
src/slave/containerizer/mesos/containerizer.hpp
Fixed.
On Wed, Sep 24, 2014 at 2:25 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/355/changes
Changes:
[yujie.jay] Added support for getting socket diagnosis information.
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24177/#review54458
---
Ship it!
Ship It!
- Jie Yu
On Sept. 23, 2014, 11:42 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25964/#review54461
---
Ship it!
Ship It!
- Jie Yu
On Sept. 24, 2014, 6:14 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25965/#review54460
---
Ship it!
Ship It!
- Jie Yu
On Sept. 24, 2014, 6:13 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/#review54462
---
Have you considered using an accumulator function so that you can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25911/
---
(Updated Sept. 24, 2014, 3:04 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review54463
---
The last nits: looks good to me, but would like BenH to take a look
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2124/
--
[...truncated 2097 lines...]
checking for pwd.h... yes
checking syslog.h usability... yes
checking syslog.h presence... yes
checking for syslog.h... yes
checking
See https://builds.apache.org/job/mesos-reviewbot/1706/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25965/#review54476
---
Patch looks great!
Reviews applied: [25864, 25965]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25866/#review54384
---
Ship it!
Phew that was a bit tricky to review because of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25911/#review54479
---
Bad patch!
Reviews applied: [25967, 25911]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25911/
---
(Updated Sept. 24, 2014, 4:51 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 24, 2014, 7:54 p.m.)
Review request for mesos, Benjamin
On Sept. 24, 2014, 4:05 p.m., Timothy St. Clair wrote:
src/module/manager.hpp, line 141
https://reviews.apache.org/r/25848/diff/5/?file=701886#file701886line141
can't we use std::mutex now?
The current code relies on common/lock.hpp, that uses pthread mutexes.
On Sept. 24, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 24, 2014, 8:11 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25867/#review54480
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25911/#review54486
---
Patch looks great!
Reviews applied: [25967, 25911]
All tests
On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote:
include/mesos/module.hpp, line 73
https://reviews.apache.org/r/25848/diff/5/?file=701882#file701882line73
Perhaps we can breakout in another JIRA, but I would to denote both
some form of AUTHORING as well as define api's as
44 matches
Mail list logo
