Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2164

2014-10-12 Thread Apache Jenkins Server
See Changes: [benjamin.hindman] Update the Mesos Style Guide with C++11 and naming notes. -- [...truncated 46788 lines...] I1013 06:55:13.781483 11857 registrar.cpp

Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

2014-10-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26571/#review56380 --- LGTM. Let's see how ZOOKEEPER-2049 is going. - Jiang Yan Xu On Oc

Re: Review Request 26635: Fixes necessary due to JSON::Array::values change to std::vector.

2014-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26635/#review56378 --- Patch looks great! Reviews applied: [26634, 26635] All tests passe

Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.

2014-10-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/#review56377 --- 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp

Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.

2014-10-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/#review56375 --- 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp

Re: Review Request 26635: Fixes necessary due to JSON::Array::values change to std::vector.

2014-10-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26635/#review56376 --- Ship it! Ship It! - Timothy Chen On Oct. 13, 2014, 4:54 a.m., Be

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

2014-10-12 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/#review56374 --- Ship it! I'll be committing this now, thanks Alex! - Benjamin Hind

Review Request 26635: Fixes necessary due to JSON::Array::values change to std::vector.

2014-10-12 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26635/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Review Request 26634: Implemented array subscript lookup in JSON::Object::find.

2014-10-12 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Repository: mesos

Re: Review Request 26622: Don't pass task-related arguments to mesos-executor.

2014-10-12 Thread R.B. Boyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/ --- (Updated Oct. 12, 2014, 8:09 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

2014-10-12 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56371 --- LGTM! - Cody Maloney On Oct. 12, 2014, 8:11 p.m., Kapil Arya wrot

Re: Review Request 26614: More simplifications of Docker container launching.

2014-10-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26614/#review56370 --- Ship it! Ship It! - Timothy Chen On Oct. 11, 2014, 10:10 p.m., B

Re: Review Request 26630: Fixed non-deterministic test.

2014-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26630/#review56367 --- Patch looks great! Reviews applied: [26611, 26612, 26613, 26614, 26

Re: Review Request 26630: Fixed non-deterministic test.

2014-10-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26630/#review56364 --- Ship it! Ship It! - Timothy Chen On Oct. 12, 2014, 10 p.m., Benj

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

2014-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56363 --- Patch looks great! Reviews applied: [26629] All tests passed. - M

Review Request 26630: Fixed non-deterministic test.

2014-10-12 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26630/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/#review56362 --- Patch looks great! Reviews applied: [26509] All tests passed. - M

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

2014-10-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56361 --- Ship it! Ship It! - Till Toenshoff On Oct. 12, 2014, 8:11 p.m.,

Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

2014-10-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/ --- Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos-

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/ --- (Updated Oct. 12, 2014, 4:08 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-12 Thread Till Toenshoff
> On Oct. 12, 2014, 6:56 p.m., Benjamin Hindman wrote: > > src/slave/main.cpp, lines 126-127 > > > > > > When we can use EXIT(1) << please prefer it (see a few lines up for an > > example). Looks like you can clean up

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-12 Thread Till Toenshoff
> On Oct. 10, 2014, 11:26 p.m., Till Toenshoff wrote: > > src/slave/main.cpp, line 117 > > > > > > Not yours but this would trigger a glog warning as it has not yet been > > initialized. We should possibly check all r

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-12 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/#review56357 --- Ship it! src/slave/main.cpp

Re: Review Request 26436: Avoid docker inspect on each usage call

2014-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review56356 --- Patch looks great! Reviews applied: [26436] All tests passed. - M

Re: Review Request 26436: Avoid docker inspect on each usage call

2014-10-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/ --- (Updated Oct. 12, 2014, 5:16 p.m.) Review request for mesos and Benjamin Hindma

Re: Framework testing in Mesos

2014-10-12 Thread Dharmesh Kakadia
Thanks David. Taking state of the framework is an interesting design. I am assuming the scheduler is maintaining the state and then handing tasks on slaves. If that's the case, we can safely test executor (stateless - receiving event and returning appropriate status to the scheduler). You construc

Re: Framework testing in Mesos

2014-10-12 Thread David Greenberg
For our frameworks, we don't tend to do much automated testing of the Mesos interface--instead, we construct the framework state, then "send it a message", since our callbacks take the state of the framework + the event as the argument. This way, we don't need to have mesos running, and we can trim

Framework testing in Mesos

2014-10-12 Thread Dharmesh Kakadia
Hi, I am working on a tiny experimental framework for Mesos. I was wondering what is the recommended way of writing testcases for framework testing. I looked at the several existing frameworks, but its still not clear to me. I understand that I might be able to test executor functionality in isola