Build failed in Jenkins: mesos-reviewbot #4023

See -- [...truncated 5528 lines...] rm -f state/.deps/.dirstamp rm -rf hook/.libs hook/_libs rm -f slave/containerizer/isolators/posix/*.lo rm -f state/.dirstamp rm -f slave/containerizer/mesos/*.o rm -rf

Re: spark-ec2 licensing clarification

Thanks Shivaram. Yeah that would be great. The location seems to cause confusion. re: PR, I'm not comfortable doing this - I assume that the commits are from Spark contributors who would be happy for their contribution to be licensed under Apache 2.0, but this is an assumption. So while it's a si

Re: Review Request 30812: Updated the allocator in Master::addSlave using slave->totalResources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30812/#review71755 --- Patch looks great! Reviews applied: [30812] All tests passed. - M

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/#review71751 --- Bad patch! Reviews applied: [30509, 30510] Failed command: ./suppo

Jenkins build is back to normal : mesos-reviewbot #4021

See

Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as mesos/slave/isolator.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/ --- (Updated Feb. 9, 2015, 9:53 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 29781: Exposed type_utils.hpp as include/mesos/type_utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29781/ --- (Updated Feb. 9, 2015, 9:53 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 30338: Introduced ExecutorRunState struct for Isolators and Launchers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/ --- (Updated Feb. 9, 2015, 9:53 p.m.) Review request for mesos, Ian Downes, Niklas

Build failed in Jenkins: mesos-reviewbot #4020

See -- [...truncated 5482 lines...] rm -rf examples/.libs examples/_libs rm -f tests/.deps/.dirstamp rm -f slave/containerizer/mesos/*.lo rm -f tests/.dirstamp rm -f state/*.o rm -f tests/common/.deps/.di

Re: Review Request 30338: Introduced ExecutorRunState struct for Isolators and Launchers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/#review71739 --- src/slave/containerizer/isolator.hpp

Re: Review Request 29607: Disabled installing module libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29607/ --- (Updated Feb. 9, 2015, 9:40 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 30052: Exposed Hook headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30052/ --- (Updated Feb. 9, 2015, 9:40 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 29606: Exposed authentication headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/ --- (Updated Feb. 9, 2015, 9:39 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 29605: Moved authentication messages to mesos/authentication.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29605/ --- (Updated Feb. 9, 2015, 9:39 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as mesos/slave/isolator.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/ --- (Updated Feb. 9, 2015, 9:38 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 29604: Exposed module/isolator.hpp for out-of-tree module building.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29604/ --- (Updated Feb. 9, 2015, 9:38 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 30338: Introduced ExecutorRunState struct for Isolators and Launchers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/ --- (Updated Feb. 9, 2015, 9:38 p.m.) Review request for mesos, Ian Downes, Niklas

Re: Review Request 29781: Exposed type_utils.hpp as include/mesos/type_utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29781/ --- (Updated Feb. 9, 2015, 9:38 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 29780: Moved operators for internal protobufs to messages/messages.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29780/ --- (Updated Feb. 9, 2015, 9:37 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29598/ --- (Updated Feb. 9, 2015, 9:37 p.m.) Review request for mesos, Niklas Nielsen, Til

Re: Review Request 30808: Fix high CPU bug. MESOS-2325.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30808/ --- (Updated Feb. 10, 2015, 2:22 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as mesos/slave/isolator.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/#review71743 --- Ship it! - Niklas Nielsen On Feb. 4, 2015, 7:15 p.m., Kapil Arya

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/ --- (Updated Feb. 10, 2015, 1:13 a.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 29605: Moved authentication messages to mesos/authentication.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29605/#review71731 --- Ship it! src/Makefile.am

Re: Review Request 30052: Exposed Hook headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30052/#review71738 --- Ship it! Ship It! - Timothy Chen On Feb. 5, 2015, 3:16 a.m., Kap

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/ --- (Updated Feb. 10, 2015, 1:09 a.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 29606: Exposed authentication headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/#review71733 --- Ship it! src/Makefile.am

Review Request 30812: Updated the allocator in Master::addSlave using slave->totalResources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30812/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 29781: Exposed type_utils.hpp as include/mesos/type_utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29781/#review71728 --- Ship it! src/common/type_utils.hpp

Re: Review Request 30052: Exposed Hook headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30052/#review71734 --- Ship it! Ship It! - Niklas Nielsen On Feb. 4, 2015, 7:16 p.m., K

Re: Review Request 29598: Moved Modules protobuf to mesos/modules.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29598/#review71706 --- Ship it! src/Makefile.am

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

> On Feb. 9, 2015, 8:24 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1157 > > > > > > Why is this a CHECK? What is the guarantee that a container won't be > > cleaned up? Added a

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

> On Feb. 2, 2015, 9:20 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1161-1167 > > > > > > How can we ensure that such a filesystem isolator is being used? > > Shouldn't all of t

Re: Review Request 30808: Fix high CPU bug. MESOS-2325.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30808/#review71723 --- 3rdparty/libprocess/src/clock.cpp

spark-ec2 licensing clarification

Hi guys, Are there any plans to add licensing information to the mesos/spark-ec2 repo? I'd assumed it would be Apache 2.0 but then noticed there's no info in the repo. Background: https://issues.apache.org/jira/browse/SPARK-5676 Regards, Florian

Review Request 30808: Fix high CPU bug. MESOS-2325.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30808/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, Niklas Nielsen,

Re: Review Request 30508: Prepare persistent volumes in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/#review71718 --- Bad patch! Reviews applied: [30283, 30298, 28781, 30386, 30349] Fa

Re: Review Request 30509: Added executor working directory to Container struct in Mesos containerizer.

> On Feb. 5, 2015, 1:24 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 260 > > > > > > I wonder if we should consolidate our terminalogy for the working > > directory. > > I've

Re: Review Request 27531: Update Master metrics to match task source and reason scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27531/#review71715 --- src/master/master.cpp

Re: Review Request 30601: Updated slave to use Executor/Task grace period, with a maximum.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30601/#review71696 --- Ship it! include/mesos/mesos.proto

Re: Review Request 27531: Update Master metrics to match task source and reason scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27531/ --- (Updated Feb. 9, 2015, 2:39 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 30508: Prepare persistent volumes in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/ --- (Updated Feb. 9, 2015, 10:37 p.m.) Review request for mesos, Ben Mahler, Michae

Re: Review Request 30508: Prepare persistent volumes in slave.

> On Feb. 9, 2015, 8:12 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 3765 > > > > > > also, add a check for persistence? This is not needed because the if guard above should have already verified it. - Jie

Re: Review Request 30592: Etcd integration test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30592/#review71710 --- src/tests/etcd_tests.cpp

Re: Scaling Proposal: MAINTAINERS Files

Good point for "MAINTAINERS" -- Jiang Yan Xu @xujyan On Mon, Feb 9, 2015 at 12:05 PM, Vinod Kone wrote: > I like MAINTAINERS because it sounds less authoritative than OWNERS. > > FWIW, maintainers is also a well understood and well used term (e.g: > https://www.kern

Re: Review Request 30784: Fixed flaky test MasterAllocatorTest/0.OutOfOrderDispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30784/#review71698 --- Bad patch! Reviews applied: [30784] Failed command: ./support/appl

Re: Review Request 30583: Fixed MESOS_RECOVERY_TIMEOUT to be based on the flag value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30583/#review71695 --- src/slave/containerizer/containerizer.cpp

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71694 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2015, 2:14 a.m., Ben M

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

> On Feb. 4, 2015, 11:55 p.m., Niklas Nielsen wrote: > > src/slave/flags.hpp, lines 133-136 > > > > > > Could we include that this is the inner most, first and/or the > > effective grace period (taken that we have a h

Re: Review Request 27531: Update Master metrics to match task source and reason scheme.

> On Feb. 6, 2015, 6:56 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 3601 > > > > > > Looks like you missed updating metrics here? > > > > Now that I think about it, it's worthwhile to consolidate

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/#review71690 --- tests? src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 30508: Prepare persistent volumes in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/#review71689 --- tests? src/slave/slave.cpp

Re: Review Request 30784: Fixed flaky test MasterAllocatorTest/0.OutOfOrderDispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30784/#review71688 --- Ship it! Ship It! - Ben Mahler On Feb. 9, 2015, 8:08 p.m., Jiang

Re: Review Request 30784: Fixed flaky test MasterAllocatorTest/0.OutOfOrderDispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30784/ --- (Updated Feb. 9, 2015, 12:08 p.m.) Review request for mesos and Ben Mahler. C

Re: Scaling Proposal: MAINTAINERS Files

I like MAINTAINERS because it sounds less authoritative than OWNERS. FWIW, maintainers is also a well understood and well used term (e.g: https://www.kernel.org/doc/linux/MAINTAINERS, https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins#HostingPlugins-AddingMaintainerInformation ) On Sun,

Re: Review Request 30609: Added os::lstatsize().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609/#review71686 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Mesos crash reporting tool

It would be nice if we auto-packaged up backtraces so they could be easily manually (Or automatically if an organization allows) be sent to support lines for debugging. Clang, GCC both have this sort of behavior built into their drivers. We could also borrow from web browsers potentially for this s

Re: Scaling Proposal: MAINTAINERS Files

+1 It makes sense as the next step to help ensure quality, like to see it more documented as well. Will be curious about the maintainer process and discussions. Tim On Tue, Feb 10, 2015 at 3:49 AM, Jie Yu wrote: > +1 > > On Fri, Feb 6, 2015 at 12:48 PM, Benjamin Mahler > wrote: > >> Hi all, >>

Mesos crash reporting tool

Hi everyone, Has anyone worked on crash report tooling for Mesos clusters? As a part of our testing (both internally and for testing of public RC's) been looking at tools we can run to 1) monitor running mesos processes (unusual behavior in use of file descriptors, and cpu load etc) 2) To grab inf

Re: Scaling Proposal: MAINTAINERS Files

+1 On Fri, Feb 6, 2015 at 12:48 PM, Benjamin Mahler wrote: > Hi all, > > I have been chatting with a few committers and we'd like to consider adding > the concept of MAINTAINERS files to coincide with our "shepherds" concept, > introduced here: > > > http://mail-archives.apache.org/mod_mbox/meso

Re: Review Request 30792: Additonal use case for "auto" in C++ style guide: shared pointer creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review71681 --- The shared_ptr -> shared_ptr auto case seems good. The make_shared

Re: Review Request 28809: Started to maintain and checkpoint persisted resource in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28809/ --- (Updated Feb. 9, 2015, 7:33 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 30784: Fixed flaky test MasterAllocatorTest/0.OutOfOrderDispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30784/#review71674 --- src/tests/master_allocator_tests.cpp

Re: Review Request 28809: Started to maintain and checkpoint persisted resource in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28809/#review71666 --- Ship it! src/slave/slave.cpp

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/#review71669 --- Patch looks great! Reviews applied: [30509, 30510] All tests passe

Re: Review Request 30580: Updated the graceful shutdown documentation and naming.

> On Feb. 4, 2015, 11:55 p.m., Niklas Nielsen wrote: > > src/slave/flags.hpp, lines 133-136 > > > > > > Could we include that this is the inner most, first and/or the > > effective grace period (taken that we have a h

Re: Review Request 29883: Added /master/slaves endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71659 --- src/master/http.cpp

Re: Review Request 30508: Prepare persistent volumes in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/#review71650 --- Bad patch! Reviews applied: [30283, 30298, 28781, 30386, 30349] Fa

Re: Review Request 30508: Prepare persistent volumes in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30508/ --- (Updated Feb. 9, 2015, 6 p.m.) Review request for mesos, Ben Mahler, Michael Pa

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/ --- (Updated Feb. 9, 2015, 6 p.m.) Review request for mesos, Ben Mahler, Ian Downes

Re: Review Request 30509: Added executor working directory to Container struct in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30509/ --- (Updated Feb. 9, 2015, 6 p.m.) Review request for mesos, Ben Mahler, Ian Downes

Re: Review Request 28809: Started to maintain and checkpoint persisted resource in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28809/ --- (Updated Feb. 9, 2015, 5:59 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 29883: Added /master/slaves endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71647 --- Patch looks great! Reviews applied: [29883] All tests passed. - M

Final week for #MesosCon 2015 CFP and early-bird registration

Just a friendly-reminder, two deadlines are fast-approaching for #MesosCon on this upcoming Saturday, February 14th: The call for speaking proposals: http://events.linuxfoundation.org/events/mesoscon/program/cfp Early-bird registration: http://events.linuxfoundation.org/events/mesoscon/attend/re

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review71642 --- Patch looks great! Reviews applied: [30612] All tests passed. - M

Re: Review Request 29883: Added /master/slaves endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/ --- (Updated Feb. 9, 2015, 5:49 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated Feb. 9, 2015, 5:38 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 29883: Added /master/slaves endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71639 --- Ship it! src/master/http.cpp

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review71636 --- Ship it! src/master/http.cpp

Re: Review Request 30792: Additonal use case for "auto" in C++ style guide: shared pointer creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review71633 --- Ship it! IMO, a very good example! - Alexander Rukletsov On Feb.

Re: GPU computing resource add into Mesos

Hi dev, There is a patch ready for review, I'm not sure who can help to review it but any comments are welcome. https://reviews.apache.org/r/30736/ Chester 2015/2/5 下午12:52 於 "Adam Bordelon" 寫道： > Added chesterkuo. You should be able to assign issues to yourself now. > > On Wed, Feb 4, 2015 at

Re: Review Request 30728: Cleaned up extra declaration and whitespace.

> On Feb. 6, 2015, 3:44 p.m., Kapil Arya wrote: > > src/tests/module.hpp, line 58 > > > > > > Do we have it in our style sheet to not use two spaces when followed by > > a period. Some people prefer two spaces to one

Re: Review Request 30792: Additonal use case for "auto" in C++ style guide: shared pointer creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review71620 --- Patch looks great! Reviews applied: [30792] All tests passed. - M

Re: Review Request 30792: Additonal use case for "auto" in C++ style guide: shared pointer creation.

All, as stated in the review request below, I propose that we update our C++ style guide to explicitly allow “auto” for shared pointer creations. I suggest that any similar situation should be included. In general, if the exact same type that would be written on the left is already fully expres

Review Request 30792: Additonal use case for "auto" in C++ style guide: shared pointer creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/ --- Review request for mesos. Repository: mesos Description --- Explicitly a