Re: Review Request 30606: Added net::contentLength() to query "content-length" field from HTTP header.

2015-02-18 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30606/#review73096 --- 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73093 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73092 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73089 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31162/#review73087 --- Patch looks great! Reviews applied: [31162] All tests passed. - M

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review73085 --- Bad patch! Reviews applied: [29507] Failed command: ./support/appl

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73083 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 29748: Added tests for Framework Reservation.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review73079 --- Patch looks great! Reviews applied: [29742, 30911, 30873, 28698, 30

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Benjamin Hindman
> On Feb. 19, 2015, 2:28 a.m., Jie Yu wrote: > > src/tests/state_tests.cpp, lines 86-87 > > > > > > typedef Registry::Slaves Slaves; > > typedef Registry::Slave Slave; This reverts the code to it's original state w

Re: Review Request 31038: Updated master::Slave construction to consider RESERVE.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31038/ --- (Updated Feb. 19, 2015, 2:55 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 30875: Updated the slave checkpointing to consider Resource::ReserverType.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30875/ --- (Updated Feb. 19, 2015, 2:55 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 28698: Updated Resources to consider Resource::ReserverType.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28698/ --- (Updated Feb. 19, 2015, 2:55 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 30874: Updated the allocator accounting to consider Resource::ReserverType.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30874/ --- (Updated Feb. 19, 2015, 2:55 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29856: Handled Offer::Operations RESERVE and UNRESERVE in Resources::apply.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29856/ --- (Updated Feb. 19, 2015, 2:55 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 31039: Updated validation for checkpointed resources during slave recovery to consider RESERVE.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31039/ --- (Updated Feb. 19, 2015, 2:55 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 30361: Handled Offer::Operations RESERVE and UNRESERVE in Master::_accept.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30361/ --- (Updated Feb. 19, 2015, 2:55 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 30911: Updated the filter abstraction for Resources.

2015-02-18 Thread Michael Park
> On Feb. 16, 2015, 11:43 p.m., Jie Yu wrote: > > include/mesos/resources.hpp, lines 155-161 > > > > > > I don't think we should remove these two helper functions as they are > > quite convinent to use. (just like we

Re: Review Request 30911: Updated the filter abstraction for Resources.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30911/ --- (Updated Feb. 19, 2015, 2:54 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 30015: Adding methods to fetch the number of hard links associated with a path as well as the limit.

2015-02-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30015/#review73076 --- Nice, can you split the patches for `lstat` and `pathconf` please? I

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-02-18 Thread Ben Mahler
> On Feb. 18, 2015, 7:38 p.m., Niklas Nielsen wrote: > > Let's get tests wired up before committing this :) > > Adam B wrote: > Sure thing. Adding tests in my subsequent patch where we will pass the > master's timeout values on to the slave. Will post that very soon. Can you do it in one p

Re: Review Request 28775: Added tests for task validation.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28775/#review73069 --- Patch looks great! Reviews applied: [28775] All tests passed. - M

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31162/#review73066 --- The high level comment is: you should only put the namespace hacks i

Re: Review Request 30978: Updated documentation for explicit acknowledgement API change.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30978/#review73065 --- Patch looks great! Reviews applied: [30970, 30971, 30972, 30973, 30

Re: Review Request 30911: Updated the filter abstraction for Resources.

2015-02-18 Thread Michael Park
> On Feb. 15, 2015, 4:55 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 436-437 > > > > > > Is this still relevant? I think so, did you find somewhere where we do this already?

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73047 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31162/ --- (Updated Feb. 18, 2015, 7:59 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Niklas Nielsen
> On Feb. 18, 2015, 2:42 p.m., Jie Yu wrote: > > include/mesos/authentication/authentication.hpp, lines 25-27 > > > > > > We don't do "using namespace" in headers. > > Kapil Arya wrote: > Yes, but this was to avoid

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-02-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated Feb. 18, 2015, 4:33 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 29748: Added tests for Framework Reservation.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated Feb. 19, 2015, 12:06 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 28775: Added tests for task validation.

2015-02-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28775/ --- (Updated Feb. 19, 2015, 12:05 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29406: Introduce libevent ssl socket.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review73032 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529, 29

Re: Review Request 30609: Added os::lstatsize().

2015-02-18 Thread Ben Mahler
> On Feb. 11, 2015, 12:08 a.m., Ben Mahler wrote: > > It might be time to introduce os::stat and os::lstat wrappers to avoid > > needing to introduce so many special case functions. > > Bernd Mathiske wrote: > That would reduce portability. > > Ben Mahler wrote: > Oh? Could you elabora

Re: Review Request 30978: Updated documentation for explicit acknowledgement API change.

2015-02-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30978/ --- (Updated Feb. 18, 2015, 11:44 p.m.) Review request for mesos, Niklas Nielsen, V

Re: Review Request 30976: Updated test frameworks for explicit acknowledgements.

2015-02-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30976/ --- (Updated Feb. 18, 2015, 11:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 30971: Introduced explicit status update acknowledgements on the driver.

2015-02-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30971/ --- (Updated Feb. 18, 2015, 11:43 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30973: Updated Python bindings for explicit acknowledgements.

2015-02-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30973/ --- (Updated Feb. 18, 2015, 11:43 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30972: Updated Java bindings for explicit acknowledgements.

2015-02-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30972/ --- (Updated Feb. 18, 2015, 11:43 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 29406: Introduce libevent ssl socket.

2015-02-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated Feb. 18, 2015, 11:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31162/ --- (Updated Feb. 18, 2015, 5:26 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Kapil Arya
> On Feb. 18, 2015, 5:42 p.m., Jie Yu wrote: > > include/mesos/authentication/authentication.hpp, lines 25-27 > > > > > > We don't do "using namespace" in headers. > > Kapil Arya wrote: > Yes, but this was to avoid

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Jie Yu
> On Feb. 18, 2015, 10:42 p.m., Jie Yu wrote: > > include/mesos/authentication/authentication.hpp, lines 25-27 > > > > > > We don't do "using namespace" in headers. > > Kapil Arya wrote: > Yes, but this was to avoi

Help us review #MesosCon 2015 proposals

2015-02-18 Thread Dave Lester
A total of 63 proposals were submitted for #MesosCon[1], up significantly from 24 submitted for last year’s conference. Similar to last year, the MesosCon program committee is opening these proposals up for community review/feedback to better-inform our decisions about what should be included in t

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Kapil Arya
> On Feb. 18, 2015, 5:42 p.m., Jie Yu wrote: > > include/mesos/authentication/authentication.hpp, lines 25-27 > > > > > > We don't do "using namespace" in headers. Yes, but this was to avoid changing numerous cpp files

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31162/#review73025 --- include/mesos/authentication/authentication.hpp

Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

2015-02-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31162/ --- Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, and Vinod Kone. B

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73021 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Alexander Rukletsov
> On Feb. 18, 2015, 8:16 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 3855 > > > > > > Max age of 0 seconds is hard to tell whether is a very unhealthy system > > or "no value present". Wonder if we shou

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Alexander Rojas
> On Feb. 18, 2015, 9:16 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 3855 > > > > > > Max age of 0 seconds is hard to tell whether is a very unhealthy system > > or "no value present". Wonder if we shou

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73011 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Alexander Rukletsov
> On Feb. 18, 2015, 8:16 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 3855 > > > > > > Max age of 0 seconds is hard to tell whether is a very unhealthy system > > or "no value present". Wonder if we shou

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review73003 --- The patch changed a bit since the first /state.json version. Holding

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-02-18 Thread Adam B
> On Feb. 18, 2015, 11:38 a.m., Niklas Nielsen wrote: > > Let's get tests wired up before committing this :) Sure thing. Adding tests in my subsequent patch where we will pass the master's timeout values on to the slave. Will post that very soon. - Adam -

Re: Review Request 29855: Fixed variable shadowing in module_tests.cpp.

2015-02-18 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29855/#review72996 --- Ship it! Ship It! - Niklas Nielsen On Jan. 13, 2015, 10:55 a.m.,

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72995 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-02-18 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review72992 --- Let's get tests wired up before committing this :) - Niklas Nielsen

Re: Review Request 29406: Introduce libevent ssl socket.

2015-02-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated Feb. 18, 2015, 11:35 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 31024: Changed the slave logic so that it always waits for containerizer update to finish.

2015-02-18 Thread Vinod Kone
> On Feb. 18, 2015, 6:53 p.m., Vinod Kone wrote: > > src/slave/slave.hpp, line 280 > > > > > > s/flushTasks/runTasks/ so that we don't add a new verb "flush"? > > Jie Yu wrote: > We already have 'runTask'. Sound

Re: Review Request 31024: Changed the slave logic so that it always waits for containerizer update to finish.

2015-02-18 Thread Jie Yu
> On Feb. 18, 2015, 6:53 p.m., Vinod Kone wrote: > > src/slave/slave.hpp, line 280 > > > > > > s/flushTasks/runTasks/ so that we don't add a new verb "flush"? We already have 'runTask'. Sounds a little confusing if

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Vinod Kone
> On Jan. 28, 2015, 8:33 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 4193-4203 > > > > > > IIRC, sending an AuthenticationErrorMessage here causes the driver to > > simply retry the authentication and t

Re: Review Request 31024: Changed the slave logic so that it always waits for containerizer update to finish.

2015-02-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31024/#review72975 --- Ship it! nice tests. src/slave/slave.hpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72974 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 30736: Add GPGPU resouce support

2015-02-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30736/#review72973 --- Sorry I'm just getting around to looking at this. Been busy with the

Re: Review Request 30545: cgroups: added support to listen on memory pressures.

2015-02-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30545/#review72971 --- First pass, haven't looked at the tests yet. The main issue is that

Re: Review Request 31114: Fixed flaky MasterTest.SlavesEndpointTwoSlaves caused by incorrect FUTURE_PROTOBUF usage.

2015-02-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31114/#review72972 --- Ship it! Ship It! - Vinod Kone On Feb. 18, 2015, 9:05 a.m., Alex

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72970 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review72968 --- Patch looks great! Reviews applied: [30074] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72967 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/ --- (Updated Feb. 18, 2015, 4:09 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/ --- (Updated Feb. 18, 2015, 4:01 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72963 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/#review72959 --- Patch looks great! Reviews applied: [31011] All tests passed. - M

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review72957 --- Patch looks great! Reviews applied: [30074] All tests passed. - M

Re: Review Request 30774: Fetcher Cache

2015-02-18 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated Feb. 18, 2015, 4:43 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value.

2015-02-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/#review72951 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 18, 2015, 11:32

Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value.

2015-02-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/ --- (Updated Feb. 18, 2015, 11:32 a.m.) Review request for mesos and Till Toenshoff

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review72949 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 18, 2015, 10:36

Re: Review Request 31114: Fixed flaky MasterTest.SlavesEndpointTwoSlaves caused by incorrect FUTURE_PROTOBUF usage.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31114/#review72948 --- Patch looks great! Reviews applied: [31114] All tests passed. - M

Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value.

2015-02-18 Thread Alexander Rukletsov
> On Feb. 17, 2015, 6:39 p.m., Zameer Manji wrote: > > Would it be possible to handle all default values in all protobufs in a > > generic manner? For example the 'role' field of FrameworkInfo has the same > > problem: > > https://github.com/apache/mesos/blob/1efdf1d69373cca7903bc06847f1c44a91

Re: Review Request 29497: Add std::initializer_list to the whitelist of C++11 features.

2015-02-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29497/#review72944 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 17, 2015, 10:55

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72942 --- src/master/master.cpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Adam B
> On Feb. 16, 2015, 11:37 p.m., Adam B wrote: > > src/authentication/cram_md5/authenticator.hpp, line 533 > > > > > > Should this still `process::terminate(process, false)` if the short > > term fix is now in `~CRAMM

Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint

2015-02-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/ --- (Updated Feb. 18, 2015, 11:36 a.m.) Review request for mesos, Niklas Nielsen an

Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/#review72943 --- Patch looks great! Reviews applied: [31011] All tests passed. - M

Re: Review Request 30995: Added Access class for endpoint's control in the Files class.

2015-02-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30995/#review72927 --- First pass, found some minor typos/nits. Still considering whether w

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Adam B
> On Jan. 28, 2015, 12:33 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 4193-4203 > > > > > > IIRC, sending an AuthenticationErrorMessage here causes the driver to > > simply retry the authentication and

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72932 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Regarding starting hacking

2015-02-18 Thread Timothy Chen
I suggest you can also search for JIRA tickets on Mesos with the label "newbie" to start out with. https://issues.apache.org/jira/browse/MESOS-2314?jql=project%20%3D%20MESOS%20AND%20labels%20%3D%20newbie Tim On Wed, Feb 18, 2015 at 1:07 AM, Atri Sharma wrote: > Hi Ben, > > Thanks for your email

Re: Regarding starting hacking

2015-02-18 Thread Atri Sharma
Hi Ben, Thanks for your email. If not performance, is there any other area where I could focus on? On Wed, Feb 18, 2015 at 2:33 PM, Benjamin Mahler wrote: > We generally don't have a lot of performance improvement work, but one > thing that came up recently for large clusters was: > https://is

Re: Review Request 31114: Fixed flaky MasterTest.SlavesEndpointTwoSlaves caused by incorrect FUTURE_PROTOBUF usage.

2015-02-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31114/ --- (Updated Feb. 18, 2015, 10:05 a.m.) Review request for mesos, Ben Mahler, Till

Re: Review Request 31114: Fixed flaky MasterTest.SlavesEndpointTwoSlaves caused by incorrect FUTURE_PROTOBUF usage.

2015-02-18 Thread Alexander Rojas
> On Feb. 17, 2015, 7:13 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, lines 1616-1624 > > > > > > Hmm. I don't understand the fix here. > > > > First off, any expectations should be set *before* th

Re: Regarding starting hacking

2015-02-18 Thread Benjamin Mahler
We generally don't have a lot of performance improvement work, but one thing that came up recently for large clusters was: https://issues.apache.org/jira/browse/MESOS-2353 On Tue, Feb 17, 2015 at 11:10 PM, Atri Sharma wrote: > Hi all, > > I am looking into starting hacking Mesos and concentratin

Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value.

2015-02-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/ --- (Updated Feb. 18, 2015, 8:50 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/#review72924 --- Patch looks great! Reviews applied: [31011] All tests passed. - M

Re: Review Request 30774: Fetcher Cache

2015-02-18 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated Feb. 18, 2015, 12:28 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 30606: Added net::contentLength() to query "content-length" field from HTTP header.

2015-02-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30606/#review72923 --- Do we have test for this? - Timothy Chen On Feb. 18, 2015, 8:01 a

Re: Review Request 31125: MESOS-2357 - Improve docker ps output parsing

2015-02-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31125/#review72922 --- src/docker/docker.cpp

Re: Review Request 30774: Fetcher Cache

2015-02-18 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated Feb. 18, 2015, 12:07 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 30606: Added net::contentLength() to query "content-length" field from HTTP header.

2015-02-18 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30606/ --- (Updated Feb. 18, 2015, 12:01 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-02-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review72921 --- Patch looks great! Reviews applied: [27760] All tests passed. - M