> On Feb. 15, 2015, 4:55 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 436-437 > > <https://reviews.apache.org/r/30911/diff/2/?file=863977#file863977line436> > > > > Is this still relevant?
I think so, did you find somewhere where we do this already? > On Feb. 15, 2015, 4:55 p.m., Alexander Rukletsov wrote: > > include/mesos/resources.hpp, lines 352-353 > > <https://reviews.apache.org/r/30911/diff/2/?file=863975#file863975line352> > > > > Could you please help me understanding which `RepeatedPtrField` support > > is meant here? We allow implicit conversion between `Resources` and `google::protobuf::RepeatedPtrField<Resource>` for easy use across the codebase. If we introduce `Resources::filter`, we would need to explicitly construct a `Resources` object. Member function: `Resources(task.resources()).filter(predicate);` Non-member function: `filter(predicate, task.resource());` Jie says we prefer member functions in Mesos though so I'll make it a member function. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30911/#review72554 ----------------------------------------------------------- On Feb. 14, 2015, 12:11 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30911/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2015, 12:11 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2348 > https://issues.apache.org/jira/browse/MESOS-2348 > > > Repository: mesos > > > Description > ------- > > See [JIRA Ticket](https://issues.apache.org/jira/browse/MESOS-2348). > > > Diffs > ----- > > include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0 > src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f > src/master/allocator/mesos/hierarchical.hpp > 2680d6231927867d5a8d75cbc42b81d6c75fc7f2 > src/master/master.hpp 6a39df04514c756415354fae66c5835ada191c52 > src/master/validation.cpp acc35b25c93f2d3900d79c3070b1d681416ed66b > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > src/tests/hierarchical_allocator_tests.cpp > eeecfb64540b16666915074aaffaa5d506b203bc > src/tests/resources_tests.cpp 3f98782fd437dba808d720bf8e9b94b8fa7e0feb > > Diff: https://reviews.apache.org/r/30911/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
