Re: Orphan links in Docs

2015-03-01 Thread Dave Lester
Hi Dharmesh, Sounds great, thanks for taking a closer look! Can you attach your patch to one of the JIRA issues below and pass along the link? I can help review it and see that it's committed. Thanks! Dave On Sun, Mar 1, 2015, at 01:53 AM, Dharmesh Kakadia wrote: > Hi Dave, > > I have finally g

Review Request 31614: Added a comment about uses of FetcherProcess::cache withotu 'defer'.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31614/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description --

Review Request 31613: Added a comment to help suss out potential bug.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31613/ --- Review request for mesos. Repository: mesos Description --- See summary.

Re: Review Request 31613: Added a comment to help suss out potential bug.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31613/ --- (Updated March 2, 2015, 6:20 a.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 31612: Release a failed cache entry's space properly.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31612/ --- (Updated March 2, 2015, 6:19 a.m.) Review request for mesos and Bernd Mathiske.

Review Request 31612: Release a failed cache entry's space properly.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31612/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description --

Review Request 31610: Simplified 'cleanupCache' by adjusting cache sizes earlier.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31610/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description --

Review Request 31611: Store the cache directory within each Cache::Entry.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31611/ --- Review request for mesos. Repository: mesos Description --- This simplif

Re: Review Request 31609: Simplifying FetcherProcess::cleanupCache.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31609/ --- (Updated March 2, 2015, 5:48 a.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 31603: Cleaned up a few style issues.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31603/ --- (Updated March 2, 2015, 5:48 a.m.) Review request for mesos and Bernd Mathiske.

Review Request 31609: Simplifying FetcherProcess::cleanupCache.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31609/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description --

Re: Review Request 31603: Cleaned up a few style issues.

2015-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31603/#review74714 --- Bad patch! Reviews applied: [31603] Failed command: ./support/appl

Re: Review Request 31602: Changes necessary for building with gcc 4.4.

2015-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31602/#review74713 --- Patch looks great! Reviews applied: [30606, 30609, 30774, 31602] A

Review Request 31603: Cleaned up a few style issues.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31603/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description --

Review Request 31602: Changes necessary for building with gcc 4.4.

2015-03-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31602/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description --

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 1, 2015, 12:27 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 31596: Fixed broken image links on external-containerizer documentation

2015-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31596/#review74706 --- Patch looks great! Reviews applied: [31596] All tests passed. - M

Re: Review Request 31595: Changed mesos-frameworks torque page dead link

2015-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31595/#review74704 --- Patch looks great! Reviews applied: [31595] All tests passed. - M

Review Request 31596: Fixed broken image links on external-containerizer documentation

2015-03-01 Thread Palak Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31596/ --- Review request for mesos. Bugs: MESOS-2220 https://issues.apache.org/jira/b

Review Request 31595: Changed mesos-frameworks torque page dead link

2015-03-01 Thread Palak Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31595/ --- Review request for mesos. Bugs: MESOS-2311 https://issues.apache.org/jira/b

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review74703 --- Patch looks great! Reviews applied: [30606, 30609, 30774] All test

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 1, 2015, 7:42 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review74695 --- Bad patch! Reviews applied: [30606, 30609, 30774] Failed command:

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 1, 2015, 2:35 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Orphan links in Docs

2015-03-01 Thread Dharmesh Kakadia
Hi Dave, I have finally got some time to look at the regex you mentioned and indeed thats what was the issue. I have fixed it but I don't know how to send review request for the "site". I suppose "site" is not maintained in the "repo". Can you please help me with that? Actual change is just one ch