Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review78704 --- src/messages/messages.proto

Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/#review78707 --- Patch looks great! Reviews applied: [32744] All tests passed. -

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review78703 --- Looks good Cody, just curious about many of the includes in the

Re: Review Request 30961: Enabled label decorator to override.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/ --- (Updated April 2, 2015, 2:39 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 31268: Wired up test allocator to allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review78712 --- Ship it! Thanks for splitting these reviews in reviewable chunks!

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78719 --- Patch looks great! Reviews applied: [32654] All tests passed. -

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review78721 --- src/webui/master/static/css/mesos.css

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/ --- (Updated April 2, 2015, 3:26 p.m.) Review request for mesos. Bugs:

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/#review78710 --- src/tests/master_allocator_tests.cpp

Re: Review Request 31265: Provided a factory for allocator in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/#review78711 --- src/master/allocator/mesos/allocator.hpp

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review78715 --- src/webui/master/static/css/mesos.css

Review Request 32796: Only update docker container when resources differs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32796/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.

Re: Review Request 32798: Add test to verify executor clean up in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32798/#review78749 --- Patch looks great! Reviews applied: [32796, 32797, 32798] All

Review Request 32805: Terminated the perf subprocess once the parent exits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32805/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs:

Re: Review Request 32805: Terminated the perf subprocess once the parent exits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32805/#review78757 --- Bad patch! Reviews applied: [32805] Failed command:

Review Request 32798: Add test to verify executor clean up in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32798/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.

Review Request 32797: Kill the executor when docker container is destroyed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32797/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review78741 --- Patch looks great! Reviews applied: [32750] All tests passed. -

Re: Review Request 30961: Enabled label decorator to override.

On March 30, 2015, 3:23 a.m., Adam B wrote: Minor cleanup/suggestions, but otherwise good. We'll definitely need to document te module(-manager) API change of overriding the label set instead of merging. This should probably go in the upgrades doc? Thanks for the review Adam! Great

Re: Review Request 32694: Set death signal for forked du processes for posix/disk isolator.

On April 2, 2015, 6:40 p.m., Ben Mahler wrote: src/slave/containerizer/isolators/posix/disk.cpp, lines 363-367 https://reviews.apache.org/r/32694/diff/3/?file=912579#file912579line363 I'm still not sure why this is best-effort, since we never expect this to fail, can we just

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/ --- (Updated April 2, 2015, 7:06 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/ --- (Updated April 2, 2015, 7:06 p.m.) Review request for mesos, Jie Yu and Cong

Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78666 --- Ship it! Ship It! - Jie Yu On April 1, 2015, 11 p.m., Paul

Re: Review Request 32698: Used the argv version of subprocess for linux perf utilities.

On April 1, 2015, 10:38 p.m., Ben Mahler wrote: src/linux/perf.cpp, line 131 https://reviews.apache.org/r/32698/diff/2/?file=912580#file912580line131 Do you need the named 'argv' or can you return the initializer list directly? Yes, the following code does not compile on

Build failed in Jenkins: mesos-reviewbot #4951

See https://builds.apache.org/job/mesos-reviewbot/4951/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on H11 (Ubuntu ubuntu) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git rev-parse

Build failed in Jenkins: mesos-reviewbot #4952

See https://builds.apache.org/job/mesos-reviewbot/4952/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu-1 (docker Ubuntu ubuntu ubuntu1) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78674 --- Ship it! src/tests/port_mapping_tests.cpp

Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/#review78669 --- Ship it! This looks great! Just some nits!

Build failed in Jenkins: mesos-reviewbot #4953

See https://builds.apache.org/job/mesos-reviewbot/4953/ -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu-1 (docker Ubuntu ubuntu ubuntu1) in workspace https://builds.apache.org/job/mesos-reviewbot/ws/ git

Re: Review Request 32694: Set death signal for forked du processes for posix/disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/#review78679 --- Ship it! Ship It! - Ian Downes On April 1, 2015, 12:40 p.m.,

Re: Review Request 32699: Set death signal for the perf subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32699/#review78678 --- src/linux/perf.cpp

Re: Review Request 32558: Improve compile time of mesos by splitting flags

On March 27, 2015, 11:43 a.m., Joerg Schad wrote: LGTM Great effort! On my machine (Apple LLVM version 6.0 (clang-600.0.56)) on the current master this reduced 'make -j8' from real5m8.217s, user 25m56.168s, sys 2m47.850s to real4m28.660s, user 23m0.723s, sys

Re: Review Request 31267: Added a test allocator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/#review78694 --- Ship it! src/Makefile.am

Re: Review Request 31262: Moved allocator actions before TestAllocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31262/#review78696 --- Ship it! Ship It! - Vinod Kone On April 1, 2015, 2:27 p.m.,

Re: Review Request 32694: Set death signal for forked du processes for posix/disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/#review78697 --- Ship it! src/slave/containerizer/isolators/posix/disk.cpp

Re: Review Request 32699: Set death signal for the perf subprocess.

On April 2, 2015, 5:24 p.m., Ian Downes wrote: src/linux/perf.cpp, line 188 https://reviews.apache.org/r/32699/diff/1/?file=911392#file911392line188 I thought about this again, and it won't be sufficient for perf: we use perf with a child sleep process to control the sample

Re: Review Request 31266: Added support for allocator modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31266/#review78693 --- Ship it! Ship It! - Vinod Kone On April 1, 2015, 2:26 p.m.,

Re: Review Request 31775: Removed Master::Flags dependency from Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31775/#review78689 --- Ship it! Ship It! - Vinod Kone On April 1, 2015, 2:24 p.m.,

Jenkins build is back to normal : mesos-reviewbot #4954

See https://builds.apache.org/job/mesos-reviewbot/4954/

Re: Review Request 32699: Set death signal for the perf subprocess.

On April 2, 2015, 5:24 p.m., Ian Downes wrote: src/linux/perf.cpp, line 188 https://reviews.apache.org/r/32699/diff/1/?file=911392#file911392line188 I thought about this again, and it won't be sufficient for perf: we use perf with a child sleep process to control the sample

Re: Review Request 31776: Moved allocator to public headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/#review78690 --- Ship it! include/mesos/master/allocator.proto