Re: Review Request 32693: Change Http Request log level to VLOG(1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32693/#review80665 --- Ship it! Thanks! I'll try to get this committed tomorrow (assuming

Re: Review Request 32693: Change Http Request log level to VLOG(1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32693/ --- (Updated April 20, 2015, 6:53 a.m.) Review request for mesos. Summary (update

Re: Review Request 33109: Allow setting environment variables in mesos-execute

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/#review80660 --- Thanks for jumping on this. Great start, but we need to rethink the

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/#review80659 --- Ship it! LGTM, assuming we reach a consensus on the style issues. (

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

> On April 19, 2015, 10:55 p.m., Adam B wrote: > > LGTM, barring a question about ordering/synchronization. I'll let another > > committer take a look before we commit it. Would also like to see a successful ReviewBot pass. That MasterFailover segfault seems like it could be related to your de

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33208/#review80655 --- LGTM, barring a question about ordering/synchronization. I'll let an

Re: Review Request 31016: Added slave run task decorator.

> On April 11, 2015, 3:26 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 1186-1188 > > > > > > What makes this the ideal place to do the label decoration? Looks like > > this is wedged between setting up differen

Re: Review Request 31028: Added slave run task hook tests.

> On April 11, 2015, 3:54 a.m., Adam B wrote: > > src/examples/test_hook_module.cpp, lines 80-85 > > > > > > Create variables like testLabelKey, etc. above so it's easier to track > > all these label k/v strings. > >

Re: Review Request 30961: Enabled label decorator to override.

> On April 8, 2015, 5:31 p.m., Adam B wrote: > > src/examples/test_hook_module.cpp, line 36 > > > > > > Unused? Or should you check that the value being removed is what you > > expect? > > Niklas Nielsen wrote: >

Re: Build failed in Jenkins: Mesos » clang,docker||Hadoop,ubuntu:14.10 #154

double free @@ On Fri, Apr 17, 2015 at 3:56 PM, Benjamin Mahler wrote: > +jie > > Can you take a look? > > On Fri, Apr 17, 2015 at 3:51 PM, Apache Jenkins Server < > jenk...@builds.apache.org> wrote: > >> See < >> https://builds.apache.org/job/Mesos/COMPILER=clang,LABEL=docker%7C%7CHadoop,OS=ubu

Re: Review Request 33058: Updated test-frameworks to support principal only credential.

> On April 10, 2015, 10:15 a.m., Alexander Rojas wrote: > > I was just wondering, if the authentication can be done without a shared > > secret, why is it needed after all? While the default (CRAM MD5) authentication mechanism does rely on the plain secret on both ends, other authentication me

Re: Review Request 31265: Provided a factory for allocator in tests.

> On April 17, 2015, 1:31 p.m., Michael Park wrote: > > src/local/local.cpp, lines 141-145 > > > > > > What's the point of setting `_allocator` here? It looks like it only > > gets passed to the `new Master(...)` call

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

> On April 2, 2015, 7:58 p.m., Vinod Kone wrote: > > src/tests/master_allocator_tests.cpp, lines 96-104 > > > > > > While the TearDown() avoids flakiness by ensuring that an allocator > > process doesn't exist after a

Re: Review Request 31265: Provided a factory for allocator in tests.

> On April 17, 2015, 1:31 p.m., Michael Park wrote: > > src/tests/mesos.hpp, lines 866-874 > > > > > > An idea to avoid this: we could promote the `createAllocator` currently > > in `MasterAllocatorTest` to this file.

Jenkins build is back to normal : mesos-reviewbot #5243

See

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 19, 2015, 12:29 p.m.) Review request for mesos and Jie Yu. Bug

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 19, 2015, 12:28 p.m.) Review request for mesos and Jie Yu. Bug

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 19, 2015, 12:25 p.m.) Review request for mesos and Jie Yu. Bug

Build failed in Jenkins: mesos-reviewbot #5242

See -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu-4 (docker Ubuntu ubuntu4 ubuntu) in workspace > git

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 19, 2015, 10:31 a.m.) Review request for mesos and Jie Yu. Bug

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 19, 2015, 10:17 a.m.) Review request for mesos and Jie Yu. Bug

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 19, 2015, 10:14 a.m.) Review request for mesos and Jie Yu. Bug

Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- Review request for mesos. Repository: mesos Description --- Add a Java e