Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Dec. 19, 2014, 11:21 p.m., Adam B wrote: > > src/master/master.cpp, lines 3980-3981 > > > > > > We use @param in at least a couple of src/linux/ c++ files, and may do > > more with doxygen in the future, so ho

Re: Review Request 28781: Maintained persisted resources in master memory.

can use the version: ``` if (slave.version.isSome() && slave.version.get() >= Version(0, 22, 0)) { ... } ``` You may want to punt with a TODO since we currently store a plain std::string. This was because Version doesn't yet support labe

Re: Review Request 29274: Added Resource::Operation to mesos.proto.

our Transformation abstraction in resources.hpp in favor of using Operations? - Ben Mahler On Dec. 19, 2014, 10:31 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 29173: [WIP] Add dynamic reservation information to LaunchTasksMessage.

LaunchTaskMessage { ... repeated Resource::Operation operations; } ``` The nice part about this is that we can make the kinds of operations very explicit in the API, we can make the validation code very simple, and we remove the ambiguous "inference" a

Re: Review Request 28697: [WIP] Add ReservationType and ReservationInfo for dynamic reservations.

> On Dec. 19, 2014, 8:23 p.m., Ben Mahler wrote: > > This looks good Michael, one thing that I think is important to highlight > > about this approach is that we no longer "know" the static reservation for > > a dynamically reserved resource. > > > &g

Re: Review Request 28697: [WIP] Add ReservationType and ReservationInfo for dynamic reservations.

s under the role `"marathon-ads"`). Would we introduce a `static_role` or a richer `Reservation` message as Adam alluded to? Just some food for thought here. Will defer to Adam on this one, also would like to see some documentation around dynamic reservations at the top level of the `R

Re: Review Request 29234: Transformed the allocation in allocator.

> On Dec. 19, 2014, 2:53 a.m., Ben Mahler wrote: > > Mind adding a TODO on the LOG(INFO) in > > HierarchicalAllocatorProcess::transformAllocation? As it stands, we'll be > > logging no-op transformations which might be excessive. > > Jie Yu wrote: >

Re: Review Request 29234: Transformed the allocation in allocator.

HierarchicalAllocatorProcess::transformAllocation? As it stands, we'll be logging no-op transformations which might be excessive. src/master/master.cpp <https://reviews.apache.org/r/29234/#comment108832> #include for this? - Ben Mahler On Dec. 19, 2014, 2:50 a.m., J

Re: Review Request 28723: Added protobuf protocol for communicating persisted resources between master and slave.

rk. src/messages/messages.proto <https://reviews.apache.org/r/28723/#comment108825> Let's add a comment that this is sent to the slave whenever there is an acquisition or release of a persistent resource (and we probably need to piggy-back it on (re-)registration too? Maybe a TODO in this

Re: Review Request 29219: Added Network Isolator flags to configuration.md.

we've allocated all of the ephemeral port range on the slave. Feel free to make such changes separately. :) - Ben Mahler On Dec. 18, 2014, 11:04 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-m

Re: Review Request 28723: Added protobuf protocol for communicating persisted resources between master and slave.

ole()) { composite.add(DynamicReservation(r)); } else { // Error. } } ``` - Ben Mahler On Dec. 4, 2014, 10:56 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 28720: Adjusted the calculation of unused resources in _launchTasks by considering persistent disk acquisition.

ne, but up to you. src/master/master.cpp <https://reviews.apache.org/r/28720/#comment108757> Could you remove this comment once you move it up, per my other comment? src/master/master.cpp <https://reviews.apache.org/r/28720/#comment108759> Can you remove the NOTE on this

Re: Review Request 28723: Added protobuf protocol for communicating persisted resources between master and slave.

723/#comment108587> Hm.. could you add some design description to this review or the ticket? I can't remember why we'd want to send it during re-registration, would be great to document the "protocol" for others as well! - Ben Mahler On Dec. 4, 2014

Re: Review Request 28720: Adjusted the calculation of unused resources in _launchTasks by considering persistent disk acquisition.

ps://reviews.apache.org/r/28720/#comment108539> Maybe comment on the fact that it's too big? That's why the task fails, right? src/tests/resource_offers_tests.cpp <https://reviews.apache.org/r/28720/#comment108537> Is this comment accurate? Where is the non-persistent di

Re: Review Request 29006: Added output streaming for persistence id.

006/#comment108578> Don't you need to change the `Resources::parse(...)` methods if you change this? - Ben Mahler On Dec. 12, 2014, 7:44 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 29084: Updated Allocator to allow transforming allocated resources.

thanks for catching that! - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29084/#review65384 --- On Dec. 17, 2

Re: Review Request 29177: Added a method in Resources to return all persistent disks.

ources persistentDisks = PersistentDiskFilter().apply(resources); - Ben Mahler On Dec. 17, 2014, 8:29 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 29179: Renamed totalResources in master to offeredResources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29179/#review65401 --- Ship it! Ship It! - Ben Mahler On Dec. 17, 2014, 8:30 p.m., Jie

Re: Review Request 29178: Disallowed empty DiskInfo.

g/r/29178/#comment108506> What about: ``` } else if (resource.disk().has_volume()) { return Error("Non-persistent disk volume is not supported"); } else { return Error("DiskInfo is set but empty"); } ``` - Ben Mahler On Dec. 17, 201

Re: Review Request 29134: Added an overload of Resources::contains for Resource object.

134/#comment108504> Can you add a NOTE here: // NOTE: We must validate 'that' because invalid resources can lead to false positives here, and are mesos::contains assumes resources are valid. // E.g. "cpus:-1" will always return true. - Ben Mahler On Dec. 1

Re: Review Request 29134: Added an overload of Resources::contains for Resource object.

bool _contains(const Resource& that) const; ``` src/common/resources.cpp <https://reviews.apache.org/r/29134/#comment108497> Mind adding a note here that we use _contains because Resources only contain valid Resource objects, and we don't want the performance hit of t

Re: Review Request 29084: Updated Allocator to allow transforming allocated resources.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29084/#review65211 ----------- On Dec. 17, 2014, 11:24 p.m., Ben Mahler wrote: > > --- &g

Re: Review Request 29084: Updated Allocator to allow transforming allocated resources.

https://reviews.apache.org/r/29084/diff/ Testing --- Added a test. Thanks, Ben Mahler

Re: Review Request 29083: Updated Sorter to allow transforming allocated resources.

_tests.cpp c2f4aa18db986d12d8364fe5ca3c0dc1b8f98040 Diff: https://reviews.apache.org/r/29083/diff/ Testing --- Added a test. Thanks, Ben Mahler

Re: Review Request 29083: Updated Sorter to allow transforming allocated resources.

ut now it's not relevant anymore. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29083/#review65210 ------- On Dec.

Re: Review Request 29083: Updated Sorter to allow transforming allocated resources.

> On Dec. 17, 2014, 1 a.m., Ben Mahler wrote: > > src/master/drf_sorter.hpp, lines 79-81 > > <https://reviews.apache.org/r/29083/diff/1/?file=792871#file792871line79> > > > > Jie and I were chatting and realized that since the sorter aggregates > > re

Re: Review Request 29083: Updated Sorter to allow transforming allocated resources.

eviews.apache.org/r/29083/#review65248 ------- On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 29089: Fixed the DRFSorter share calculation to not assume flattened resources.

s.apache.org/r/29089/#review65246 --- On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 29088: Removed an unnecessary helper in the sorter tests.

with implicit construction from initializer lists, given the issue benh reported. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29088/#review65217 ---------

Re: Review Request 29134: Added an overload of Resources::contains for Resource object.

134/#comment108354> Hm.. I must be missing something subtle here. Why is this necessary to point out and differentiate with _contains? Is it possible for a Resources object to contain an invalid Resource? - Ben Mahler On Dec. 17, 2014, 1:36 a.m., Jie Yu

Re: Review Request 28815: Converted an initial DRF integration test to a unit test.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28815/#review65250 --- On Dec. 11, 2014, 2:48 a.m., Ben Mahler wrote: > > --

Re: Review Request 29128: Added a Resources transformation for acquiring persistent disk.

tps://reviews.apache.org/r/29128/#comment108352> Looks like you can use EXPECT_SOME_EQ to avoid the separate statements? - Ben Mahler On Dec. 17, 2014, 1:10 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 29083: Updated Sorter to allow transforming allocated resources.

impler and non-idempotent which will fix the issue here (can have duplicate persistence IDs in the disk resources), but ideally we stop merging resources across slaves. At the very least a TODO is needed here! - Ben Mahler On Dec. 16, 2014, 6:28 a.m., Ben Mahler

Re: Review Request 29128: Added a Resources transformation for acquiring persistent disk.

ust curious, where will we catch a duplicate container path under the same executor? Do you have an integration test for this at least? Let's keep track of this extra case. - Ben Mahler On Dec. 16, 2014, 11:56 p.m., Jie Yu wrote: > > -

Re: Review Request 28720: Adjusted the calculation of unused resources in _launchTasks by considering persistent disk acquisition.

`? Might be a bit easier to read. src/common/resources.cpp <https://reviews.apache.org/r/28720/#comment108300> How about: ``` return Error("Insufficient disk resources"); ``` - Ben Mahler On Dec. 16, 2014, 9:11 p.m., Jie Yu wrote: > > ---

Re: Review Request 29018: Added abstraction for resources transformation.

if (applied.isSome()) { // Additional checks. } return applied; ``` src/common/resources.cpp <https://reviews.apache.org/r/29018/#comment108281> newline here? - Ben Mahler On Dec. 16, 2014, 9:10 p.m., Jie Yu wrote: > >

Re: Review Request 29018: Added abstraction for resources transformation.

> On Dec. 15, 2014, 9:29 p.m., Ben Mahler wrote: > > include/mesos/resources.hpp, lines 211-214 > > <https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line211> > > > > To keep consistent with the rest of the code base, couldn&#

Re: Review Request 29018: Added abstraction for resources transformation.

transformation would be exposed. The dependency in r/29084/ then assumes that apply() is a const method. - Ben Mahler On Dec. 13, 2014, 5:57 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Review Request 29083: Updated Sorter to allow transforming allocated resources.

sting --- Added a test. Thanks, Ben Mahler

Review Request 29088: Removed an unnecessary helper in the sorter tests.

Thanks, Ben Mahler

Review Request 29089: Fixed the DRFSorter share calculation to not assume flattened resources.

0516ab573d9f4f2af249978e15ebf52c2afb5359 Diff: https://reviews.apache.org/r/29089/diff/ Testing --- Added a test. Thanks, Ben Mahler

Review Request 29084: Updated Allocator to allow transforming allocated resources.

s.hpp 95fa520a3947474472cd36987c2342e1bfb51cfe src/tests/hierarchical_allocator_tests.cpp c43d3520a06dda6b48e74edfd692b3431fb639d2 src/tests/mesos.hpp bb24222c20cb5458b5c627d2001fc3cb1e542cce Diff: https://reviews.apache.org/r/29084/diff/ Testing --- Added a test. Thanks, Ben Mahler

Re: Review Request 29018: Added abstraction for resources transformation.

018/#comment108146> Applying a transformation should be a const operation, right? - Ben Mahler On Dec. 13, 2014, 5:57 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 29018: Added abstraction for resources transformation.

ould we keep the const argument semantics for now for consistency? Then the caller doesn't have to use 'new' as well. Thoughts? - Ben Mahler On Dec. 13, 2014, 5:57 a.m., Jie Yu wrote: > > --

Re: Review Request 28720: Adjusted the calculation of unused resources in _launchTasks by considering persistent disk acquisition.

non-persistent volumes are not supported..? And persistent volumes cannot be acquired from existing non-persistent volumes, only from regular disk resources? src/master/master.cpp <https://reviews.apache.org/r/28720/#comment107916> Yikes! Could we match the wrong role here? Shouldn&

Re: Review Request 28824: Fixed the two level sorting in the allocator.

of the allocation more clear. I'll add a comment about that. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28824/#review64958 ----------

Re: Review Request 28983: Added multiplication and division operators for Bytes.

, visit: https://reviews.apache.org/r/28983/#review64946 ------- On Dec. 12, 2014, 7:21 a.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 28983: Added multiplication and division operators for Bytes.

s://reviews.apache.org/r/28983/#review64924 ------- On Dec. 12, 2014, 7:21 a.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 28824: Fixed the two level sorting in the allocator.

src/tests/hierarchical_allocator_tests.cpp 7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09 Diff: https://reviews.apache.org/r/28824/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28984: Split apart the Bytes test.

, Ben Mahler

Review Request 28983: Added multiplication and division operators for Bytes.

subsequent review. Thanks, Ben Mahler

Review Request 28986: Removed Resources::extract in favor of reservation-based helpers.

rocess.hpp 610fcd97b76f8581cb3253237ab0948420b6949a src/tests/hierarchical_allocator_tests.cpp 7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09 Diff: https://reviews.apache.org/r/28986/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 28824: Fixed the two level sorting in the allocator.

tering this again. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28824/#review64653 --- On Dec. 8, 2014, 10:11 p.m.,

Re: Review Request 28824: Fixed the two level sorting in the allocator.

Ditto. Add a note about allocated resources are in either star role or > > framework's role. Thanks, added the same TODO as above. - Ben ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Review Request 28985: Updated Resources interface to expose reservations.

cfad93826f8a1f574c45fe7638d056bd5a275e54 Diff: https://reviews.apache.org/r/28985/diff/ Testing --- Added tests. make check Thanks, Ben Mahler

Review Request 28987: Added an allocator unit test for allocatable resources.

7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09 Diff: https://reviews.apache.org/r/28987/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 28812: Added a TODO in the master for an allocator bug.

e the ticket. Thanks! - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28812/#review64782 --- On Dec. 11, 2014, 1:45 a.m., Ben Mahler wro

Re: Review Request 28819: Moved ReservationAllocatorTest.ResourcesReturned to a unit test.

"*")```? > > Copy paste error? Gah, thank you Jie!! - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28819/#review64325 --------

Re: Review Request 28819: Moved ReservationAllocatorTest.ResourcesReturned to a unit test.

/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 28816: Moved DRFAllocatorTest.PerSlaveAllocation to a unit test.

----------- On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28816/ > -

Re: Review Request 28816: Moved DRFAllocatorTest.PerSlaveAllocation to a unit test.

/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 28817: Moved DRFAllocatorTest.SameShareAllocations to a unit test.

/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 28815: Converted an initial DRF integration test to a unit test.

t. Diffs (updated) - src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 src/tests/allocator_tests.cpp 8626362e5d45304a4800a807d5171178e457ff53 src/tests/hierarchical_allocator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/28815/diff/ Testing --- make check Th

Re: Review Request 28815: Converted an initial DRF integration test to a unit test.

Stream" of allocations in the allocator interface, rather than a callback. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28815/#review64317 ----------- On Dec. 11, 2014, 2:48 a.m., Ben

Re: Review Request 28815: Converted an initial DRF integration test to a unit test.

nerated e-mail. To reply, visit: https://reviews.apache.org/r/28815/#review64295 ------- On Dec. 11, 2014, 2:48 a.m., Ben Mahler wrote: > > --- > This is an automatic

Re: Review Request 28812: Added a TODO in the master for an allocator bug.

rong anyway), let me know if it makes more sense now Jie! - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28812/#review64296 ---------

Re: Review Request 28812: Added a TODO in the master for an allocator bug.

Thanks, Ben Mahler

Review Request 28887: Fixed a regression within libprocess link management.

/r/28887/diff/ Testing --- tested the regression manually, filed the following to enable programmatic testing: https://issues.apache.org/jira/browse/MESOS-2187 Thanks, Ben Mahler

Re: Review Request 28871: Added a benchmark to test large number of links for MESOS-2182.

--- On Dec. 9, 2014, 11:15 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28871/ > --- > > (Updated Dec. 9, 2014, 11:15

Re: Review Request 28871: Added a benchmark to test large number of links for MESOS-2182.

include vector? Now that you've changed it, can we split them? ``` vector linkers; vector linkees; ``` Or s/linkedProcesses/processes/ now that you've renamed it: ``` vector processes; ``` - Ben Mahler

Re: Review Request 28869: Added a hash function for Node.

://reviews.apache.org/r/28869/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 28869: Added a hash function for Node.

-mail. To reply, visit: https://reviews.apache.org/r/28869/#review64437 ----------- On Dec. 9, 2014, 9:07 p.m., Ben Mahler wrote: > > --- > This is an autom

Re: Review Request 28838: Fixed a long-standing performance issue in libprocess' SocketManager.

o simulate a production master a bit more accurately: 54 seconds (old code) vs 680 milliseconds (w/ this patch). Looks like the old code scales quite poorly. - Ben ----------- This is an automatically generated e-mail. To reply, visit: https:/

Re: Review Request 28838: Fixed a long-standing performance issue in libprocess' SocketManager.

he.org/r/28838/diff/ Testing --- make check Manually started a master and slave across machines, to ensure exit notifications were sent correctly. Thanks, Ben Mahler

Review Request 28869: Added a hash function for Node.

--- Needed this to store Node keys in hashmap. Diffs - 3rdparty/libprocess/include/process/node.hpp eb48c54cc1531d9f55213a58dd9496e969d5d7be Diff: https://reviews.apache.org/r/28869/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 28870: Renamed BenchmarkProcess in libprocess to PingPongProcess.

> (Updated Dec. 9, 2014, 8:50 p.m.) > > > Review request for mesos, Ben Mahler and Joris Van Remoortere. > > > Bugs: MESOS-2182 > https://issues.apache.org/jira/browse/MESOS-2182 > > > Repository: mesos-git > > > Description > ---

Re: Review Request 28838: Fixed a long-standing performance issue in libprocess' SocketManager.

when the key is not present. If we measure performance (jie is writing a benchmakr), perhaps we can remove this check (and others) to make it a bit easier to read! I'll follow up once we can measure. :) - Ben ------- This is

Re: Review Request 28838: Fixed a long-standing performance issue in libprocess' SocketManager.

gestions to make it easier! Diffs (updated) - 3rdparty/libprocess/src/process.cpp b87ac2206548815bc992c955252567c131fe6a47 Diff: https://reviews.apache.org/r/28838/diff/ Testing --- make check Manually started a master and slave across machines, to ensure exit notifications were sent correctly. Thanks, Ben Mahler

Re: Review Request 28854: Fixed build error caused by overloading socket call on CentOS 5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28854/#review64422 --- Ship it! Ship It! - Ben Mahler On Dec. 9, 2014, 5 p.m., Evelina

Review Request 28838: Fixed a long-standing performance issue in libprocess' SocketManager.

cross machines, to ensure exit notifications were sent correctly. Thanks, Ben Mahler

Review Request 28824: Fixed the two level sorting in the allocator.

/hierarchical_allocator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/28824/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28820: Simplified AllocatorTest.Whitelist by adding a unit test.

/ Testing --- make check Thanks, Ben Mahler

Review Request 28821: Documented the expected allocator sorting semantics.

expected sorting hierarchy, per MESOS-2176. Diffs - src/master/hierarchical_allocator_process.hpp f18346f435a16d1e6243315bffa00fabd164e310 Diff: https://reviews.apache.org/r/28821/diff/ Testing --- make check, no functional change Thanks, Ben Mahler

Review Request 28815: Converted an initial DRF integration test to a unit test.

/hierarchical_allocator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/28815/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28816: Moved DRFAllocatorTest.PerSlaveAllocation to a unit test.

- src/tests/hierarchical_allocator_tests.cpp PRE-CREATION src/tests/master_allocator_tests.cpp ea78893b1fa78da5cbdbabf1b4992910fe62b67c Diff: https://reviews.apache.org/r/28816/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28813: Added missing includes to sorter.hpp.

--- See summary. Diffs - src/master/sorter.hpp aabdd0d3755be2534e2f6cae13976277ca39deb1 Diff: https://reviews.apache.org/r/28813/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28818: Moved ReservationAllocatorTest.ReservedResources to a unit test.

. Diffs - src/tests/hierarchical_allocator_tests.cpp PRE-CREATION src/tests/master_allocator_tests.cpp a5eb5286cf4445ad43c9bfa454cd8d8d9a7c Diff: https://reviews.apache.org/r/28818/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28817: Moved DRFAllocatorTest.SameShareAllocations to a unit test.

- src/tests/hierarchical_allocator_tests.cpp PRE-CREATION src/tests/master_allocator_tests.cpp d28acbb41fb871efb368aacedddbace761e82eed Diff: https://reviews.apache.org/r/28817/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28819: Moved ReservationAllocatorTest.ResourcesReturned to a unit test.

. Diffs - src/tests/hierarchical_allocator_tests.cpp PRE-CREATION src/tests/master_allocator_tests.cpp 77ae0bed1ff42eb5a1bbda40030d2d8ea0487bd7 Diff: https://reviews.apache.org/r/28819/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 28814: Updated the allocator interface to enable unit testing.

Thanks, Ben Mahler

Review Request 28812: Added a TODO in the master for an allocator bug.

--- The existing comment is not accurate, given MESOS-621. Diffs - src/master/master.cpp b910665caa437f3f92c5abc14c0b8eab9a1ec5f3 Diff: https://reviews.apache.org/r/28812/diff/ Testing --- N/A Thanks, Ben Mahler

Re: Review Request 28789: Revised comment and improved implementation for socket call wrappers

connect/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28789/#comment106833> s/connected/connect/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28789/#comment106834> s/cound/bind/ - Ben Mahler On Dec. 7, 2014, 1:40 a.m., Evelina

Re: Review Request 28716: Created accept, bind, connect and getsockname wrappers for different protocol families

> On Dec. 6, 2014, 1:55 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 85 > > <https://reviews.apache.org/r/28716/diff/7/?file=783989#file783989line85> > > > > The pattern we use for succinctness and clarity in naming here is: > &g

Re: Review Request 28716: Created accept, bind, connect and getsockname wrappers for different protocol families

> On Dec. 6, 2014, 1:55 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 85 > > <https://reviews.apache.org/r/28716/diff/7/?file=783989#file783989line85> > > > > The pattern we use for succinctness and clarity in naming here is: > &g

Re: Review Request 28717: stout: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo

> On Dec. 6, 2014, 2:04 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 147 > > <https://reviews.apache.org/r/28717/diff/3/?file=784041#file784041line147> > > > > Let's call this "result" :) > &

Re: Review Request 28777: Remove dead source file (not referenced in makefile)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28777/#review64156 --- Ship it! Ship It! - Ben Mahler On Dec. 5, 2014, 11:28 p.m

Re: Review Request 28717: stout: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo

views.apache.org/r/28717/#comment106599> In general we avoid abbreviated names like "hints", and "results", which are _informative_ as to what they represent. :) 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/28717/#comment1

Re: Review Request 28716: Created accept, bind, connect and getsockname wrappers for different protocol families

> On Dec. 6, 2014, 1:55 a.m., Ben Mahler wrote: > > Thanks Evelina and Dominic! > > > > I don't have the context on this change, but there are a few general code > > quality items that were missed in review :( > > > > Could you please follow up on t

Re: Review Request 28716: Created accept, bind, connect and getsockname wrappers for different protocol families

ss::connect(...); ``` "try" is redundant here since it's encoded in the type. Ditto everywhere else. :) - Ben Mahler On Dec. 5, 2014, 9:21 p.m., Evelina Dumitrescu wrote: > >

Re: Review Request 28618: Splitted resource and resource usage checkers.

moving this line: ``` Resources resources = task.resources(); ``` Up to here, and then we could check empty correctly: ``` Resources taskResources = task.resources(); if (resources.empty()) { return Error("Task uses no resources"); } ``` - Ben Mahl

<    1   2   3   4   5   6   7   8   9   10   >