Re: Review Request 30606: Added net::contentLength() to query "content-length" field from HTTP header.

2015-02-18 Thread Nikita Vetoshkin
like a lot from uncompressed body. Do we somehow handle this case? If not - can we leave a comment about that? JFYI, there's Cteonnt-Length header, which containes uncompressed content size (not sure how widely it is used). - Nikita Vetoshkin On Feb. 18, 2015, 8:01 a.m.

Re: Review Request 30545: cgroups: added support to listen on memory pressures.

2015-02-03 Thread Nikita Vetoshkin
545/#comment116077> Wouldn't `new` throw instead of returning null? - Nikita Vetoshkin On Feb. 3, 2015, 5:28 a.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 29918: Introduced a generic checkpoint function.

2015-01-21 Thread Nikita Vetoshkin
918/#comment113474> Maybe we should try to remove temporary file (e.g. if we managed to create file, but write failed with ENOSPC)? - Nikita Vetoshkin On Jan. 21, 2015, 4:41 p.m., Michael Park wrote: > > --- > This is an automatica

Re: Review Request 25847: Refactor Libprocess: class Node

2014-09-19 Thread Nikita Vetoshkin
> On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/node.hpp, line 32 > > > > > > uint64_t? > > > > start getting ipv6 support in... ;) Still won't fit in ipv6 though :

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-08 Thread Nikita Vetoshkin
implemented in process.cpp, tested in http_tests.cpp. - Nikita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/#review52470 ------- On Sept. 5, 2014, 5 p.m., Nikita Vetoshkin wrote: > > -

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-05 Thread Nikita Vetoshkin
, Nikita Vetoshkin

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-05 Thread Nikita Vetoshkin
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/#review52400 --- On Sept. 4, 2014, 9:28 a.m., Nikita Vetoshkin wrote: > > --- >

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-09-05 Thread Nikita Vetoshkin
105/#comment91221> A bit offtopic, but there are issues with close() and EINTR at least on Linux: http://ewontfix.com/4/. TL;DR: EINTR returns with fd already closed and retrying could close another fd opened by any other thread. - Nikita Vetoshkin On Sept. 4, 2014, 11:01 p.m., P

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-09-05 Thread Nikita Vetoshkin
105/#comment91219> How about returning ErrnoError (seems it's the only way to get exact error reason from ifstream)? src/linux/cgroups.cpp <https://reviews.apache.org/r/25105/#comment91220> Shouldn't error message start with a capital letter? Same in other places down

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-05 Thread Nikita Vetoshkin
ps://reviews.apache.org/r/24984/#review52317 ------- On Sept. 4, 2014, 9:28 a.m., Nikita Vetoshkin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-04 Thread Nikita Vetoshkin
because we know content size beforehand - I propose to use Content-Length. Diffs (updated) - 3rdparty/libprocess/src/encoder.hpp 9c5aa81 Diff: https://reviews.apache.org/r/24984/diff/ Testing --- `make check` and manual testing with golang language native binding Thanks, Nikita

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-03 Thread Nikita Vetoshkin
270/#comment90906> Maybe add dockerInfo.network() value to error string? Could help debugging. src/docker/docker.cpp <https://reviews.apache.org/r/25270/#comment90907> Same here - Nikita Vetoshkin On Sept. 2, 2014, 8:47 p.m., Timoth

Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-08-22 Thread Nikita Vetoshkin
- 3rdparty/libprocess/src/encoder.hpp 9c5aa8134c101214d740bf231559ce5b5d51764c Diff: https://reviews.apache.org/r/24984/diff/ Testing --- `make check` and manual testing with golang language native binding Thanks, Nikita Vetoshkin

Re: Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Nikita Vetoshkin
tand where should "this" be added so it would make sense :). - Nikita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24939/#review51190 -------

Re: Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Nikita Vetoshkin
--- Built master and slave and check new error message by issuing the same commands in two separate consoles. Thanks, Nikita Vetoshkin

Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Nikita Vetoshkin
error message by issuing the same commands in two separate consoles. Thanks, Nikita Vetoshkin

Review Request 24840: fix attributes docstring

2014-08-19 Thread Nikita Vetoshkin
/browse/MESOS-1722 Repository: mesos-git Description --- fix attributes docstring Diffs - src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37 Diff: https://reviews.apache.org/r/24840/diff/ Testing --- built and manually checked help message Thanks, Nikita

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-18 Thread Nikita Vetoshkin
> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: > > I don't think that si_uid can give something interesting because it can be > > either 0 or UID of receiving process. How about logging si_pid too? > > Ben Mahler wrote: > si_uid represents the user id

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-18 Thread Nikita Vetoshkin
> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: > > I don't think that si_uid can give something interesting because it can be > > either 0 or UID of receiving process. How about logging si_pid too? > > Ben Mahler wrote: > si_uid represents the user id

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Nikita Vetoshkin
> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: > > I don't think that si_uid can give something interesting because it can be > > either 0 or UID of receiving process. How about logging si_pid too? > > Ben Mahler wrote: > si_uid represents the user id

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Nikita Vetoshkin
se it can be either 0 or UID of receiving process. How about logging si_pid too? - Nikita Vetoshkin On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 22593: added interfaces to find host public and loopback interface

2014-06-16 Thread Nikita Vetoshkin
g/r/22593/#comment80776> "man netdevice" mentions IFF_LOOPBACK flag whith should be set in ifa_flags attribute of struct ifaddrs. Seems like it is right what we need here, doesn't it? - Nikita Vetoshkin On June 16, 2014, 7:01

[jira] [Commented] (MESOS-1474) Provide cluster maintenance primitives for operators.

2014-06-15 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031854#comment-14031854 ] Nikita Vetoshkin commented on MESOS-1474: - Just a quick note about: {q

[jira] [Commented] (MESOS-1404) Glibc 'fork()' is not async signal safe

2014-05-22 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006145#comment-14006145 ] Nikita Vetoshkin commented on MESOS-1404: - Anyway this can be redesigned to a

[jira] [Comment Edited] (MESOS-1404) Glibc 'fork()' is not async signal safe

2014-05-22 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006145#comment-14006145 ] Nikita Vetoshkin edited comment on MESOS-1404 at 5/22/14 5:1

[jira] [Commented] (MESOS-1228) Container level network monitoring

2014-04-22 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976664#comment-13976664 ] Nikita Vetoshkin commented on MESOS-1228: - What about [net_cls cgroup|h

Re: Review Request 20277: Introduced 'libprocess-from' to identify a libprocess "message".

2014-04-13 Thread Nikita Vetoshkin
g/r/20277/#comment73162> How about using "Libprocess-From" as many clients use camel case and currently headers are case sensitive according to https://issues.apache.org/jira/browse/MESOS-328 - Nikita Vetoshkin On April 12, 2014, 11:41 p.m., Benjam

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962124#comment-13962124 ] Nikita Vetoshkin commented on MESOS-1195: - I see, thanks! > Systemd :

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962118#comment-13962118 ] Nikita Vetoshkin commented on MESOS-1195: - Is it a good idea? I mean doe

[jira] [Commented] (MESOS-1195) Systemd : cgroups fails on co-mounted subsystem

2014-04-07 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962107#comment-13962107 ] Nikita Vetoshkin commented on MESOS-1195: - Are you trying to make m

Re: Review Request 19702: Added linux routing library for network isolation.

2014-03-30 Thread Nikita Vetoshkin
702/#comment71402> Can we include the reason in error message? Maybe the same way as done for rtnl_link_alloc_cache and other - Nikita Vetoshkin On March 29, 2014, 5:59 a.m., Jie Yu wrote: > > --- > This is an automatically gener

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2014-03-20 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942782#comment-13942782 ] Nikita Vetoshkin commented on MESOS-816: * About {{wait}} - great, th

Re: Review Request 19162: Added optional envvar map to subprocess.

2014-03-18 Thread Nikita Vetoshkin
> On March 18, 2014, 10:57 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 52 > > > > > > It would only really change line 71. Given the execle call expects a > > char** eventually, i'd rath

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2014-03-18 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939576#comment-13939576 ] Nikita Vetoshkin commented on MESOS-816: Was poking around with a stick and I

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2014-03-18 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939469#comment-13939469 ] Nikita Vetoshkin commented on MESOS-816: {quote} Does it make sense to use

Re: Review Request 19162: Added optional envvar map to subprocess.

2014-03-17 Thread Nikita Vetoshkin
org/r/19162/#comment68983> What about using std::vector to hold prepared env? Maybe it would look cleaner? - Nikita Vetoshkin On March 17, 2014, 7:33 p.m., Dominic Hamon wrote: > > --- > This is an automatically gener

[jira] [Commented] (MESOS-1102) Add ability to process::subprocess to run function within child context

2014-03-17 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938124#comment-13938124 ] Nikita Vetoshkin commented on MESOS-1102: - I'd rather vote too for hav

[jira] [Commented] (MESOS-1102) Add ability to process::subprocess to run function within child context

2014-03-16 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937498#comment-13937498 ] Nikita Vetoshkin commented on MESOS-1102: - It's the least I can do

[jira] [Commented] (MESOS-1102) Add ability to process::subprocess to run function within child context

2014-03-16 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937023#comment-13937023 ] Nikita Vetoshkin commented on MESOS-1102: - Yes. It's a common and pr

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2014-03-13 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934642#comment-13934642 ] Nikita Vetoshkin commented on MESOS-816: I saw that, it's just a string

Re: Review Request 19162: Added optional envvar map to subprocess.

2014-03-13 Thread Nikita Vetoshkin
org/r/19162/#comment68354> Why not putenv explicitly in child process or use execle? - Nikita Vetoshkin On March 13, 2014, 5:59 p.m., Dominic Hamon wrote: > > --- > This is an automatically generated e-mail. To reply,

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2014-03-10 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13929957#comment-13929957 ] Nikita Vetoshkin commented on MESOS-816: Definitely :) But I was talking a

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2014-03-10 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926181#comment-13926181 ] Nikita Vetoshkin commented on MESOS-816: Just looking at slave<->con

Re: Review Request 18945: Add --version flag to mesos master and slave

2014-03-09 Thread Nikita Vetoshkin
src/slave/main.cpp a498a6ae6a79c7155c07a5d6dc2d6c9dc8ae060f Diff: https://reviews.apache.org/r/18945/diff/ Testing --- make check passes, manually tested --version option on master and slave Thanks, Nikita Vetoshkin

Review Request 18945: Add --version flag to mesos master and slave

2014-03-09 Thread Nikita Vetoshkin
rg/r/18945/diff/ Testing --- make check passes, manually tested --version option on master and slave Thanks, Nikita Vetoshkin

Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

2014-03-07 Thread Nikita Vetoshkin
563> Efficient what? :) Seems like ending is missing - Nikita Vetoshkin On March 7, 2014, 5:39 p.m., Timothy St. Clair wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Commented] (MESOS-1010) Python extension build is broken if gflags-dev is installed

2014-03-05 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921206#comment-13921206 ] Nikita Vetoshkin commented on MESOS-1010: - I'd rather vote for A for now

[jira] [Commented] (MESOS-1027) IPv6 support

2014-02-25 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911889#comment-13911889 ] Nikita Vetoshkin commented on MESOS-1027: - It'll require protocol updat

[jira] [Commented] (MESOS-1027) IPv6 support

2014-02-22 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909354#comment-13909354 ] Nikita Vetoshkin commented on MESOS-1027: - That would be great, as IPv6 is a

[jira] [Commented] (MESOS-1027) IPv6 support

2014-02-21 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908743#comment-13908743 ] Nikita Vetoshkin commented on MESOS-1027: - +1 on this. Any suggestions? Loo

[jira] [Commented] (MESOS-361) Restrict the character space of user provided identifiers.

2014-02-20 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907310#comment-13907310 ] Nikita Vetoshkin commented on MESOS-361: I think 2. is good choice - fail fast

[jira] [Commented] (MESOS-1010) Python extension build is broken if gflags-dev is installed

2014-02-20 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906816#comment-13906816 ] Nikita Vetoshkin commented on MESOS-1010: - Yep, mesos fails to start a

[jira] [Updated] (MESOS-1010) Python extension build is broken if gflags-dev is installed

2014-02-20 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Vetoshkin updated MESOS-1010: Description: In my environment mesos build from master results in broken python api module

[jira] [Commented] (MESOS-1010) Python extension build is broken if gflags-dev is installed

2014-02-20 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906801#comment-13906801 ] Nikita Vetoshkin commented on MESOS-1010: - [~vinodkone], done! >

[jira] [Commented] (MESOS-1010) Undefined symbol in Python extension

2014-02-19 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906662#comment-13906662 ] Nikita Vetoshkin commented on MESOS-1010: - Should this issue be closed and

Re: Review Request 18272: Add -lgflags to linker flags when building python extension module

2014-02-19 Thread Nikita Vetoshkin
t; make[2]: *** [python/dist/mesos-0.19.0-py2.6-linux-x86_64.egg] Error 1 > make[2]: *** Waiting for unfinished jobs > Looks like this review should be dropped as well as the issue itself. - Nikita ------- Thi

[jira] [Commented] (MESOS-1010) Undefined symbol in Python extension

2014-02-19 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906009#comment-13906009 ] Nikita Vetoshkin commented on MESOS-1010: - Yep, looks like it is the caus

Review Request 18272: Add -lgflags to linker flags when building python extension module

2014-02-19 Thread Nikita Vetoshkin
without this flag. Thanks, Nikita Vetoshkin

[jira] [Commented] (MESOS-1010) Undefined symbol in Python extension

2014-02-19 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905508#comment-13905508 ] Nikita Vetoshkin commented on MESOS-1010: - Much better, thanks! > Un

[jira] [Commented] (MESOS-930) Provide slave<->executor protocol

2014-02-18 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904255#comment-13904255 ] Nikita Vetoshkin commented on MESOS-930: Took a look (with {{strace}}) at

[jira] [Commented] (MESOS-1010) Undefined symbol in Python extension

2014-02-17 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903513#comment-13903513 ] Nikita Vetoshkin commented on MESOS-1010: - Why doesn't formatting work

[jira] [Created] (MESOS-1010) Undefined symbol in Python extension

2014-02-17 Thread Nikita Vetoshkin (JIRA)
Nikita Vetoshkin created MESOS-1010: --- Summary: Undefined symbol in Python extension Key: MESOS-1010 URL: https://issues.apache.org/jira/browse/MESOS-1010 Project: Mesos Issue Type: Bug

[jira] [Commented] (MESOS-1007) Python framework unable to parse framework messages

2014-02-17 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903473#comment-13903473 ] Nikita Vetoshkin commented on MESOS-1007: - {quote} This part of your log l

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
split libprocess, stout and Mesos > > patches into separate patches. Can you move this to another RR and make it > > a dependency for this one? > > Nikita Vetoshkin wrote: > Yeah, sure. I just don't know how to make a dependency.

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
s.cpp 62ab64d81c11ab7260620c91100b7e1f29b81e33 3rdparty/libprocess/src/tests/process_tests.cpp be288c353dce78ef641708646979e2e4f3f2c504 Diff: https://reviews.apache.org/r/18001/diff/ Testing --- None. Thanks, Nikita Vetoshkin

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
18001/diff/ Testing --- None. Thanks, Nikita Vetoshkin

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
s probably more work > > than this is worth for now. That didn't work, linker gone crazy complaining about "multiple definition of `process::socket(int, int, int)'" :( - Nikita --- This is an automatically genera

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18001/#review34305 --- On Feb. 12, 2014, 6:49 p.m., Nikita Vetoshkin wrote: > > -

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
for this one? Yeah, sure. I just don't know how to make a dependency... - Nikita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18001/#review34306 ------- On Feb. 12, 2014, 6:49 p.m., Nikita Vet

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
https://reviews.apache.org/r/18001/diff/ Testing --- None. Thanks, Nikita Vetoshkin

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-02-12 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899394#comment-13899394 ] Nikita Vetoshkin commented on MESOS-912: Yep, I messed up a bit with updating

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
https://reviews.apache.org/r/18001/diff/ Testing --- None. Thanks, Nikita Vetoshkin

[jira] [Updated] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-02-12 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Vetoshkin updated MESOS-912: --- Attachment: mesos-912-2.diff Just in case attaching new patch with fixes on Linux and (as

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-02-12 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899219#comment-13899219 ] Nikita Vetoshkin commented on MESOS-912: Network programming on Mac OS is tru

Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
s.hpp bba6f43eaeba0238a5db6e388902d92eb18f14f5 Diff: https://reviews.apache.org/r/18001/diff/ Testing --- None. Thanks, Nikita Vetoshkin

Review Request 18001: Disable SIGPIPE on MacOS upon socket creation

2014-02-12 Thread Nikita Vetoshkin
f14f5 3rdparty/libprocess/src/net.hpp 2fdc62adc4295a7723da0162a60853bc64c7073c 3rdparty/libprocess/src/process.cpp 2e7764a8e0badec704b8610f3f72f0bd16cc9612 Diff: https://reviews.apache.org/r/18001/diff/ Testing --- None. Thanks, Nikita Vetoshkin

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-02-12 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898985#comment-13898985 ] Nikita Vetoshkin commented on MESOS-912: Yep, I would gladly do that, but I d

[jira] [Updated] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-02-11 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Vetoshkin updated MESOS-912: --- Attachment: mesos-912.diff Proposed patch to disable SIGPIPE on Mac OS. Not tested. > Sl

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-02-11 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898814#comment-13898814 ] Nikita Vetoshkin commented on MESOS-912: Seems like Mac OS doesn&#x

[jira] [Commented] (MESOS-930) Provide slave<->executor protocol

2014-01-30 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886994#comment-13886994 ] Nikita Vetoshkin commented on MESOS-930: Leaving on vacation fully loaded with

[jira] [Commented] (MESOS-930) Provide slave<->executor protocol

2014-01-28 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884398#comment-13884398 ] Nikita Vetoshkin commented on MESOS-930: Stepping back and giving this tho

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-27 Thread Nikita Vetoshkin
> On Jan. 27, 2014, 7:53 a.m., Ian Downes wrote: > > What about supporting environment variables specific to the child process? > > This is necessary for distinct environments between different subprocesses > > and the parent. This could be done by prepending the command with 'env' but > > it'

[jira] [Commented] (MESOS-943) Provide an abstraction for asynchronous launching of subprocesses.

2014-01-24 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880879#comment-13880879 ] Nikita Vetoshkin commented on MESOS-943: I think it could a good thing to men

[jira] [Updated] (MESOS-930) Provide slave<->executor protocol

2014-01-20 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Vetoshkin updated MESOS-930: --- Description: This ticket is the result of the discussion started in mailing list (http

[jira] [Created] (MESOS-930) Provide slave<->executor protocol

2014-01-20 Thread Nikita Vetoshkin (JIRA)
Nikita Vetoshkin created MESOS-930: -- Summary: Provide slave<->executor protocol Key: MESOS-930 URL: https://issues.apache.org/jira/browse/MESOS-930 Project: Mesos Issue Type: Impro

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-01-17 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875295#comment-13875295 ] Nikita Vetoshkin commented on MESOS-912: Sorry if I am annoying - just cur

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-01-17 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875294#comment-13875294 ] Nikita Vetoshkin commented on MESOS-912: Ah, sorry... Read the manual again

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-01-16 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874459#comment-13874459 ] Nikita Vetoshkin commented on MESOS-912: Please, correct me if I'm wrong.

[jira] [Commented] (MESOS-915) Draft FAQ to be included in project documentation

2014-01-16 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873891#comment-13873891 ] Nikita Vetoshkin commented on MESOS-915: * Roadmap maybe? * I'd be i

[jira] [Commented] (MESOS-912) Slave sometimes crashes with SIGPIPE

2014-01-16 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873299#comment-13873299 ] Nikita Vetoshkin commented on MESOS-912: Seems like {{signal(SIGPIPE, SIG

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2013-12-11 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845371#comment-13845371 ] Nikita Vetoshkin commented on MESOS-816: Oh, reviews are great! Could you pro

[jira] [Commented] (MESOS-727) Investigate Google's open source container stack for isolation

2013-12-10 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845108#comment-13845108 ] Nikita Vetoshkin commented on MESOS-727: Thanks a lot! > Investigate G

[jira] [Commented] (MESOS-727) Investigate Google's open source container stack for isolation

2013-12-10 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844602#comment-13844602 ] Nikita Vetoshkin commented on MESOS-727: Sorry to bother, but could give a q

[jira] [Commented] (MESOS-816) Allow delegation to shell scripts for isolation

2013-12-10 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844569#comment-13844569 ] Nikita Vetoshkin commented on MESOS-816: A few random thoughts from a strange

[jira] [Commented] (MESOS-825) Querying Slave Status uses wrong host

2013-11-21 Thread Nikita Vetoshkin (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829185#comment-13829185 ] Nikita Vetoshkin commented on MESOS-825: Is there a jira for such a clumsy e