Re: Cgroups v2 + Python 3 + Upstreaming X/Twitter Patches

2024-04-17 Thread Tobi Knaup
Great to see the early crew coming out of the woodwork. You guys are awesome! On Wed, Apr 17, 2024 at 16:30 Marcel Neuhausler wrote: > Very very happy to see Benjamin and team at X contributing those patches, > including urgently needed support for cgroups v2, to the open-source > version. > >

Re: Review Request 17082: Fixed display of table filter for empty tables

2014-10-14 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17082/#review56538 --- Ship it! Ship It! - Tobi Knaup On Jan. 18, 2014, 1:05 a.m

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-10-02 Thread Tobi Knaup
/tests/master_tests.cpp 1497db2 src/webui/master/static/framework.html f6cce02 src/webui/master/static/frameworks.html b11d71a Diff: https://reviews.apache.org/r/26125/diff/ Testing --- Connected a framework with and without webui_url set and checked the web ui. Thanks, Tobi Knaup

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-10-01 Thread Tobi Knaup
webui_url set and checked the web ui. Thanks, Tobi Knaup

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-10-01 Thread Tobi Knaup
://reviews.apache.org/r/26125/#review55010 --- On Oct. 2, 2014, 12:19 a.m., Tobi Knaup wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-09-27 Thread Tobi Knaup
Diff: https://reviews.apache.org/r/26125/diff/ Testing --- Connected a framework with and without webui_url set and checked the web ui. Thanks, Tobi Knaup

[jira] [Created] (MESOS-1524) Implement Docker support in Mesos, instead of relying on external projects.

2014-06-20 Thread Tobi Knaup (JIRA)
Tobi Knaup created MESOS-1524: - Summary: Implement Docker support in Mesos, instead of relying on external projects. Key: MESOS-1524 URL: https://issues.apache.org/jira/browse/MESOS-1524 Project: Mesos

[jira] [Updated] (MESOS-1524) Implement Docker support in Mesos

2014-06-20 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobi Knaup updated MESOS-1524: -- Summary: Implement Docker support in Mesos (was: Implement Docker support in Mesos, instead

[jira] [Commented] (MESOS-1524) Implement Docker support in Mesos

2014-06-20 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039685#comment-14039685 ] Tobi Knaup commented on MESOS-1524: --- 1. would probably be easiest because Deimos already

Re: Review Request 21052: Introduced a HealthCheck protobuf.

2014-05-15 Thread Tobi Knaup
case where you would want to redefine 4xx and 5xx as healthy. Maybe just remove statuses altogether? - Tobi Knaup On May 8, 2014, 7:42 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 20874: Fix distclean break during maven clean up

2014-04-29 Thread Tobi Knaup
://reviews.apache.org/r/20874/diff/ Testing --- ../configure make make distclean Thanks, Tobi Knaup

[jira] [Commented] (MESOS-1268) distclean break during maven clean up

2014-04-29 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985093#comment-13985093 ] Tobi Knaup commented on MESOS-1268: --- Review: https://reviews.apache.org/r/20874

Re: Review Request 20874: Fix distclean break during maven clean up

2014-04-29 Thread Tobi Knaup
. Diffs (updated) - src/Makefile.am d36700f Diff: https://reviews.apache.org/r/20874/diff/ Testing --- ../configure make make distclean Thanks, Tobi Knaup

Re: Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-25 Thread Tobi Knaup
-multiple-executors-framework.in eb8edf6 src/java/MESOS-MAVEN-README 2da6646 src/java/mesos.pom.in 8f9b747 Diff: https://reviews.apache.org/r/20402/diff/ Testing --- make check make maven-install Thanks, Tobi Knaup

[jira] [Commented] (MESOS-1203) Shade protobuf dependency in Mesos Java library

2014-04-22 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976967#comment-13976967 ] Tobi Knaup commented on MESOS-1203: --- Great comments all. It seems that shading

[jira] [Commented] (MESOS-1203) Shade protobuf dependency in Mesos Java library

2014-04-21 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975716#comment-13975716 ] Tobi Knaup commented on MESOS-1203: --- Thanks for investigating this Ben. Building

[jira] [Commented] (MESOS-1203) Shade protobuf dependency in Mesos Java library

2014-04-21 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975800#comment-13975800 ] Tobi Knaup commented on MESOS-1203: --- Good point [~berngp]. The user experience is better

Re: Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-16 Thread Tobi Knaup
--- On April 16, 2014, 4:15 a.m., Tobi Knaup wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20402/ --- (Updated April 16, 2014, 4:15

Re: Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-16 Thread Tobi Knaup
/ Testing --- make check make maven-install Thanks, Tobi Knaup

Re: Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-16 Thread Tobi Knaup
--- make check make maven-install Thanks, Tobi Knaup

Re: Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-16 Thread Tobi Knaup
://reviews.apache.org/r/20402/diff/ Testing --- make check make maven-install Thanks, Tobi Knaup

[jira] [Assigned] (MESOS-1212) Use maven to compile and package Mesos' Java files.

2014-04-15 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobi Knaup reassigned MESOS-1212: - Assignee: Tobi Knaup Use maven to compile and package Mesos' Java files

Re: Review Request 20329: Shade protobuf dependency.

2014-04-15 Thread Tobi Knaup
namespace. - Tobi Knaup On April 14, 2014, 5:44 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20329

[jira] [Commented] (MESOS-336) Mesos slave should cache executors

2014-04-15 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970274#comment-13970274 ] Tobi Knaup commented on MESOS-336: -- You could leverage the ETag HTTP header. It's usually

Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-15 Thread Tobi Knaup
src/examples/java/test-multiple-executors-framework.in eb8edf6 src/java/mesos.pom.in 8f9b747 Diff: https://reviews.apache.org/r/20402/diff/ Testing --- make check make maven-install Thanks, Tobi Knaup

[jira] [Commented] (MESOS-1212) Use maven to compile and package Mesos' Java files.

2014-04-15 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970406#comment-13970406 ] Tobi Knaup commented on MESOS-1212: --- Review: https://reviews.apache.org/r/20402

[jira] [Commented] (MESOS-1199) Subprocess is slow - gated by process::reap poll interval

2014-04-09 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964768#comment-13964768 ] Tobi Knaup commented on MESOS-1199: --- [~bmahler] here you go: https://gist.github.com

Re: Review Request 20052: Replace CHECK with Failure for exec in MesosContainerizer

2014-04-05 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20052/#review39644 --- Ship it! lgtm as a quick fix. - Tobi Knaup On April 4, 2014, 9

[jira] [Commented] (MESOS-1193) Check failed: promises.contains(containerId) crashes slave

2014-04-05 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961318#comment-13961318 ] Tobi Knaup commented on MESOS-1193: --- Not sure what really happened, can't find much

[jira] [Created] (MESOS-1193) Check failed: promises.contains(containerId) crashes slave

2014-04-04 Thread Tobi Knaup (JIRA)
Tobi Knaup created MESOS-1193: - Summary: Check failed: promises.contains(containerId) crashes slave Key: MESOS-1193 URL: https://issues.apache.org/jira/browse/MESOS-1193 Project: Mesos Issue

Review Request 20004: Link to Javadoc, reorg framework developer links

2014-04-03 Thread Tobi Knaup
Description --- * add link to Javadoc * remove CLI flags from framework dev section (not relevant) * move code internals link to contributing section Diffs - docs/home.md 07c72c1 Diff: https://reviews.apache.org/r/20004/diff/ Testing --- Thanks, Tobi Knaup

Re: Review Request 19859: Improve javadoc (use @param, @return, etc)

2014-04-01 Thread Tobi Knaup
/mesos/state/Variable.java bedb74b src/java/src/org/apache/mesos/state/ZooKeeperState.java f3d939f Diff: https://reviews.apache.org/r/19859/diff/ Testing --- Thanks, Tobi Knaup

Review Request 19859: Improve javadoc (use @param, @return, etc)

2014-03-31 Thread Tobi Knaup
: https://reviews.apache.org/r/19859/diff/ Testing --- Thanks, Tobi Knaup

Re: Review Request 19859: Improve javadoc (use @param, @return, etc)

2014-03-31 Thread Tobi Knaup
/Variable.java bedb74b src/java/src/org/apache/mesos/state/ZooKeeperState.java f3d939f Diff: https://reviews.apache.org/r/19859/diff/ Testing --- Thanks, Tobi Knaup

Re: Review Request 19859: Improve javadoc (use @param, @return, etc)

2014-03-31 Thread Tobi Knaup
--- On April 1, 2014, 2:33 a.m., Tobi Knaup wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19859

[jira] [Assigned] (MESOS-570) Generate Javadocs

2014-03-28 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobi Knaup reassigned MESOS-570: Assignee: Tobi Knaup Generate Javadocs - Key: MESOS-570

[jira] [Commented] (MESOS-570) Generate Javadocs

2014-03-28 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951318#comment-13951318 ] Tobi Knaup commented on MESOS-570: -- I'm adding a rake task to the site generator

[jira] [Updated] (MESOS-570) Generate Javadocs

2014-03-28 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobi Knaup updated MESOS-570: - Attachment: javadoc.diff Reviewboard isn't hooked up to the SVN repo so I'm posting the patch here

[jira] [Assigned] (MESOS-135) Improve javadoc (use @param, @return, etc)

2014-03-28 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobi Knaup reassigned MESOS-135: Assignee: Tobi Knaup Improve javadoc (use @param, @return, etc

Re: Review Request 18826: Add developer tools, update list of frameworks.

2014-03-09 Thread Tobi Knaup
://reviews.apache.org/r/18826/diff/ Testing --- Thanks, Tobi Knaup

Review Request 18826: Add developer tools, update list of frameworks.

2014-03-05 Thread Tobi Knaup
summary Diffs - docs/home.md 84484b4 docs/mesos-frameworks.md 62838c9 docs/tools.md c71b876 Diff: https://reviews.apache.org/r/18826/diff/ Testing --- Thanks, Tobi Knaup

Review Request 18328: New documentation page for frameworks

2014-02-20 Thread Tobi Knaup
f47c921 Diff: https://reviews.apache.org/r/18328/diff/ Testing --- Thanks, Tobi Knaup

[jira] [Commented] (MESOS-361) Restrict the character space of user provided identifiers.

2014-02-20 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907786#comment-13907786 ] Tobi Knaup commented on MESOS-361: -- : breaks Java frameworks because the working dir

Review Request 18232: Update the list of Mesos frameworks on the website

2014-02-18 Thread Tobi Knaup
Description --- see summary Diffs - docs/powered-by-mesos.md 7c2e93a Diff: https://reviews.apache.org/r/18232/diff/ Testing --- Thanks, Tobi Knaup

Re: Review Request 18232: Update the list of Mesos frameworks on the website

2014-02-18 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18232/#review34747 --- On Feb. 18, 2014, 6:59 p.m., Tobi Knaup wrote

[jira] [Commented] (MESOS-855) Move JNI code to separate library

2013-12-02 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836866#comment-13836866 ] Tobi Knaup commented on MESOS-855: -- Huge +1 This is an issue on most Linux distros when

[jira] [Commented] (MESOS-577) bootstrap fails with automake 1.14

2013-09-17 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769604#comment-13769604 ] Tobi Knaup commented on MESOS-577: -- Chatted with benh yesterday, looks like it's a nasty

Re: Review Request 14183: Check for automake 1.14 in bootstrap.

2013-09-17 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14183/#review26191 --- Ship it! Ship It! - Tobi Knaup On Sept. 17, 2013, 10:25 p.m

[jira] [Commented] (MESOS-577) bootstrap fails with automake 1.14

2013-09-16 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768635#comment-13768635 ] Tobi Knaup commented on MESOS-577: -- Vinod: I get the same on 1.14. Looks like my patch