----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21052/#review42552 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/21052/#comment76358> port, path, ssl could be nicely captured in a URL include/mesos/mesos.proto <https://reviews.apache.org/r/21052/#comment76359> It's pretty common to accept 200-399 per default. Some folks will be surprised if we silently accept errors as healthy. I also can't think of a use case where you would want to redefine 4xx and 5xx as healthy. Maybe just remove statuses altogether? - Tobi Knaup On May 8, 2014, 7:42 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21052/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 7:42 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-741 > https://issues.apache.org/jira/browse/MESOS-741 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto e48e50aae248bd9d5289dbaa36753be53b2e592a > src/master/master.cpp bfe48bc2fd9528db2888ea472932a92dd8b106eb > > Diff: https://reviews.apache.org/r/21052/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
