Re: Project wide updates to #include statements

+1 to cody's suggestion for stout / libprocess. Looking forward to seeing include style automated, will help us be more effective with reviews. :) It looks like we can further modify "include what you use" to capture stout and libprocess headers, probably worth the effort: https://github.com/goog

Re: Project wide updates to #include statements

On Thu, Jun 25, 2015 at 5:01 PM Paul Brett wrote: > As Kapil has pointed out on MESOS-2927, all the library files should be > identified by '#include <...>' and all the project files should use > '#include "..."' - i don't know yet if we have been consistent about this. > They aren't consistent

Re: Project wide updates to #include statements

Thanks Marco, it would be great to get to a better checker and then turn on more checks for the things we normally comment on in reviews. The style guide currently states the following order: 1. dir2/foo2.h. 2. C system files. 3. C++ system files. 4. Other libraries' .h files. 5.

Re: Project wide updates to #include statements

As I mentioned in the review that Paul submitted, I've been working on cpplint.py to make it more Mesos-friendly. I have also submitted a few Pull Requests to the original github repo, but got neither love nor attention. My fork is here: https://github.

Project wide updates to #include statements

​The style guide prescribes the order of header file inclusions for the project and requires that we #include or make explicit forward declarations for any functions we use, however we were only enforcing this at review time manually and not commit time. I would like to turn on the checks at comm