Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 5:18 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review58966 --- Patch looks great! Reviews applied: [27023, 27054] All tests passe

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review58907 --- 3rdparty/libprocess/include/process/socket.hpp

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-29 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review59042 --- 3rdparty/libprocess/include/process/socket.hpp

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 9:47 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review59063 --- Patch looks great! Reviews applied: [27350, 27023, 27054] All test

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 10:42 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/#review59083 --- Bad patch! Reviews applied: [27350, 27351, 27350] Failed command:

Re: Review Request 27054: Libprocess Socket: introduce connect()

2014-11-12 Thread Niklas Nielsen
> On Oct. 29, 2014, 4:57 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [27350, 27351, 27350] > > > > Failed command: ./support/apply-review.sh -n -r 27350 > > > > Error: > > 2014-10-29 23:57:20 URL:https://reviews.apache.org/r/27350/diff/raw/ > > [897/897] -> "27350.pa