Review Request 12880: Compute framework stats in one iteration

2013-07-23 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/ --- Review request for mesos. Repository: mesos-git Description --- Compute

Re: Review Request 12880: Compute framework stats in one iteration

2013-07-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/#review23874 --- src/webui/master/static/js/controllers.js

Re: Review Request 12880: Compute framework stats in one iteration

2013-07-25 Thread Ross Allen
> On July 25, 2013, 9:23 p.m., Ben Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 456-468 > > > > > > Can you move this down to where it's used? I defined them outside the scope of `var update = fu

Re: Review Request 12880: Compute framework stats in one iteration

2013-07-25 Thread Ben Mahler
> On July 25, 2013, 9:23 p.m., Ben Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 456-468 > > > > > > Can you move this down to where it's used? > > Ross Allen wrote: > I defined them outside t

Re: Review Request 12880: Compute framework stats in one iteration

2013-07-26 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/ --- (Updated July 26, 2013, 6:23 p.m.) Review request for mesos. Changes ---

Re: Review Request 12880: Compute framework stats in one iteration

2013-07-26 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/#review23985 --- Ship it! Ship It! - Ben Mahler On July 26, 2013, 6:23 p.m., Ross